Make sure that clients can't access buffers belonging to other users
authorMarcus Eggenberger <egs@quassel-irc.org>
Sun, 24 Nov 2013 16:03:34 +0000 (17:03 +0100)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 24 Nov 2013 16:10:11 +0000 (17:10 +0100)
commita1a24daa615a4e0679546c8a7a673720d0dcc60f
tree72e0d9fb0e37d6a8730395e3b39d80e7b3bf029e
parentba6a9ce10750a65f0ba36281ceb45d7857ac076d
Make sure that clients can't access buffers belonging to other users

A manipulated, but properly authenticated client was able to retrieve
the backlog of other users on the same core in some cases by providing
an appropriate BufferID to the storage engine. Note that proper
authentication was still required, so exploiting this requires
malicious users on your core. This commit fixes this issue by ensuring
that foreign BufferIDs are off-limits.
src/core/SQL/PostgreSQL/16/select_buffer_by_id.sql
src/core/SQL/PostgreSQL/16/update_network.sql
src/core/SQL/SQLite/17/select_buffer_by_id.sql