qa: Don't return a const ref from Settings::localValue()
authorManuel Nickschas <sputnick@quassel-irc.org>
Mon, 10 Sep 2018 21:24:07 +0000 (23:24 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Mon, 10 Sep 2018 23:46:55 +0000 (01:46 +0200)
commit7a878bda2ba617ff2eac98b7089f0f0053a9ea30
treeec2568dbf871b8ee159894c0dda5520aad98d652
parent29252b7065315dfb5b4a226f7ab7998bfd08ee65
qa: Don't return a const ref from Settings::localValue()

Stumbled on this by accident because one particular CI configuration
warned about Settings::localValue() returning a stack reference
(may happen if the default value (which is a const ref itself) is
returned).

Not sure why I don't see this warning in my own setup, but it's
legitimate; thus fix the issue.
src/common/settings.cpp
src/common/settings.h