common: Always let QVariant::fromValue() deduce the type
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 7 Jan 2020 17:39:48 +0000 (18:39 +0100)
committerManuel Nickschas <sputnick@quassel-irc.org>
Wed, 8 Jan 2020 18:41:46 +0000 (19:41 +0100)
commit41bf70c263ee0af80ad1850fabe77ffffee188f4
tree12dc40645888d75af0fe97ee97d0c18be1ed8917
parent579e559a6322209df7cd51c34801fecff5fe734b
common: Always let QVariant::fromValue() deduce the type

In some places, we would explicitly give the type to
QVariant::fromValue(), forgoing automatic type deduction. This is
almost always redundant, and in the cases where it is not, the
input type should be explicitly cast.

Additionally, the implementation of QVariant::fromValue() subtly changed
in Qt 5.14, leading to compile errors when giving a non-decayed type
(as we did in SignalProxy::attachSignal()).
21 files changed:
src/client/coreaccountmodel.cpp
src/client/messagefilter.cpp
src/client/messagemodel.cpp
src/client/networkmodel.cpp
src/common/buffersyncer.cpp
src/common/network.cpp
src/common/serializers/serializers.cpp
src/common/signalproxy.h
src/common/types.h
src/common/util.h
src/core/core.cpp
src/qtui/chatitem.cpp
src/qtui/chatlinemodelitem.cpp
src/qtui/chatviewsettings.cpp
src/qtui/mainwin.cpp
src/qtui/settingsdlg.cpp
src/qtui/settingspages/chatmonitorsettingspage.cpp
src/qtui/settingspages/networkssettingspage.cpp
src/qtui/settingspages/shortcutsmodel.cpp
src/uisupport/networkmodelcontroller.cpp
src/uisupport/toolbaractionprovider.cpp