X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fqtui%2Fsettingspages%2Fhighlightsettingspage.cpp;fp=src%2Fqtui%2Fsettingspages%2Fhighlightsettingspage.cpp;h=4a9b11daa4f83623a52be7a89a0075aa613be0ca;hp=bc0debe61769633fce0626e151fd8a2d21da6fe1;hb=6f10483c9fe74a9464d7bf9eea53ef83c3403e23;hpb=c76b74c18766c1a6631a06bab95f2290dd860395 diff --git a/src/qtui/settingspages/highlightsettingspage.cpp b/src/qtui/settingspages/highlightsettingspage.cpp index bc0debe6..4a9b11da 100644 --- a/src/qtui/settingspages/highlightsettingspage.cpp +++ b/src/qtui/settingspages/highlightsettingspage.cpp @@ -31,9 +31,7 @@ #include "uisettings.h" HighlightSettingsPage::HighlightSettingsPage(QWidget* parent) - : SettingsPage(tr("Interface"), - // In Monolithic mode, local highlights are replaced by remote highlights - Quassel::runMode() == Quassel::Monolithic ? tr("Legacy Highlights") : tr("Local Highlights"), + : SettingsPage(tr("Interface"), tr("Legacy Highlights"), parent) { ui.setupUi(this); @@ -85,17 +83,6 @@ HighlightSettingsPage::HighlightSettingsPage(QWidget* parent) // Information icon ui.localHighlightsIcon->setPixmap(icon::get("dialog-information").pixmap(16)); - // Set up client/monolithic local highlights information - if (Quassel::runMode() == Quassel::Monolithic) { - // We're running in Monolithic mode, core/client version in total sync. Discourage the use - // of local (legacy) highlights as it's identical to setting remote highlights. - ui.localHighlightsLabel->setText(tr("Legacy Highlights are replaced by Highlights")); - } - else { - // We're running in client/split mode, allow for splitting the details. - ui.localHighlightsLabel->setText(tr("Local Highlights apply to this device only")); - } - connect(ui.add, &QAbstractButton::clicked, this, [this]() { addNewRow(); }); connect(ui.remove, &QAbstractButton::clicked, this, &HighlightSettingsPage::removeSelectedRows); // TODO: search for a better signal (one that emits everytime a selection has been changed for one item) @@ -265,34 +252,16 @@ void HighlightSettingsPage::tableChanged(QTableWidgetItem* item) void HighlightSettingsPage::on_localHighlightsDetails_clicked() { - // Show information specific to client/monolithic differences - if (Quassel::runMode() == Quassel::Monolithic) { - // We're running in Monolithic mode, core/client version in total sync. Discourage the use - // of local (legacy) highlights as it's identical to setting remote highlights. - QMessageBox::information(this, - tr("Legacy Highlights vs. Highlights"), - QString("

%1


%2


%3

") - .arg(tr("Legacy Highlights are replaced by Highlights"), - tr("These highlights will keep working for now, but you should move to " - "the improved highlight rules when you can."), - tr("Configure the new style of highlights in " - "%1.") - .arg(tr("Highlights")))); - } - else { - // We're running in client/split mode, allow for splitting the details. - QMessageBox::information(this, - tr("Local Highlights vs. Remote Highlights"), - QString("

%1


%2


%3

") - .arg(tr("Local Highlights apply to this device only"), - tr("Highlights configured on this page only apply to your current " - "device."), - tr("Configure highlights for all of your devices in " - "%1.") - .arg(tr("Remote Highlights").replace(" ", " ")))); - // Re-use translations of "Remote Highlights" as this is a word-for-word reference, forcing - // all spaces to be non-breaking - } + // Discourage the use of local (legacy) highlights. When not running in Monolithic mode, they + // need to be kept around for pre-0.13 cores. + QMessageBox::information(this, + tr("Legacy Highlights vs. Highlights"), + QString("

%1


%2


%3

") + .arg(tr("Legacy Highlights are replaced by Highlights"), + tr("These highlights will keep working for now, but you should move to " + "the improved highlight rules when you can."), + tr("Configure the new style of highlights in %1.") + .arg(tr("Highlights")))); } void HighlightSettingsPage::load()