X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcore%2Fnetworkconnection.cpp;h=56156e0defc57c8f7818d4d8aa17234d57c8c4ea;hp=15b081cc0a7a633a8f11e1307f47c7e064b00f2c;hb=0f2de52ddceb138686d2f53c694531744d70f596;hpb=c6b3980fe063e5022882a31a132dec6952f8c6a7 diff --git a/src/core/networkconnection.cpp b/src/core/networkconnection.cpp index 15b081cc..56156e0d 100644 --- a/src/core/networkconnection.cpp +++ b/src/core/networkconnection.cpp @@ -65,6 +65,10 @@ NetworkConnection::NetworkConnection(Network *network, CoreSession *session) : Q _messagesPerSecond = 1; _burstSize = 5; _tokenBucket = 5; // init with a full bucket + // TODO: + // should be 510 (2 bytes are added when writing to the socket) + // maxMsgSize is 510 minus the hostmask which will be added by the server + _maxMsgSize = 450; _tokenBucketTimer.start(_messagesPerSecond * 1000); _tokenBucketTimer.setSingleShot(false); @@ -285,6 +289,7 @@ void NetworkConnection::socketError(QAbstractSocket::SocketError) { #ifndef QT_NO_OPENSSL void NetworkConnection::sslErrors(const QList &sslErrors) { + Q_UNUSED(sslErrors) socket.ignoreSslErrors(); /* TODO errorhandling QVariantMap errmsg; @@ -390,6 +395,7 @@ void NetworkConnection::userInput(BufferInfo buf, QString msg) { void NetworkConnection::putRawLine(QByteArray s) { if(_tokenBucket > 0) { + // qDebug() << "putRawLine: " << s; writeToSocket(s); } else { _msgQueue.append(s); @@ -398,6 +404,7 @@ void NetworkConnection::putRawLine(QByteArray s) { void NetworkConnection::writeToSocket(QByteArray s) { s += "\r\n"; + // qDebug() << "writeToSocket: " << s.size(); socket.write(s); _tokenBucket--; } @@ -424,6 +431,23 @@ void NetworkConnection::putCmd(const QString &cmd, const QVariantList ¶ms, c if(!params.isEmpty()) msg += " :" + params.last().toByteArray(); + if(cmd == "PRIVMSG" && params.count() > 1) { + QByteArray msghead = "PRIVMSG " + params[0].toByteArray() + " :"; + + while (msg.size() > _maxMsgSize) { + QByteArray splitter(" .,-"); + int splitPosition = 0; + for(int i = 0; i < splitter.size(); i++) { + splitPosition = qMax(splitPosition, msg.lastIndexOf(splitter[i], _maxMsgSize)); + } + if(splitPosition < 300) { + splitPosition = _maxMsgSize; + } + putRawLine(msg.left(splitPosition)); + msg = msghead + msg.mid(splitPosition); + } + } + putRawLine(msg); } @@ -433,7 +457,7 @@ void NetworkConnection::sendAutoWho() { IrcChannel *ircchan = network()->ircChannel(chan); if(!ircchan) continue; if(_autoWhoNickLimit > 0 && ircchan->ircUsers().count() > _autoWhoNickLimit) continue; - _autoWhoInProgress.insert(chan); + _autoWhoInProgress[chan]++; putRawLine("WHO " + serverEncode(chan)); if(_autoWhoQueue.isEmpty() && _autoWhoEnabled && !_autoWhoCycleTimer.isActive()) { // Timer was stopped, means a new cycle is due immediately @@ -453,18 +477,20 @@ void NetworkConnection::startAutoWhoCycle() { } bool NetworkConnection::setAutoWhoDone(const QString &channel) { - return _autoWhoInProgress.remove(channel); + if(_autoWhoInProgress.value(channel.toLower(), 0) <= 0) return false; + _autoWhoInProgress[channel.toLower()]--; + return true; } void NetworkConnection::setChannelJoined(const QString &channel) { emit channelJoined(networkId(), channel, _channelKeys[channel.toLower()]); - _autoWhoQueue.prepend(channel); // prepend so this new chan is the first to be checked + _autoWhoQueue.prepend(channel.toLower()); // prepend so this new chan is the first to be checked } void NetworkConnection::setChannelParted(const QString &channel) { removeChannelKey(channel); - _autoWhoQueue.removeAll(channel); - _autoWhoInProgress.remove(channel); + _autoWhoQueue.removeAll(channel.toLower()); + _autoWhoInProgress.remove(channel.toLower()); emit channelParted(networkId(), channel); }