X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcore%2Fcoresessioneventprocessor.cpp;h=deca988021afd2709395cadab0c5196b7efd5ed3;hp=692257a54e37f8bd9b6e4f798940153f5ce6030a;hb=e31a348f6e0b54941a7b6ee5243da429f910f34c;hpb=04315f46a16fc3627218377071e008b6b9744992 diff --git a/src/core/coresessioneventprocessor.cpp b/src/core/coresessioneventprocessor.cpp index 692257a5..deca9880 100644 --- a/src/core/coresessioneventprocessor.cpp +++ b/src/core/coresessioneventprocessor.cpp @@ -23,6 +23,8 @@ #include "coreirclisthelper.h" #include "corenetwork.h" #include "coresession.h" +#include "coretransfer.h" +#include "coretransfermanager.h" #include "ctcpevent.h" #include "ircevent.h" #include "ircuser.h" @@ -444,7 +446,7 @@ void CoreSessionEventProcessor::processIrcEventTopic(IrcEvent *e) void CoreSessionEventProcessor::processKeyEvent(KeyEvent *e) { if (!Cipher::neededFeaturesAvailable()) { - emit newEvent(new MessageEvent(Message::Error, e->network(), tr("Unable to perform key exchange."), e->prefix(), e->target(), Message::None, e->timestamp())); + emit newEvent(new MessageEvent(Message::Error, e->network(), tr("Unable to perform key exchange, missing qca-ossl plugin."), e->prefix(), e->target(), Message::None, e->timestamp())); return; } CoreNetwork *net = qobject_cast(e->network()); @@ -794,7 +796,7 @@ void CoreSessionEventProcessor::processIrcEvent353(IrcEvent *e) QStringList nicks; QStringList modes; - foreach(QString nick, e->params()[2].split(' ')) { + foreach(QString nick, e->params()[2].split(' ', QString::SkipEmptyParts)) { QString mode; if (e->network()->prefixes().contains(nick[0])) { @@ -1014,9 +1016,64 @@ void CoreSessionEventProcessor::handleCtcpClientinfo(CtcpEvent *e) } +// http://www.irchelp.org/irchelp/rfc/ctcpspec.html +// http://en.wikipedia.org/wiki/Direct_Client-to-Client +void CoreSessionEventProcessor::handleCtcpDcc(CtcpEvent *e) +{ + // normal: SEND [] + // reverse: SEND 0 + QStringList params = e->param().split(' '); + if (params.count()) { + QString cmd = params[0].toUpper(); + if (cmd == "SEND") { + if (params.count() < 4) { + qWarning() << "Invalid DCC SEND request:" << e; // TODO emit proper error to client + return; + } + QString filename = params[1]; + QHostAddress address; + quint16 port = params[3].toUShort(); + quint64 size = 0; + QString numIp = params[2]; // this is either IPv4 as a 32 bit value, or IPv6 (which always contains a colon) + if (numIp.contains(':')) { // IPv6 + if (!address.setAddress(numIp)) { + qWarning() << "Invalid IPv6:" << numIp; + return; + } + } + else { + address.setAddress(numIp.toUInt()); + } + + if (port == 0) { // Reverse DCC is indicated by a 0 port + emit newEvent(new MessageEvent(Message::Error, e->network(), tr("Reverse DCC SEND not supported"), e->prefix(), e->target(), Message::None, e->timestamp())); + return; + } + if (port < 1024) { + qWarning() << "Privileged port requested:" << port; // FIXME ask user if this is ok + } + + + if (params.count() > 4) { // filesize is optional + size = params[4].toULong(); + } + + // TODO: check if target is the right thing to use for the partner + CoreTransfer *transfer = new CoreTransfer(Transfer::Receive, e->target(), filename, address, port, size, this); + coreSession()->signalProxy()->synchronize(transfer); + coreSession()->transferManager()->addTransfer(transfer); + } + else { + emit newEvent(new MessageEvent(Message::Error, e->network(), tr("DCC %1 not supported").arg(cmd), e->prefix(), e->target(), Message::None, e->timestamp())); + return; + } + } +} + + void CoreSessionEventProcessor::handleCtcpPing(CtcpEvent *e) { - e->setReply(e->param()); + e->setReply(e->param().isNull() ? "" : e->param()); }