X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcore%2Fabstractsqlstorage.cpp;h=a3ac2708e3b8b542807adb13f2ffc042c0d6457d;hp=d5cfe631e238b18b338d76119996cd3ecf5e16a6;hb=5c1ae5b1f0e743096538e3a2307565c05124be11;hpb=0d66a6f9ed6ea90493bca69ff781a1131d981503 diff --git a/src/core/abstractsqlstorage.cpp b/src/core/abstractsqlstorage.cpp index d5cfe631..a3ac2708 100644 --- a/src/core/abstractsqlstorage.cpp +++ b/src/core/abstractsqlstorage.cpp @@ -22,49 +22,53 @@ #include "logger.h" +#include #include #include AbstractSqlStorage::AbstractSqlStorage(QObject *parent) : Storage(parent), - _schemaVersion(0) + _schemaVersion(0), + _nextConnectionId(0) { } AbstractSqlStorage::~AbstractSqlStorage() { - QHash, QSqlQuery *>::iterator iter = _queryCache.begin(); - while(iter != _queryCache.end()) { - delete *iter; - iter = _queryCache.erase(iter); + // disconnect the connections, so their deletion is no longer interessting for us + QHash::iterator conIter; + for(conIter = _connectionPool.begin(); conIter != _connectionPool.end(); conIter++) { + disconnect(conIter.value(), 0, this, 0); } - - { - QSqlDatabase db = QSqlDatabase::database("quassel_connection"); - db.commit(); - db.close(); - } - QSqlDatabase::removeDatabase("quassel_connection"); } QSqlDatabase AbstractSqlStorage::logDb() { - QSqlDatabase db = QSqlDatabase::database("quassel_connection"); - if(db.isValid() && db.isOpen()) - return db; - - if(!openDb()) { - quWarning() << "Unable to Open Database " << displayName(); - quWarning() << " - " << db.lastError().text(); - } + if(!_connectionPool.contains(QThread::currentThread())) + addConnectionToPool(); - return QSqlDatabase::database("quassel_connection"); + qDebug() << "using logDb" << _connectionPool[QThread::currentThread()]->name() << QThread::currentThread(); + return QSqlDatabase::database(_connectionPool[QThread::currentThread()]->name()); } -bool AbstractSqlStorage::openDb() { - QSqlDatabase db = QSqlDatabase::database("quassel_connection"); - if(db.isValid() && !db.isOpen()) - return db.open(); +void AbstractSqlStorage::addConnectionToPool() { + QMutexLocker locker(&_connectionPoolMutex); + // we have to recheck if the connection pool already contains a connection for + // this thread. Since now (after the lock) we can only tell for sure + if(_connectionPool.contains(QThread::currentThread())) + return; + + QThread *currentThread = QThread::currentThread(); + + int connectionId = _nextConnectionId++; + + Connection *connection = new Connection(QLatin1String(QString("quassel_connection_%1").arg(connectionId).toLatin1())); + qDebug() << "new connection" << connection->name() << currentThread << QLatin1String(QString("quassel_connection_%1").arg(connectionId).toLatin1()); + connection->moveToThread(currentThread); + connect(this, SIGNAL(destroyed()), connection, SLOT(deleteLater())); + connect(currentThread, SIGNAL(destroyed()), connection, SLOT(deleteLater())); + connect(connection, SIGNAL(destroyed()), this, SLOT(connectionDestroyed())); + _connectionPool[currentThread] = connection; - db = QSqlDatabase::addDatabase(driverName(), "quassel_connection"); + QSqlDatabase db = QSqlDatabase::addDatabase(driverName(), connection->name()); db.setDatabaseName(databaseName()); if(!hostName().isEmpty()) @@ -75,7 +79,10 @@ bool AbstractSqlStorage::openDb() { db.setPassword(password()); } - return db.open(); + if(!db.open()) { + qWarning() << "Unable to open database" << displayName() << "for thread" << QThread::currentThread(); + qWarning() << "-" << db.lastError().text(); + } } bool AbstractSqlStorage::init(const QVariantMap &settings) { @@ -85,42 +92,32 @@ bool AbstractSqlStorage::init(const QVariantMap &settings) { return false; if(installedSchemaVersion() == -1) { - quError() << "Storage Schema is missing!"; + qCritical() << "Storage Schema is missing!"; return false; } if(installedSchemaVersion() > schemaVersion()) { - quError() << "Installed Schema is newer then any known Version."; + qCritical() << "Installed Schema is newer then any known Version."; return false; } if(installedSchemaVersion() < schemaVersion()) { - quWarning() << "Installed Schema is not up to date. Upgrading..."; + qWarning() << "Installed Schema is not up to date. Upgrading..."; if(!upgradeDb()) return false; } - quInfo() << "Storage Backend is ready. Quassel Schema Version: " << installedSchemaVersion(); + quInfo() << "Storage Backend is ready. Quassel Schema Version:" << installedSchemaVersion(); return true; } -void AbstractSqlStorage::sync() { - QHash, QSqlQuery *>::iterator iter = _queryCache.begin(); - while(iter != _queryCache.end()) { - delete *iter; - iter = _queryCache.erase(iter); - } - - logDb().commit(); -} - QString AbstractSqlStorage::queryString(const QString &queryName, int version) { if(version == 0) version = schemaVersion(); QFileInfo queryInfo(QString(":/SQL/%1/%2/%3.sql").arg(displayName()).arg(version).arg(queryName)); if(!queryInfo.exists() || !queryInfo.isFile() || !queryInfo.isReadable()) { - quError() << "Unable to read SQL-Query " << queryName << " for engine " << displayName(); + qCritical() << "Unable to read SQL-Query" << queryName << "for engine" << displayName(); return QString(); } @@ -133,24 +130,6 @@ QString AbstractSqlStorage::queryString(const QString &queryName, int version) { return query.trimmed(); } -QString AbstractSqlStorage::queryString(const QString &queryName) { - return queryString(queryName, 0); -} - -QSqlQuery *AbstractSqlStorage::cachedQuery(const QString &queryName, int version) { - QPair queryId = qMakePair(queryName, version); - if(!_queryCache.contains(queryId)) { - QSqlQuery *query = new QSqlQuery(logDb()); - query->prepare(queryString(queryName, version)); - _queryCache[queryId] = query; - } - return _queryCache[queryId]; -} - -QSqlQuery *AbstractSqlStorage::cachedQuery(const QString &queryName) { - return cachedQuery(queryName, 0); -} - QStringList AbstractSqlStorage::setupQueries() { QStringList queries; QDir dir = QDir(QString(":/SQL/%1/%2/").arg(displayName()).arg(schemaVersion())); @@ -164,14 +143,14 @@ bool AbstractSqlStorage::setup(const QVariantMap &settings) { Q_UNUSED(settings) QSqlDatabase db = logDb(); if(!db.isOpen()) { - quError() << "Unable to setup Logging Backend!"; + qCritical() << "Unable to setup Logging Backend!"; return false; } foreach(QString queryString, setupQueries()) { QSqlQuery query = db.exec(queryString); - if(!watchQuery(&query)) { - quError() << "Unable to setup Logging Backend!"; + if(!watchQuery(query)) { + qCritical() << "Unable to setup Logging Backend!"; return false; } } @@ -196,8 +175,8 @@ bool AbstractSqlStorage::upgradeDb() { for(int ver = installedSchemaVersion() + 1; ver <= schemaVersion(); ver++) { foreach(QString queryString, upgradeQueries(ver)) { QSqlQuery query = db.exec(queryString); - if(!watchQuery(&query)) { - quError() << "Unable to upgrade Logging Backend!"; + if(!watchQuery(query)) { + qCritical() << "Unable to upgrade Logging Backend!"; return false; } } @@ -229,21 +208,46 @@ int AbstractSqlStorage::schemaVersion() { return _schemaVersion; } -bool AbstractSqlStorage::watchQuery(QSqlQuery *query) { - if(query->lastError().isValid()) { - quError() << "unhandled Error in QSqlQuery!"; - quError() << " last Query:\n" << query->lastQuery(); - quError() << " executed Query:\n" << query->executedQuery(); - quError() << " bound Values: "; - QList list = query->boundValues().values(); +bool AbstractSqlStorage::watchQuery(QSqlQuery &query) { + if(query.lastError().isValid()) { + qCritical() << "unhandled Error in QSqlQuery!"; + qCritical() << " last Query:\n" << query.lastQuery(); + qCritical() << " executed Query:\n" << query.executedQuery(); + qCritical() << " bound Values:"; + QList list = query.boundValues().values(); for (int i = 0; i < list.size(); ++i) - quError() << i << ": " << list.at(i).toString().toAscii().data(); - quError() << " Error Number: " << query->lastError().number(); - quError() << " Error Message: " << query->lastError().text(); - quError() << " Driver Message: " << query->lastError().driverText(); - quError() << " DB Message: " << query->lastError().databaseText(); + qCritical() << i << ": " << list.at(i).toString().toAscii().data(); + qCritical() << " Error Number:" << query.lastError().number(); + qCritical() << " Error Message:" << query.lastError().text(); + qCritical() << " Driver Message:" << query.lastError().driverText(); + qCritical() << " DB Message:" << query.lastError().databaseText(); return false; } return true; } + +void AbstractSqlStorage::connectionDestroyed() { + QMutexLocker locker(&_connectionPoolMutex); + _connectionPool.remove(sender()->thread()); +} + +// ======================================== +// AbstractSqlStorage::Connection +// ======================================== +AbstractSqlStorage::Connection::Connection(const QString &name, QObject *parent) + : QObject(parent), + _name(name.toLatin1()) +{ +} + +AbstractSqlStorage::Connection::~Connection() { + { + QSqlDatabase db = QSqlDatabase::database(name(), false); + if(db.isOpen()) { + db.commit(); + db.close(); + } + } + QSqlDatabase::removeDatabase(name()); +}