X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcommon%2Fsignalproxy.cpp;h=2c9d268a4a13c5f19db4a437b2f9163d8c0a9b08;hp=418fdec88fb87e7f76e86dbc3906879e08ed8182;hb=93aa90cdc8ee608f4b65a32702eabb8a5590c273;hpb=9dfc807d8f60135976d4ea0ed31022304fad8f4c diff --git a/src/common/signalproxy.cpp b/src/common/signalproxy.cpp index 418fdec8..2c9d268a 100644 --- a/src/common/signalproxy.cpp +++ b/src/common/signalproxy.cpp @@ -1,5 +1,5 @@ /*************************************************************************** - * Copyright (C) 2005-2013 by the Quassel Project * + * Copyright (C) 2005-2014 by the Quassel Project * * devel@quassel-irc.org * * * * This program is free software; you can redistribute it and/or modify * @@ -34,6 +34,7 @@ #include "protocol.h" #include "syncableobject.h" #include "util.h" +#include "types.h" using namespace Protocol; @@ -147,7 +148,11 @@ int SignalProxy::SignalRelay::qt_metacall(QMetaObject::Call _c, int _id, void ** params << QVariant(argTypes[i], _a[i+1]); } - proxy()->dispatch(RpcCall(signal.signature, params)); + if (argTypes.size() >= 1 && argTypes[0] == qMetaTypeId() && proxy()->proxyMode() == SignalProxy::Server) { + Peer *peer = params[0].value(); + proxy()->dispatch(peer, RpcCall(signal.signature, params)); + } else + proxy()->dispatch(RpcCall(signal.signature, params)); } _id -= _slots.count(); } @@ -502,6 +507,16 @@ void SignalProxy::dispatch(const T &protoMessage) } +template +void SignalProxy::dispatch(Peer *peer, const T &protoMessage) +{ + if (peer && peer->isOpen()) + peer->dispatch(protoMessage); + else + QCoreApplication::postEvent(this, new ::RemovePeerEvent(peer)); +} + + void SignalProxy::handle(Peer *peer, const SyncMessage &syncMessage) { if (!_syncSlave.contains(syncMessage.className) || !_syncSlave[syncMessage.className].contains(syncMessage.objectName)) { @@ -525,7 +540,7 @@ void SignalProxy::handle(Peer *peer, const SyncMessage &syncMessage) } QVariant returnValue((QVariant::Type)eMeta->returnType(slotId)); - if (!invokeSlot(receiver, slotId, syncMessage.params, returnValue)) { + if (!invokeSlot(receiver, slotId, syncMessage.params, returnValue, peer)) { qWarning("SignalProxy::handleSync(): invokeMethod for \"%s\" failed ", eMeta->methodName(slotId).constData()); return; } @@ -586,15 +601,13 @@ void SignalProxy::handle(Peer *peer, const InitData &initData) void SignalProxy::handle(Peer *peer, const RpcCall &rpcCall) { - Q_UNUSED(peer) - QObject *receiver; int methodId; SlotHash::const_iterator slot = _attachedSlots.constFind(rpcCall.slotName); while (slot != _attachedSlots.constEnd() && slot.key() == rpcCall.slotName) { receiver = (*slot).first; methodId = (*slot).second; - if (!invokeSlot(receiver, methodId, rpcCall.params)) { + if (!invokeSlot(receiver, methodId, rpcCall.params, peer)) { ExtendedMetaObject *eMeta = extendedMetaObject(receiver); qWarning("SignalProxy::handleSignal(): invokeMethod for \"%s\" failed ", eMeta->methodName(methodId).constData()); } @@ -603,7 +616,7 @@ void SignalProxy::handle(Peer *peer, const RpcCall &rpcCall) } -bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList ¶ms, QVariant &returnValue) +bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList ¶ms, QVariant &returnValue, Peer *peer) { ExtendedMetaObject *eMeta = extendedMetaObject(receiver); const QList args = eMeta->argTypes(methodId); @@ -631,7 +644,12 @@ bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList qWarning() << "SignalProxy::invokeSlot(): incompatible param types to invoke" << eMeta->methodName(methodId); return false; } - _a[i+1] = const_cast(params[i].constData()); + // if first arg is a PeerPtr, replace it by the address of the peer originally receiving the RpcCall + if (peer && i == 0 && args[0] == qMetaTypeId()) { + QVariant v = QVariant::fromValue(peer); + _a[1] = const_cast(v.constData()); + } else + _a[i+1] = const_cast(params[i].constData()); } if (returnValue.type() != QVariant::Invalid) @@ -652,10 +670,10 @@ bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList } -bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList ¶ms) +bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList ¶ms, Peer *peer) { QVariant ret; - return invokeSlot(receiver, methodId, params, ret); + return invokeSlot(receiver, methodId, params, ret, peer); } @@ -723,7 +741,11 @@ void SignalProxy::sync_call__(const SyncableObject *obj, SignalProxy::ProxyMode params << QVariant(argTypes[i], va_arg(ap, void *)); } - dispatch(SyncMessage(eMeta->metaObject()->className(), obj->objectName(), QByteArray(funcname), params)); + if (argTypes.size() >= 1 && argTypes[0] == qMetaTypeId() && proxyMode() == SignalProxy::Server) { + Peer *peer = params[0].value(); + dispatch(peer, SyncMessage(eMeta->metaObject()->className(), obj->objectName(), QByteArray(funcname), params)); + } else + dispatch(SyncMessage(eMeta->metaObject()->className(), obj->objectName(), QByteArray(funcname), params)); }