X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcommon%2Fsignalproxy.cpp;h=1b05ab43fb786bcf4465feaa505de4c7e6e3a846;hp=5393cff399ad4caa1a239dc8b7c729a10cb4a5b1;hb=f24b79010368ac773923d29187c15c33aea69bc9;hpb=8699dd758516d0ded076811e8ea656adc95e69d0 diff --git a/src/common/signalproxy.cpp b/src/common/signalproxy.cpp index 5393cff3..1b05ab43 100644 --- a/src/common/signalproxy.cpp +++ b/src/common/signalproxy.cpp @@ -19,9 +19,11 @@ ***************************************************************************/ #include "signalproxy.h" + #include #include #include +#include #include #include #include @@ -29,12 +31,18 @@ #include #include #include -#include #include +#include +#include + +#include "syncableobject.h" #include "util.h" -class SignalRelay: public QObject { +// ================================================== +// SIGNALRELAY +// ================================================== +class SignalRelay: public QObject { /* Q_OBJECT is not necessary or even allowed, because we implement qt_metacall ourselves (and don't use any other features of the meta object system) @@ -65,7 +73,7 @@ SignalRelay::SignalRelay(SignalProxy* parent, QObject* source) caller(source), _sync(false) { - QObject::connect(source, SIGNAL(destroyed()), parent, SLOT(detachSender()), Qt::DirectConnection); + QObject::connect(source, SIGNAL(destroyed()), parent, SLOT(detachSender())); } int SignalRelay::qt_metacall(QMetaObject::Call _c, int _id, void **_a) { @@ -77,36 +85,47 @@ int SignalRelay::qt_metacall(QMetaObject::Call _c, int _id, void **_a) { const QList &argTypes = proxy->argTypes(caller, _id); QVariantList params; int n = argTypes.size(); - for(int i=0; imetaObject()->className()).arg(caller->metaObject()->method(_id).signature()); + qWarning() << " - make sure all your data types are known by the Qt MetaSystem"; + return _id; + } + params.append(QVariant(argTypes[i], _a[i+1])); + } QMultiHash::const_iterator funcIter = sigNames.constFind(_id); while(funcIter != sigNames.constEnd() && funcIter.key() == _id) { - proxy->dispatchSignal(funcIter.value(), params); + proxy->dispatchSignal(SignalProxy::RpcCall, QVariantList() << funcIter.value() << params); funcIter++; } // dispatch Sync Signal if necessary QByteArray signature(caller->metaObject()->method(_id).signature()); - if(synchronize() && proxy->syncMap(caller).contains(signature)) { - // qDebug() << "__SYNC__ >>>" - // << caller->metaObject()->className() - // << caller->objectName() - // << proxy->methodName(caller, _id) - // << params; + SyncableObject *syncObject = qobject_cast(caller); + if(synchronize() && proxy->syncMap(syncObject).contains(signature)) { + //qDebug() << "__SYNC__ >>>" + // << caller->metaObject()->className() + // << caller->objectName() + // << signature + // << params; // params.prepend(QVariant(_id)); params.prepend(signature); - params.prepend(caller->objectName()); - params.prepend(caller->metaObject()->className()); - proxy->dispatchSignal((int)SignalProxy::Sync, params); + params.prepend(syncObject->objectName()); + params.prepend(syncObject->syncMetaObject()->className()); + proxy->dispatchSignal(SignalProxy::Sync, params); } } - _id -= 1; + _id -= QObject::staticMetaObject.methodCount(); } return _id; } void SignalRelay::setSynchronize(bool sync) { - const QMetaObject *meta = caller->metaObject(); + SyncableObject *syncObject = qobject_cast(caller); + if(!syncObject) + return; + + const QMetaObject *meta = syncObject->syncMetaObject(); if(!_sync && sync) { // enable Sync for(int i = 0; i < meta->methodCount(); i++ ) { @@ -124,14 +143,18 @@ void SignalRelay::setSynchronize(bool sync) { } bool SignalRelay::isSyncMethod(int i) { - QByteArray signature = caller->metaObject()->method(i).signature(); - if(!proxy->syncMap(caller).contains(signature)) + SyncableObject *syncObject = qobject_cast(caller); + if(!syncObject) + return false; + + QByteArray signature = syncObject->syncMetaObject()->method(i).signature(); + if(!proxy->syncMap(syncObject).contains(signature)) return false; - if(proxy->proxyMode() == SignalProxy::Server && !signature.startsWith("request")) + if(proxy->proxyMode() == SignalProxy::Server && !signature.contains("Requested")) return true; - if(proxy->proxyMode() == SignalProxy::Client && signature.startsWith("request")) + if(proxy->proxyMode() == SignalProxy::Client && signature.contains("Requested")) return true; return false; @@ -160,24 +183,32 @@ void SignalRelay::attachSignal(int methodId, const QByteArray &func) { } sigNames.insert(methodId, fn); } -// ==================== -// END SIGNALRELAY -// ==================== +// ================================================== +// Peers +// ================================================== +void SignalProxy::IODevicePeer::dispatchSignal(const RequestType &requestType, const QVariantList ¶ms) { + QVariantList packedFunc; + packedFunc << (qint16)requestType + << params; + dispatchPackedFunc(QVariant(packedFunc)); +} -// ==================== +// ================================================== // SignalProxy -// ==================== +// ================================================== SignalProxy::SignalProxy(QObject* parent) : QObject(parent) { setProxyMode(Client); + init(); } SignalProxy::SignalProxy(ProxyMode mode, QObject* parent) : QObject(parent) { setProxyMode(mode); + init(); } SignalProxy::SignalProxy(ProxyMode mode, QIODevice* device, QObject* parent) @@ -185,6 +216,7 @@ SignalProxy::SignalProxy(ProxyMode mode, QIODevice* device, QObject* parent) { setProxyMode(mode); addPeer(device); + init(); } SignalProxy::~SignalProxy() { @@ -194,12 +226,22 @@ SignalProxy::~SignalProxy() { } void SignalProxy::setProxyMode(ProxyMode mode) { - foreach(QIODevice* peer, _peerByteCount.keys()) { - if(peer->isOpen()) { - qWarning() << "SignalProxy: Cannot change proxy mode while connected"; + PeerHash::iterator peer = _peers.begin(); + while(peer != _peers.end()) { + if((*peer)->type() != AbstractPeer::IODevicePeer) { + IODevicePeer *ioPeer = static_cast(*peer); + if(ioPeer->isOpen()) { + qWarning() << "SignalProxy: Cannot change proxy mode while connected"; + return; + } + } + if((*peer)->type() != AbstractPeer::SignalProxyPeer) { + qWarning() << "SignalProxy: Cannot change proxy mode while connected to another internal SignalProxy"; return; } + peer++; } + _proxyMode = mode; if(mode == Server) initServer(); @@ -207,8 +249,9 @@ void SignalProxy::setProxyMode(ProxyMode mode) { initClient(); } -SignalProxy::ProxyMode SignalProxy::proxyMode() const { - return _proxyMode; +void SignalProxy::init() { + connect(&_heartBeatTimer, SIGNAL(timeout()), this, SLOT(sendHeartBeat())); + _heartBeatTimer.start(30 * 1000); } void SignalProxy::initServer() { @@ -222,10 +265,10 @@ bool SignalProxy::addPeer(QIODevice* iodev) { if(!iodev) return false; - if(_peerByteCount.contains(iodev)) + if(_peers.contains(iodev)) return true; - if(proxyMode() == Client && !_peerByteCount.isEmpty()) { + if(proxyMode() == Client && !_peers.isEmpty()) { qWarning("SignalProxy: only one peer allowed in client mode!"); return false; } @@ -241,82 +284,101 @@ bool SignalProxy::addPeer(QIODevice* iodev) { connect(sock, SIGNAL(disconnected()), this, SLOT(removePeerBySender())); } - _peerByteCount[iodev] = 0; + // we take ownership of that device + iodev->setParent(this); + + _peers[iodev] = new IODevicePeer(iodev, iodev->property("UseCompression").toBool()); - if(_peerByteCount.count() == 1) + if(_peers.count() == 1) emit connected(); return true; } -void SignalProxy::removePeerBySender() { - // OK we're brutal here... but since it's a private slot we know what we've got connected to it... - QIODevice *ioDev = (QIODevice *)(sender()); - removePeer(ioDev); -} - -void SignalProxy::objectRenamed(QString oldname, QString newname) { - const QMetaObject *meta = sender()->metaObject(); - const QByteArray className(meta->className()); - objectRenamed(className, oldname, newname); - - if(proxyMode() == Client) - return; - - QVariantList params; - params << className << oldname << newname; - dispatchSignal("__objectRenamed__", params); -} - -void SignalProxy::objectRenamed(QByteArray classname, QString oldname, QString newname) { - QMutexLocker locker(&slaveMutex); - if(_syncSlave.contains(classname) && _syncSlave[classname].contains(oldname) && oldname != newname) - _syncSlave[classname][newname] = _syncSlave[classname].take(oldname); +void SignalProxy::removeAllPeers() { + Q_ASSERT(proxyMode() == Server || _peers.count() <= 1); + // wee need to copy that list since we modify it in the loop + QList peers = _peers.keys(); + foreach(QObject *peer, peers) { + switch(_peers[peer]->type()) { + case AbstractPeer::IODevicePeer: + removePeer(static_cast(peer)); + break; + case AbstractPeer::SignalProxyPeer: + removePeer(static_cast(peer)); + break; + default: + Q_ASSERT(false); // there shouldn't be any peers with wrong / unknown type + } + } } - void SignalProxy::removePeer(QIODevice* iodev) { - if(_peerByteCount.isEmpty()) { - qWarning() << "SignalProxy: No peers in use!"; + if(_peers.isEmpty()) { + qWarning() << "SignalProxy::removePeer(): No peers in use!"; return; } - if(proxyMode() == Server && !iodev) { - // disconnect all - QList peers = _peerByteCount.keys(); - foreach(QIODevice *peer, peers) - removePeer(peer); - } - - if(proxyMode() != Server && !iodev) - iodev = _peerByteCount.keys().first(); - Q_ASSERT(iodev); - - if(!_peerByteCount.contains(iodev)) { + if(!_peers.contains(iodev)) { qWarning() << "SignalProxy: unknown QIODevice" << iodev; return; } - - // take a last gasp - while(true) { - QVariant var; - if(readDataFromDevice(iodev, _peerByteCount[iodev], var)) - receivePeerSignal(iodev, var); - else - break; - } - _peerByteCount.remove(iodev); + + AbstractPeer *peer = _peers[iodev]; + _peers.remove(iodev); + delete peer; disconnect(iodev, 0, this, 0); emit peerRemoved(iodev); - if(_peerByteCount.isEmpty()) + if(_peers.isEmpty()) + emit disconnected(); +} + +void SignalProxy::removePeer(SignalProxy *proxy) { + if(!_peers.contains(proxy)) { + qWarning() << "SignalProxy: unknown QIODevice" << proxy; + return; + } + + _peers.remove(proxy); + + if(_peers.isEmpty()) emit disconnected(); } + +void SignalProxy::removePeerBySender() { + // OK we're brutal here... but since it's a private slot we know what we've got connected to it... + // this Slot is not triggered by destroyed, so the object is still alive and can be used! + QIODevice *ioDev = (QIODevice *)(sender()); + removePeer(ioDev); +} + +void SignalProxy::objectRenamed(const QString &newname, const QString &oldname) { + SyncableObject *syncObject = qobject_cast(sender()); + const QMetaObject *meta = syncObject->metaObject(); + const QByteArray className(meta->className()); + objectRenamed(className, newname, oldname); + + if(proxyMode() == Client) + return; + + QVariantList params; + params << "__objectRenamed__" << className << newname << oldname; + dispatchSignal(RpcCall, params); +} + +void SignalProxy::objectRenamed(const QByteArray &classname, const QString &newname, const QString &oldname) { + if(_syncSlave.contains(classname) && _syncSlave[classname].contains(oldname) && oldname != newname) { + SyncableObject *obj = _syncSlave[classname][newname] = _syncSlave[classname].take(oldname); + requestInit(obj); + } +} + void SignalProxy::setArgTypes(QObject* obj, int methodId) { - const QMetaObject *meta = obj->metaObject(); + const QMetaObject *meta = metaObject(obj); QList p = meta->method(methodId).parameterTypes(); QList argTypes; int ct = p.count(); @@ -328,35 +390,63 @@ void SignalProxy::setArgTypes(QObject* obj, int methodId) { } const QList &SignalProxy::argTypes(QObject *obj, int methodId) { - Q_ASSERT(_classInfo.contains(obj->metaObject())); - if(!_classInfo[obj->metaObject()]->argTypes.contains(methodId)) + const QMetaObject *meta = metaObject(obj); + Q_ASSERT(_classInfo.contains(meta)); + if(!_classInfo[meta]->argTypes.contains(methodId)) setArgTypes(obj, methodId); - return _classInfo[obj->metaObject()]->argTypes[methodId]; + return _classInfo[meta]->argTypes[methodId]; } -bool SignalProxy::hasUpdateSignal(QObject *obj) { - if(!_classInfo.contains(obj->metaObject())) - return false; - return _classInfo[obj->metaObject()]->hasUpdateSignal; +void SignalProxy::setReturnType(QObject *obj, int methodId) { + const QMetaObject *meta = metaObject(obj); + int returnType = QMetaType::type(meta->method(methodId).typeName()); + + Q_ASSERT(!_classInfo[meta]->returnType.contains(methodId)); + _classInfo[meta]->returnType[methodId] = returnType; +} + +const int &SignalProxy::returnType(QObject *obj, int methodId) { + const QMetaObject *meta = metaObject(obj); + Q_ASSERT(_classInfo.contains(meta)); + if(!_classInfo[meta]->returnType.contains(methodId)) + setReturnType(obj, methodId); + return _classInfo[meta]->returnType[methodId]; +} + +void SignalProxy::setMinArgCount(QObject *obj, int methodId) { + const QMetaObject *meta = metaObject(obj); + QString signature(meta->method(methodId).signature()); + int minCount = meta->method(methodId).parameterTypes().count() - signature.count("="); + Q_ASSERT(!_classInfo[meta]->minArgCount.contains(methodId)); + _classInfo[meta]->minArgCount[methodId] = minCount; +} + +const int &SignalProxy::minArgCount(QObject *obj, int methodId) { + const QMetaObject *meta = metaObject(obj); + Q_ASSERT(_classInfo.contains(meta)); + if(!_classInfo[meta]->minArgCount.contains(methodId)) + setMinArgCount(obj, methodId); + return _classInfo[meta]->minArgCount[methodId]; } void SignalProxy::setMethodName(QObject *obj, int methodId) { - const QMetaObject *meta = obj->metaObject(); + const QMetaObject *meta = metaObject(obj); QByteArray method(::methodName(meta->method(methodId))); Q_ASSERT(!_classInfo[meta]->methodNames.contains(methodId)); _classInfo[meta]->methodNames[methodId] = method; } const QByteArray &SignalProxy::methodName(QObject *obj, int methodId) { - Q_ASSERT(_classInfo.contains(obj->metaObject())); - if(!_classInfo[obj->metaObject()]->methodNames.contains(methodId)) + const QMetaObject *meta = metaObject(obj); + Q_ASSERT(_classInfo.contains(meta)); + if(!_classInfo[meta]->methodNames.contains(methodId)) setMethodName(obj, methodId); - return _classInfo[obj->metaObject()]->methodNames[methodId]; + return _classInfo[meta]->methodNames[methodId]; } -void SignalProxy::setSyncMap(QObject *obj) { - const QMetaObject *meta = obj->metaObject(); +void SignalProxy::setSyncMap(SyncableObject *obj) { + const QMetaObject *meta = obj->syncMetaObject(); QHash syncMap; QList slotIndexes; @@ -365,6 +455,15 @@ void SignalProxy::setSyncMap(QObject *obj) { slotIndexes << i; } + // we're faking sync pairs for sync replies + QByteArray slotSignature; + foreach(int slotIdx, slotIndexes) { + slotSignature = QByteArray(meta->method(slotIdx).signature()); + if(!slotSignature.startsWith("receive")) + continue; + syncMap[slotSignature] = slotIdx; + } + QMetaMethod signal, slot; int matchIdx; for(int signalIdx = 0; signalIdx < meta->methodCount(); signalIdx++) { @@ -390,24 +489,102 @@ void SignalProxy::setSyncMap(QObject *obj) { _classInfo[meta]->syncMap = syncMap; } -const QHash &SignalProxy::syncMap(QObject *obj) { - Q_ASSERT(_classInfo.contains(obj->metaObject())); - if(_classInfo[obj->metaObject()]->syncMap.isEmpty()) +const QHash &SignalProxy::syncMap(SyncableObject *obj) { + const QMetaObject *meta = obj->syncMetaObject(); + Q_ASSERT(_classInfo.contains(meta)); + if(_classInfo[meta]->syncMap.isEmpty()) setSyncMap(obj); - return _classInfo[obj->metaObject()]->syncMap; + return _classInfo[meta]->syncMap; +} + +void SignalProxy::setReceiveMap(SyncableObject *obj) { + const QMetaObject *meta = obj->syncMetaObject(); + Q_ASSERT(_classInfo.contains(meta)); + + QHash receiveMap; + + QMetaMethod requestSlot; + QByteArray returnTypeName; + QByteArray signature; + QByteArray methodName; + QByteArray params; + int paramsPos; + int receiverId; + const int methodCount = meta->methodCount(); + for(int i = 0; i < methodCount; i++) { + requestSlot = meta->method(i); + if(requestSlot.methodType() != QMetaMethod::Slot) + continue; + + returnTypeName = requestSlot.typeName(); + if(QMetaType::Void == (QMetaType::Type)returnType(obj, i)) + continue; + + signature = QByteArray(requestSlot.signature()); + if(!signature.startsWith("request")) + continue; + + paramsPos = signature.indexOf('('); + if(paramsPos == -1) + continue; + + methodName = signature.left(paramsPos); + params = signature.mid(paramsPos); + + methodName = methodName.replace("request", "receive"); + params = params.left(params.count() - 1) + ", " + returnTypeName + ")"; + + signature = QMetaObject::normalizedSignature(methodName + params); + receiverId = meta->indexOfSlot(signature); + + if(receiverId == -1) { + signature = QMetaObject::normalizedSignature(methodName + "(" + returnTypeName + ")"); + receiverId = meta->indexOfSlot(signature); + } + + if(receiverId != -1) + receiveMap[i] = receiverId; + } + _classInfo[meta]->receiveMap = receiveMap; +} + +const QHash &SignalProxy::receiveMap(SyncableObject *obj) { + const QMetaObject *meta = obj->syncMetaObject(); + Q_ASSERT(_classInfo.contains(meta)); + if(_classInfo[meta]->receiveMap.isEmpty()) + setReceiveMap(obj); + return _classInfo[meta]->receiveMap; +} + +void SignalProxy::setUpdatedRemotelyId(SyncableObject *obj) { + const QMetaObject *meta = obj->syncMetaObject(); + Q_ASSERT(_classInfo.contains(meta)); + _classInfo[meta]->updatedRemotelyId = meta->indexOfSignal("updatedRemotely()"); +} + +int SignalProxy::updatedRemotelyId(SyncableObject *obj) { + Q_ASSERT(_classInfo.contains(obj->syncMetaObject())); + return _classInfo[obj->syncMetaObject()]->updatedRemotelyId; +} + +const QMetaObject *SignalProxy::metaObject(QObject *obj) { + if(SyncableObject *syncObject = qobject_cast(obj)) + return syncObject->syncMetaObject(); + else + return obj->metaObject(); } void SignalProxy::createClassInfo(QObject *obj) { - if(_classInfo.contains(obj->metaObject())) + const QMetaObject *meta = metaObject(obj); + if(_classInfo.contains(meta)) return; ClassInfo *classInfo = new ClassInfo(); - classInfo->hasUpdateSignal = (obj->metaObject()->indexOfSignal(QMetaObject::normalizedSignature("updatedRemotely()")) != -1); - _classInfo[obj->metaObject()] = classInfo; + _classInfo[meta] = classInfo; } bool SignalProxy::attachSignal(QObject* sender, const char* signal, const QByteArray& sigName) { - const QMetaObject* meta = sender->metaObject(); + const QMetaObject* meta = metaObject(sender); QByteArray sig(meta->normalizedSignature(signal).mid(1)); int methodId = meta->indexOfMethod(sig.constData()); if(methodId == -1 || meta->method(methodId).methodType() != QMetaMethod::Signal) { @@ -443,13 +620,14 @@ bool SignalProxy::attachSlot(const QByteArray& sigName, QObject* recv, const cha _attachedSlots.insert(funcName, qMakePair(recv, methodId)); QObject::disconnect(recv, SIGNAL(destroyed()), this, SLOT(detachSender())); - QObject::connect(recv, SIGNAL(destroyed()), this, SLOT(detachSender()), Qt::DirectConnection); + QObject::connect(recv, SIGNAL(destroyed()), this, SLOT(detachSender())); return true; } -void SignalProxy::synchronize(QObject *obj) { +void SignalProxy::synchronize(SyncableObject *obj) { createClassInfo(obj); - + setUpdatedRemotelyId(obj); + // attaching all the Signals SignalRelay* relay; if(_relayHash.contains(obj)) @@ -460,81 +638,48 @@ void SignalProxy::synchronize(QObject *obj) { relay->setSynchronize(true); // attaching as slave to receive sync Calls - QByteArray className(obj->metaObject()->className()); + QByteArray className(obj->syncMetaObject()->className()); _syncSlave[className][obj->objectName()] = obj; if(proxyMode() == Server) { - if(obj->metaObject()->indexOfSignal(QMetaObject::normalizedSignature("renameObject(QString, QString)")) != -1) - connect(obj, SIGNAL(renameObject(QString, QString)), this, SLOT(objectRenamed(QString, QString)), Qt::DirectConnection); - - setInitialized(obj); + connect(obj, SIGNAL(objectRenamed(QString, QString)), this, SLOT(objectRenamed(QString, QString))); + obj->setInitialized(); + emit objectInitialized(obj); } else { - requestInit(obj); + if(obj->isInitialized()) + emit objectInitialized(obj); + else + requestInit(obj); } } -void SignalProxy::setInitialized(QObject *obj) { - QMetaObject::invokeMethod(obj, "setInitialized"); -} - -bool SignalProxy::initialized(QObject *obj) { - bool init; - if(!QMetaObject::invokeMethod(obj, "initialized", Q_RETURN_ARG(bool, init))) - init = false; - return init; -} - -void SignalProxy::requestInit(QObject *obj) { - if(proxyMode() == Server || initialized(obj)) +void SignalProxy::requestInit(SyncableObject *obj) { + if(proxyMode() == Server || obj->isInitialized()) return; QVariantList params; - params << obj->metaObject()->className() + params << obj->syncMetaObject()->className() << obj->objectName(); - dispatchSignal((int)InitRequest, params); + dispatchSignal(InitRequest, params); } void SignalProxy::detachSender() { - // this is a private slot. the reason for that is, that we enfoce Qt::DirectConnection. - // the result is, that we can be sure, that a registered receiver is removed immediately when it's destroyed. - // since we're guarding the the internal datastructures with mutexes this means, - // that the object destruction is deffered until we're finished delivering our sync/init/whatever request. - // all in all: thread safety! *sigh* detachObject(sender()); } -// detachObject/Signals/Slots() can be called as a result of an incoming call -// this might destroy our the iterator used for delivery -// thus we wrap the actual disconnection by using QueuedConnections void SignalProxy::detachObject(QObject* obj) { - QMutexLocker locker(&slaveMutex); - _detachSignals(obj); - _detachSlots(obj); - _stopSync(obj); + detachSignals(obj); + detachSlots(obj); + stopSync(static_cast(obj)); } void SignalProxy::detachSignals(QObject* sender) { - QMutexLocker locker(&slaveMutex); - _detachSignals(sender); -} - -void SignalProxy::detachSlots(QObject* receiver) { - QMutexLocker locker(&slaveMutex); - _detachSlots(receiver); -} - -void SignalProxy::stopSync(QObject* obj) { - QMutexLocker locker(&slaveMutex); - _stopSync(obj); -} - -void SignalProxy::_detachSignals(QObject* sender) { if(!_relayHash.contains(sender)) return; _relayHash.take(sender)->deleteLater(); } -void SignalProxy::_detachSlots(QObject* receiver) { +void SignalProxy::detachSlots(QObject* receiver) { SlotHash::iterator slotIter = _attachedSlots.begin(); while(slotIter != _attachedSlots.end()) { if(slotIter.value().first == receiver) { @@ -544,7 +689,7 @@ void SignalProxy::_detachSlots(QObject* receiver) { } } -void SignalProxy::_stopSync(QObject* obj) { +void SignalProxy::stopSync(SyncableObject* obj) { if(_relayHash.contains(obj)) _relayHash[obj]->setSynchronize(false); @@ -552,7 +697,7 @@ void SignalProxy::_stopSync(QObject* obj) { // gladly the objectName() is still valid. So we have only to iterate over the classes not each instance! *sigh* QHash::iterator classIter = _syncSlave.begin(); while(classIter != _syncSlave.end()) { - if(classIter->contains(obj->objectName())) { + if(classIter->contains(obj->objectName()) && classIter.value()[obj->objectName()] == obj) { classIter->remove(obj->objectName()); break; } @@ -560,48 +705,75 @@ void SignalProxy::_stopSync(QObject* obj) { } } -void SignalProxy::dispatchSignal(QIODevice *receiver, const QVariant &identifier, const QVariantList ¶ms) { - QVariantList packedFunc; - packedFunc << identifier; - packedFunc << params; - writeDataToDevice(receiver, QVariant(packedFunc)); -} - -void SignalProxy::dispatchSignal(const QVariant &identifier, const QVariantList ¶ms) { - // yes I know we have a little code duplication here... it's for the sake of performance - QVariantList packedFunc; - packedFunc << identifier; - packedFunc << params; - foreach(QIODevice* dev, _peerByteCount.keys()) - writeDataToDevice(dev, QVariant(packedFunc)); +void SignalProxy::dispatchSignal(const RequestType &requestType, const QVariantList ¶ms) { + QVariant packedFunc(QVariantList() << (qint16)requestType << params); + PeerHash::iterator peer = _peers.begin(); + while(peer != _peers.end()) { + switch((*peer)->type()) { + case AbstractPeer::IODevicePeer: + { + IODevicePeer *ioPeer = static_cast(*peer); + ioPeer->dispatchPackedFunc(packedFunc); + } + break; + case AbstractPeer::SignalProxyPeer: + (*peer)->dispatchSignal(requestType, params); + break; + default: + Q_ASSERT(false); // there shouldn't be any peers with wrong / unknown type + } + peer++; + } } -void SignalProxy::receivePeerSignal(QIODevice *sender, const QVariant &packedFunc) { +void SignalProxy::receivePackedFunc(AbstractPeer *sender, const QVariant &packedFunc) { QVariantList params(packedFunc.toList()); - QVariant call = params.takeFirst(); - if(call.type() != QVariant::Int) - return handleSignal(call.toByteArray(), params); + if(params.isEmpty()) { + qWarning() << "SignalProxy::receivePeerSignal(): received incompatible Data:" << packedFunc; + return; + } - // well yes we are locking code here and not only data. - // otherwise each handler would have to lock the data anyway. this leaves us on the safe side - // unable to forget a lock - QMutexLocker locker(&slaveMutex); + RequestType requestType = (RequestType)params.takeFirst().value(); + receivePeerSignal(sender, requestType, params); +} + +void SignalProxy::receivePeerSignal(AbstractPeer *sender, const RequestType &requestType, const QVariantList ¶ms) { + switch(requestType) { + case RpcCall: + if(params.empty()) + qWarning() << "SignalProxy::receivePeerSignal(): received empty RPC-Call"; + else + handleSignal(params); + //handleSignal(params.takeFirst().toByteArray(), params); + break; - switch(call.toInt()) { case Sync: - return handleSync(params); + handleSync(sender, params); + break; + case InitRequest: - return handleInitRequest(sender, params); + handleInitRequest(sender, params); + break; + case InitData: - return handleInitData(sender, params); + handleInitData(sender, params); + break; + + case HeartBeat: + receiveHeartBeat(sender, params); + break; + + case HeartBeatReply: + receiveHeartBeatReply(sender, params); + break; + default: - qWarning() << "received undefined CallType" << call.toInt(); - return; + qWarning() << "SignalProxy::receivePeerSignal(): received undefined CallType" << requestType << params; } } -void SignalProxy::handleSync(QVariantList params) { +void SignalProxy::handleSync(AbstractPeer *sender, QVariantList params) { if(params.count() < 3) { qWarning() << "received invalid Sync call" << params; return; @@ -612,28 +784,43 @@ void SignalProxy::handleSync(QVariantList params) { QByteArray signal = params.takeFirst().toByteArray(); if(!_syncSlave.contains(className) || !_syncSlave[className].contains(objectName)) { - qWarning() << QString("no registered receiver for sync call: %s::%s (objectName=\"%s\"). Params are:").arg(QString(className)).arg(QString(signal)).arg(objectName) + qWarning() << QString("no registered receiver for sync call: %1::%2 (objectName=\"%3\"). Params are:").arg(QString(className)).arg(QString(signal)).arg(objectName) << params; return; } - QObject *receiver = _syncSlave[className][objectName]; + SyncableObject *receiver = _syncSlave[className][objectName]; if(!syncMap(receiver).contains(signal)) { - qWarning() << QString("no matching slot for sync call: %s::%s (objectName=\"%s\"). Params are:").arg(QString(className)).arg(QString(signal)).arg(objectName) + qWarning() << QString("no matching slot for sync call: %1::%2 (objectName=\"%3\"). Params are:").arg(QString(className)).arg(QString(signal)).arg(objectName) << params; return; } int slotId = syncMap(receiver)[signal]; - if(!invokeSlot(receiver, slotId, params)) { + + QVariant returnValue((QVariant::Type)returnType(receiver, slotId)); + if(!invokeSlot(receiver, slotId, params, returnValue)) { qWarning("SignalProxy::handleSync(): invokeMethod for \"%s\" failed ", methodName(receiver, slotId).constData()); return; } - if(hasUpdateSignal(receiver)) - QMetaObject::invokeMethod(receiver, "updatedRemotely"); + + if(returnValue.type() != QVariant::Invalid && receiveMap(receiver).contains(slotId)) { + int receiverId = receiveMap(receiver)[slotId]; + QVariantList returnParams; + returnParams << className + << objectName + << QByteArray(receiver->metaObject()->method(receiverId).signature()); + if(argTypes(receiver, receiverId).count() > 1) + returnParams << params; + returnParams << returnValue; + sender->dispatchSignal(Sync, returnParams); + } + + // send emit update signal + invokeSlot(receiver, updatedRemotelyId(receiver)); } -void SignalProxy::handleInitRequest(QIODevice *sender, const QVariantList ¶ms) { +void SignalProxy::handleInitRequest(AbstractPeer *sender, const QVariantList ¶ms) { if(params.count() != 2) { qWarning() << "SignalProxy::handleInitRequest() received initRequest with invalid param Count:" << params; @@ -655,20 +842,20 @@ void SignalProxy::handleInitRequest(QIODevice *sender, const QVariantList ¶m return; } - QObject *obj = _syncSlave[className][objectName]; + SyncableObject *obj = _syncSlave[className][objectName]; QVariantList params_; - params_ << obj->metaObject()->className() - << obj->objectName() + params_ << className + << objectName << initData(obj); - dispatchSignal(sender, (int)InitData, params_); + sender->dispatchSignal(InitData, params_); } -void SignalProxy::handleInitData(QIODevice *sender, const QVariantList ¶ms) { +void SignalProxy::handleInitData(AbstractPeer *sender, const QVariantList ¶ms) { Q_UNUSED(sender) if(params.count() != 3) { - qWarning() << "SignalProxy::handleInitRequest() received initRequest with invalid param Count:" + qWarning() << "SignalProxy::handleInitData() received initData with invalid param Count:" << params; return; } @@ -678,22 +865,26 @@ void SignalProxy::handleInitData(QIODevice *sender, const QVariantList ¶ms) QVariantMap propertyMap(params[2].toMap()); if(!_syncSlave.contains(className)) { - qWarning() << "SignalProxy::handleInitRequest() received initRequest for unregistered Class:" + qWarning() << "SignalProxy::handleInitData() received initData for unregistered Class:" << className; return; } if(!_syncSlave[className].contains(objectName)) { - qWarning() << "SignalProxy::handleInitRequest() received initRequest for unregistered Object:" + qWarning() << "SignalProxy::handleInitData() received initData for unregistered Object:" << className << objectName; return; } - QObject *obj = _syncSlave[className][objectName]; + SyncableObject *obj = _syncSlave[className][objectName]; setInitData(obj, propertyMap); } -void SignalProxy::handleSignal(const QByteArray &funcName, const QVariantList ¶ms) { +//void SignalProxy::handleSignal(const QByteArray &funcName, const QVariantList ¶ms) { +void SignalProxy::handleSignal(const QVariantList &data) { + QVariantList params = data; + QByteArray funcName = params.takeFirst().toByteArray(); + QObject* receiver; int methodId; SlotHash::const_iterator slot = _attachedSlots.constFind(funcName); @@ -706,38 +897,100 @@ void SignalProxy::handleSignal(const QByteArray &funcName, const QVariantList &p } } +bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList ¶ms, QVariant &returnValue) { + const QList args = argTypes(receiver, methodId); + const int numArgs = params.count() < args.count() + ? params.count() + : args.count(); + + if(minArgCount(receiver, methodId) > params.count()) { + qWarning() << "SignalProxy::invokeSlot(): not enough params to invoke" << methodName(receiver, methodId); + return false; + } + + void *_a[] = {0, // return type... + 0, 0, 0, 0 , 0, // and 10 args - that's the max size qt can handle with signals and slots + 0, 0, 0, 0 , 0}; + + // check for argument compatibility and build params array + for(int i = 0; i < numArgs; i++) { + if(!params[i].isValid()) { + qWarning() << "SignalProxy::invokeSlot(): received invalid data for argument number" << i << "of method" << QString("%1::%2()").arg(receiver->metaObject()->className()).arg(receiver->metaObject()->method(methodId).signature()); + qWarning() << " - make sure all your data types are known by the Qt MetaSystem"; + return false; + } + if(args[i] != QMetaType::type(params[i].typeName())) { + qWarning() << "SignalProxy::invokeSlot(): incompatible param types to invoke" << methodName(receiver, methodId); + return false; + } + _a[i+1] = const_cast(params[i].constData()); + } + + if(returnValue.type() != QVariant::Invalid) + _a[0] = const_cast(returnValue.constData()); + + Qt::ConnectionType type = QThread::currentThread() == receiver->thread() + ? Qt::DirectConnection + : Qt::QueuedConnection; + + if (type == Qt::DirectConnection) { + return receiver->qt_metacall(QMetaObject::InvokeMetaMethod, methodId, _a) < 0; + } else { + qWarning() << "Queued Connections are not implemented yet"; + // note to self: qmetaobject.cpp:990 ff + return false; + } + +} + bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList ¶ms) { - int numParams = argTypes(receiver, methodId).count(); - QGenericArgument args[9]; - for(int i = 0; i < numParams; i++) - args[i] = QGenericArgument(params[i].typeName(), params[i].constData()); - return QMetaObject::invokeMethod(receiver, methodName(receiver, methodId), args[0], args[1], args[2], args[3], args[4], args[5], args[6], args[7], args[8]); + QVariant ret; + return invokeSlot(receiver, methodId, params, ret); } void SignalProxy::dataAvailable() { // yet again. it's a private slot. no need for checks. QIODevice* ioDev = qobject_cast(sender()); + Q_ASSERT(_peers.contains(ioDev) && _peers[ioDev]->type() == AbstractPeer::IODevicePeer); + IODevicePeer *peer = static_cast(_peers[ioDev]); QVariant var; - while(readDataFromDevice(ioDev, _peerByteCount[ioDev], var)) - receivePeerSignal(ioDev, var); + while(peer->readData(var)) + receivePackedFunc(peer, var); } -void SignalProxy::writeDataToDevice(QIODevice *dev, const QVariant &item) { +void SignalProxy::writeDataToDevice(QIODevice *dev, const QVariant &item, bool compressed) { QAbstractSocket* sock = qobject_cast(dev); if(!dev->isOpen() || (sock && sock->state()!=QAbstractSocket::ConnectedState)) { - qWarning("SignalProxy: Can't call on a closed device"); + qWarning("SignalProxy: Can't call write on a closed device"); return; } + QByteArray block; QDataStream out(&block, QIODevice::WriteOnly); out.setVersion(QDataStream::Qt_4_2); - out << (quint32)0 << item; + out << (quint32)0; + + if(compressed) { + QByteArray rawItem; + QDataStream itemStream(&rawItem, QIODevice::WriteOnly); + + itemStream.setVersion(QDataStream::Qt_4_2); + itemStream << item; + + rawItem = qCompress(rawItem); + + out << rawItem; + } else { + out << item; + } + out.device()->seek(0); out << (quint32)(block.size() - sizeof(quint32)); + dev->write(block); } -bool SignalProxy::readDataFromDevice(QIODevice *dev, quint32 &blockSize, QVariant &item) { +bool SignalProxy::readDataFromDevice(QIODevice *dev, quint32 &blockSize, QVariant &item, bool compressed) { QDataStream in(dev); in.setVersion(QDataStream::Qt_4_2); @@ -746,10 +999,40 @@ bool SignalProxy::readDataFromDevice(QIODevice *dev, quint32 &blockSize, QVarian in >> blockSize; } + if(blockSize > 1 << 22) { + qWarning() << qPrintable(tr("Client tried to send package larger than max package size!")); + QAbstractSocket *sock = qobject_cast(dev); + qWarning() << qPrintable(tr("Disconnecting")) << (sock ? qPrintable(sock->peerAddress().toString()) : qPrintable(tr("local client"))); + dev->close(); + return false; + } + if(dev->bytesAvailable() < blockSize) return false; - in >> item; + + if(compressed) { + QByteArray rawItem; + in >> rawItem; + // debug check + int nbytes = rawItem.size(); + if (nbytes <= 4) { + const char *data = rawItem.constData(); + if (nbytes < 4 || (data[0]!=0 || data[1]!=0 || data[2]!=0 || data[3]!=0)) + qWarning() << "receieved corrupted compressed data:" + << blockSize << rawItem << rawItem.size() << dev; + } + // end + rawItem = qUncompress(rawItem); + + QDataStream itemStream(&rawItem, QIODevice::ReadOnly); + itemStream.setVersion(QDataStream::Qt_4_2); + itemStream >> item; + } else { + in >> item; + } + blockSize = 0; + return true; } @@ -775,12 +1058,19 @@ QString SignalProxy::methodBaseName(const QMetaMethod &method) { QString methodname = QString(method.signature()).section("(", 0, 0); // determine where we have to chop: + int upperCharPos; if(method.methodType() == QMetaMethod::Slot) { // we take evertyhing from the first uppercase char if it's slot - methodname = methodname.mid(methodname.indexOf(QRegExp("[A-Z]"))); + upperCharPos = methodname.indexOf(QRegExp("[A-Z]")); + if(upperCharPos == -1) + return QString(); + methodname = methodname.mid(upperCharPos); } else { // and if it's a signal we discard everything from the last uppercase char - methodname = methodname.left(methodname.lastIndexOf(QRegExp("[A-Z]"))); + upperCharPos = methodname.lastIndexOf(QRegExp("[A-Z]")); + if(upperCharPos == -1) + return QString(); + methodname = methodname.left(upperCharPos); } methodname[0] = methodname[0].toUpper(); @@ -788,64 +1078,73 @@ QString SignalProxy::methodBaseName(const QMetaMethod &method) { return methodname; } -QVariantMap SignalProxy::initData(QObject *obj) const { - QVariantMap properties; +QVariantMap SignalProxy::initData(SyncableObject *obj) const { + return obj->toVariantMap(); +} - const QMetaObject* meta = obj->metaObject(); +void SignalProxy::setInitData(SyncableObject *obj, const QVariantMap &properties) { + if(obj->isInitialized()) + return; + obj->fromVariantMap(properties); + obj->setInitialized(); + emit objectInitialized(obj); + invokeSlot(obj, updatedRemotelyId(obj)); +} - // we collect data from properties - for(int i = 0; i < meta->propertyCount(); i++) { - QMetaProperty prop = meta->property(i); - properties[QString(prop.name())] = prop.read(obj); +void SignalProxy::sendHeartBeat() { + dispatchSignal(SignalProxy::HeartBeat, QVariantList() << QTime::currentTime()); + PeerHash::iterator peer = _peers.begin(); + while(peer != _peers.end()) { + if((*peer)->type() == AbstractPeer::IODevicePeer) { + IODevicePeer *ioPeer = static_cast(*peer); + if(ioPeer->sentHeartBeats > 0) { + updateLag(ioPeer, ioPeer->sentHeartBeats * _heartBeatTimer.interval()); + } + if(ioPeer->sentHeartBeats > 1) { + //FIXME: proper disconnect. +// QAbstractSocket *socket = qobject_cast(peerIter.key()); +// qWarning() << "SignalProxy: Disconnecting peer:" +// << (socket ? qPrintable(socket->peerAddress().toString()) : "local client") +// << "(didn't receive a heartbeat for over" << peerIter->sentHeartBeats * _heartBeatTimer.interval() / 1000 << "seconds)"; +// peerIter.key()->close(); + } else { + ioPeer->sentHeartBeats++; + } + } + peer++; } +} - // ...as well as methods, which have names starting with "init" - for(int i = 0; i < meta->methodCount(); i++) { - QMetaMethod method = meta->method(i); - QString methodname(::methodName(method)); - if(!methodname.startsWith("init") || methodname.startsWith("initSet")) - continue; - - QVariant value = QVariant(QVariant::nameToType(method.typeName())); - QGenericReturnArgument genericvalue = QGenericReturnArgument(method.typeName(), &value); - QMetaObject::invokeMethod(obj, methodname.toAscii(), genericvalue); - - properties[methodBaseName(method)] = value; - // qDebug() << ">>> SYNC:" << methodBaseName(method) << value; - } - - // properties["Payload"] = QByteArray(10000000, 'a'); // for testing purposes - return properties; +void SignalProxy::receiveHeartBeat(AbstractPeer *peer, const QVariantList ¶ms) { + peer->dispatchSignal(SignalProxy::HeartBeatReply, params); } -void SignalProxy::setInitData(QObject *obj, const QVariantMap &properties) { - if(initialized(obj)) +void SignalProxy::receiveHeartBeatReply(AbstractPeer *peer, const QVariantList ¶ms) { + if(peer->type() != AbstractPeer::IODevicePeer) { + qWarning() << "SignalProxy::receiveHeartBeatReply: received heart beat from a non IODevicePeer!"; return; + } - const QMetaObject *meta = obj->metaObject(); - - QVariantMap::const_iterator iterator = properties.constBegin(); - while(iterator != properties.constEnd()) { - QString name = iterator.key(); - int propertyIndex = meta->indexOfProperty(name.toAscii()); + IODevicePeer *ioPeer = static_cast(peer); + ioPeer->sentHeartBeats = 0; - if(propertyIndex == -1 || !meta->property(propertyIndex).isWritable()) - setInitValue(obj, name, iterator.value()); - else - obj->setProperty(name.toAscii(), iterator.value()); - // qDebug() << "<<< SYNC:" << name << iterator.value(); - iterator++; + if(params.isEmpty()) { + qWarning() << "SignalProxy: received heart beat reply with less params then sent from:" << ioPeer->device(); + return; } - setInitialized(obj); + + QTime sendTime = params[0].value(); + updateLag(ioPeer, sendTime.msecsTo(QTime::currentTime()) / 2); } -bool SignalProxy::setInitValue(QObject *obj, const QString &property, const QVariant &value) { - QString handlername = QString("initSet") + property; - handlername[7] = handlername[7].toUpper(); - QGenericArgument param(value.typeName(), value.constData()); - return QMetaObject::invokeMethod(obj, handlername.toAscii(), param); +void SignalProxy::updateLag(IODevicePeer *peer, int lag) { + peer->lag = lag; + if(proxyMode() == Client) { + emit lagUpdated(lag); + } } + void SignalProxy::dumpProxyStats() { QString mode; if(proxyMode() == Server) @@ -870,7 +1169,7 @@ void SignalProxy::dumpProxyStats() { qDebug() << "number of Classes cached:" << _classInfo.count(); } -void SignalProxy::dumpSyncMap(QObject *object) { +void SignalProxy::dumpSyncMap(SyncableObject *object) { const QMetaObject *meta = object->metaObject(); qDebug() << "SignalProxy: SyncMap for Class" << meta->className();