X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcommon%2Fsettings.cpp;h=2731da26a7f5087e9ac6143f0967ffea6b4a5367;hp=f832f776a9d26d859b9ebf8ed295c98ffaa1086e;hb=adda0fa0aeef6087045256b250ff30c88ee7dc00;hpb=7fd13d1b1d6ec454ad622bdb0eefa72d6488c5fa diff --git a/src/common/settings.cpp b/src/common/settings.cpp index f832f776..2731da26 100644 --- a/src/common/settings.cpp +++ b/src/common/settings.cpp @@ -24,8 +24,8 @@ const int VERSION = 1; -QHash > Settings::settingsCache; -QHash > Settings::settingsChangeNotifier; +QHash Settings::settingsCache; +QHash Settings::settingsChangeNotifier; #ifdef Q_WS_MAC # define create_qsettings QSettings s(QCoreApplication::organizationDomain(), appName) @@ -59,7 +59,7 @@ QHash > Settings::settingsChan // } void Settings::notify(const QString &key, QObject *receiver, const char *slot) { - QObject::connect(notifier(group, key), SIGNAL(valueChanged(const QVariant &)), + QObject::connect(notifier(normalizedKey(group, key)), SIGNAL(valueChanged(const QVariant &)), receiver, slot); } @@ -112,24 +112,22 @@ QStringList Settings::localChildGroups(const QString &rootkey) { } void Settings::setLocalValue(const QString &key, const QVariant &data) { + QString normKey = normalizedKey(group, key); create_qsettings; - s.beginGroup(group); - s.setValue(key, data); - s.endGroup(); - setCacheValue(group, key, data); - if(hasNotifier(group, key)) { - emit notifier(group, key)->valueChanged(data); + s.setValue(normKey, data); + setCacheValue(normKey, data); + if(hasNotifier(normKey)) { + emit notifier(normKey)->valueChanged(data); } } const QVariant &Settings::localValue(const QString &key, const QVariant &def) { - if(!isCached(group, key)) { + QString normKey = normalizedKey(group, key); + if(!isCached(normKey)) { create_qsettings; - s.beginGroup(group); - setCacheValue(group, key, s.value(key, def)); - s.endGroup(); + setCacheValue(normKey, s.value(normKey, def)); } - return cacheValue(group, key); + return cacheValue(normKey); } void Settings::removeLocalKey(const QString &key) { @@ -137,6 +135,7 @@ void Settings::removeLocalKey(const QString &key) { s.beginGroup(group); s.remove(key); s.endGroup(); - if(isCached(group, key)) - settingsCache[group].remove(key); + QString normKey = normalizedKey(group, key); + if(isCached(normKey)) + settingsCache.remove(normKey); }