X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcommon%2Fnetwork.cpp;h=3b1fe1d8bf15c70f86cef5e4d8aaefadddcd605f;hp=cb4adb5c82cc794bdbe89609b9026aba24acec83;hb=2e8eab59dd72e37a740d16d9484502d077aef64d;hpb=0b983b0d9364e62db0b5e6cf25988ef8041a0c5d diff --git a/src/common/network.cpp b/src/common/network.cpp index cb4adb5c..3b1fe1d8 100644 --- a/src/common/network.cpp +++ b/src/common/network.cpp @@ -243,6 +243,14 @@ QString Network::support(const QString ¶m) const bool Network::saslMaybeSupports(const QString &saslMechanism) const { + if (!capAvailable(IrcCap::SASL)) { + // If SASL's not advertised at all, it's likely the mechanism isn't supported, as per specs. + // Unfortunately, we don't know for sure, but Quassel won't request SASL without it being + // advertised, anyways. + // This may also occur if the network's disconnected or negotiation hasn't yet happened. + return false; + } + // Get the SASL capability value QString saslCapValue = capValue(IrcCap::SASL); // SASL mechanisms are only specified in capability values as part of SASL 3.2. In SASL 3.1, @@ -723,8 +731,8 @@ void Network::setMessageRateBurstSize(quint32 burstSize) if (burstSize < 1) { // Can't go slower than one message at a time. Also blocks old clients from trying to set // this to 0. - qWarning() << "Received invalid setMessageRateBurstSize data - message burst size must be " - "non-zero positive, given" << burstSize; + qDebug() << "Received invalid setMessageRateBurstSize data - message burst size must be " + "non-zero positive, given" << burstSize; return; } if (_messageRateBurstSize != burstSize) { @@ -741,8 +749,8 @@ void Network::setMessageRateDelay(quint32 messageDelay) if (messageDelay == 0) { // Nonsensical to have no delay - just check the Unlimited box instead. Also blocks old // clients from trying to set this to 0. - qWarning() << "Received invalid setMessageRateDelay data - message delay must be non-zero " - "positive, given" << messageDelay; + qDebug() << "Received invalid setMessageRateDelay data - message delay must be non-zero " + "positive, given" << messageDelay; return; } if (_messageRateDelay != messageDelay) {