X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcommon%2Fircchannel.cpp;h=de7b830977dad9dff256946a81c592704d6fca31;hp=7a1230c7e51e867d2f54c25cf64df1892d655272;hb=294e7ee7e918cf4d85ddf4eca1f5bcedabf561eb;hpb=83662b607de9eb742fe9de4dd9445914a6bd9456 diff --git a/src/common/ircchannel.cpp b/src/common/ircchannel.cpp index 7a1230c7..de7b8309 100644 --- a/src/common/ircchannel.cpp +++ b/src/common/ircchannel.cpp @@ -73,7 +73,7 @@ bool IrcChannel::isValidChannelUserMode(const QString &mode) const { bool isvalid = true; if (mode.size() > 1) { - qWarning() << "Channel" << name() << "received Channel User Mode which is longer then 1 Char:" << mode; + qWarning() << "Channel" << name() << "received Channel User Mode which is longer than 1 Char:" << mode; isvalid = false; } return isvalid; @@ -178,17 +178,25 @@ void IrcChannel::joinIrcUsers(const QList &users, const QStringList & for (int i = 0; i < users.count(); i++) { ircuser = users[i]; if (!ircuser || _userModes.contains(ircuser)) { - addUserMode(ircuser, modes[i]); + if (modes[i].count() > 1) { + // Multiple modes received, do it one at a time + // TODO Better way of syncing this without breaking protocol? + for (int i_m = 0; i_m < modes[i].count(); ++i_m) { + addUserMode(ircuser, modes[i][i_m]); + } + } else { + addUserMode(ircuser, modes[i]); + } continue; } _userModes[ircuser] = modes[i]; - ircuser->joinChannel(this); + ircuser->joinChannel(this, true); connect(ircuser, SIGNAL(nickSet(QString)), this, SLOT(ircUserNickSet(QString))); // connect(ircuser, SIGNAL(destroyed()), this, SLOT(ircUserDestroyed())); - // if you wonder why there is no counterpart to ircUserJoined: - // the joines are propagted by the ircuser. the signal ircUserJoined is only for convenience + // If you wonder why there is no counterpart to ircUserJoined: + // the joins are propagated by the ircuser. The signal ircUserJoined is only for convenience newNicks << ircuser->nick(); newModes << modes[i]; @@ -227,8 +235,8 @@ void IrcChannel::part(IrcUser *ircuser) if (isKnownUser(ircuser)) { _userModes.remove(ircuser); ircuser->partChannel(this); - // if you wonder why there is no counterpart to ircUserParted: - // the joines are propagted by the ircuser. the signal ircUserParted is only for convenience + // If you wonder why there is no counterpart to ircUserParted: + // the joins are propagted by the ircuser. The signal ircUserParted is only for convenience disconnect(ircuser, 0, this, 0); emit ircUserParted(ircuser); @@ -468,7 +476,7 @@ void IrcChannel::ircUserNickSet(QString nick) * C --> set value or remove * D --> on/off * - * B and C behave very similar... we store the data in different datastructes + * B and C behave very similar... we store the data in different datastructures * for future compatibility ******************************************************************************/