X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fcommon%2Fignorelistmanager.cpp;h=e2e515cddca61ecce41b5f9e249b283f0b8da06d;hp=1599cde70ccd46fa335ab92437fc8095f07a694c;hb=8f1b4ca33d65b7d9b0e5be399dbff13c9591fbce;hpb=cd4f987d0d8ace10272bf1d87c788b741a9e85e8 diff --git a/src/common/ignorelistmanager.cpp b/src/common/ignorelistmanager.cpp index 1599cde7..e2e515cd 100644 --- a/src/common/ignorelistmanager.cpp +++ b/src/common/ignorelistmanager.cpp @@ -160,62 +160,6 @@ IgnoreListManager::StrictnessType IgnoreListManager::_match(const QString &msgCo } -bool IgnoreListManager::scopeMatch(const QString &scopeRule, const QString &string) const -{ - // A match happens when the string does NOT match ANY inverted rules and matches AT LEAST one - // normal rule, unless no normal rules exist (implicit wildcard match). This gives inverted - // rules higher priority regardless of ordering. - // - // TODO: After switching to Qt 5, use of this should be split into two parts, one part that - // would generate compiled QRegularExpressions for match/inverted match, regenerating it on any - // rule changes, and another part that would check each message against these compiled rules. - - // Keep track if any matches are found - bool matches = false; - // Keep track if normal rules and inverted rules are found, allowing for implicit wildcard - bool normalRuleFound = false, invertedRuleFound = false; - - // Split each scope rule by separator, ignoring empty parts - foreach(QString rule, scopeRule.split(";", QString::SkipEmptyParts)) { - // Trim whitespace from the start/end of the rule - rule = rule.trimmed(); - // Ignore empty rules - if (rule.isEmpty()) - continue; - - // Check if this is an inverted rule (starts with '!') - if (rule.startsWith("!")) { - // Inverted rule found - invertedRuleFound = true; - - // Take the reminder of the string - QRegExp ruleRx(rule.mid(1), Qt::CaseInsensitive); - ruleRx.setPatternSyntax(QRegExp::Wildcard); - if (ruleRx.exactMatch(string)) { - // Matches an inverted rule, full rule cannot match - return false; - } - } else { - // Normal rule found - normalRuleFound = true; - - QRegExp ruleRx(rule, Qt::CaseInsensitive); - ruleRx.setPatternSyntax(QRegExp::Wildcard); - if (ruleRx.exactMatch(string)) { - // Matches a normal rule, full rule might match - matches = true; - // Continue checking in case other inverted rules negate this - } - } - } - // No inverted rules matched, okay to match normally - // Return true if... - // ...we found a normal match - // ...implicit wildcard: we had inverted rules (that didn't match) and no normal rules - return matches || (invertedRuleFound && !normalRuleFound); -} - - void IgnoreListManager::removeIgnoreListItem(const QString &ignoreRule) { removeAt(indexOf(ignoreRule));