X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fclient%2Ftreemodel.cpp;h=000eaaa2fc0fe9553551d72baeaedb98734ab5d5;hp=64cc26fe333ae79f6980593a192942aca8438423;hb=42406861fbe570ed1fb45e9da39ff9a0de73c284;hpb=d5071b9120307cf45f2db1870cb2a54f50d08a45 diff --git a/src/client/treemodel.cpp b/src/client/treemodel.cpp index 64cc26fe..000eaaa2 100644 --- a/src/client/treemodel.cpp +++ b/src/client/treemodel.cpp @@ -301,15 +301,15 @@ TreeModel::TreeModel(const QList &data, QObject *parent) if(Quassel::isOptionSet("debugmodel")) { connect(this, SIGNAL(rowsAboutToBeInserted(const QModelIndex &, int, int)), - this, SLOT(debug_rowsAboutToBeInserted(const QModelIndex &, int, int))); + this, SLOT(debug_rowsAboutToBeInserted(const QModelIndex &, int, int))); connect(this, SIGNAL(rowsAboutToBeRemoved(const QModelIndex &, int, int)), - this, SLOT(debug_rowsAboutToBeRemoved(const QModelIndex &, int, int))); + this, SLOT(debug_rowsAboutToBeRemoved(const QModelIndex &, int, int))); connect(this, SIGNAL(rowsInserted(const QModelIndex &, int, int)), - this, SLOT(debug_rowsInserted(const QModelIndex &, int, int))); + this, SLOT(debug_rowsInserted(const QModelIndex &, int, int))); connect(this, SIGNAL(rowsRemoved(const QModelIndex &, int, int)), - this, SLOT(debug_rowsRemoved(const QModelIndex &, int, int))); + this, SLOT(debug_rowsRemoved(const QModelIndex &, int, int))); connect(this, SIGNAL(dataChanged(const QModelIndex &, const QModelIndex &)), - this, SLOT(debug_dataChanged(const QModelIndex &, const QModelIndex &))); + this, SLOT(debug_dataChanged(const QModelIndex &, const QModelIndex &))); } } @@ -318,7 +318,7 @@ TreeModel::~TreeModel() { } QModelIndex TreeModel::index(int row, int column, const QModelIndex &parent) const { - if(!hasIndex(row, column, parent)) + if(row < 0 || row >= rowCount(parent) || column < 0 || column >= columnCount(parent)) return QModelIndex(); AbstractTreeItem *parentItem; @@ -350,7 +350,8 @@ QModelIndex TreeModel::indexByItem(AbstractTreeItem *item) const { QModelIndex TreeModel::parent(const QModelIndex &index) const { if(!index.isValid()) { - qWarning() << "TreeModel::parent(): has been asked for the rootItems Parent!"; + // ModelTest does this + // qWarning() << "TreeModel::parent(): has been asked for the rootItems Parent!"; return QModelIndex(); } @@ -442,17 +443,17 @@ void TreeModel::itemDataChanged(int column) { void TreeModel::connectItem(AbstractTreeItem *item) { connect(item, SIGNAL(dataChanged(int)), - this, SLOT(itemDataChanged(int))); + this, SLOT(itemDataChanged(int))); connect(item, SIGNAL(beginAppendChilds(int, int)), - this, SLOT(beginAppendChilds(int, int))); + this, SLOT(beginAppendChilds(int, int))); connect(item, SIGNAL(endAppendChilds()), - this, SLOT(endAppendChilds())); + this, SLOT(endAppendChilds())); connect(item, SIGNAL(beginRemoveChilds(int, int)), - this, SLOT(beginRemoveChilds(int, int))); + this, SLOT(beginRemoveChilds(int, int))); connect(item, SIGNAL(endRemoveChilds()), - this, SLOT(endRemoveChilds())); + this, SLOT(endRemoveChilds())); } void TreeModel::beginAppendChilds(int firstRow, int lastRow) {