X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fclient%2Fexecwrapper.cpp;h=67292df2d865601ec1a0e5d0a96148d34a45b8a9;hp=7c9ce12d4deebc99a51de4d92b5ad217f5eb228c;hb=6eefdfc697067d184a589fc8a231b16316c09106;hpb=694f9bfbf7f1af19108461c7e00d133e55082bce diff --git a/src/client/execwrapper.cpp b/src/client/execwrapper.cpp index 7c9ce12d..67292df2 100644 --- a/src/client/execwrapper.cpp +++ b/src/client/execwrapper.cpp @@ -1,22 +1,22 @@ /*************************************************************************** -* Copyright (C) 2005-09 by the Quassel Project * -* devel@quassel-irc.org * -* * -* This program is free software; you can redistribute it and/or modify * -* it under the terms of the GNU General Public License as published by * -* the Free Software Foundation; either version 2 of the License, or * -* (at your option) version 3. * -* * -* This program is distributed in the hope that it will be useful, * -* but WITHOUT ANY WARRANTY; without even the implied warranty of * -* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * -* GNU General Public License for more details. * -* * -* You should have received a copy of the GNU General Public License * -* along with this program; if not, write to the * -* Free Software Foundation, Inc., * -* 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. * -***************************************************************************/ + * Copyright (C) 2005-2018 by the Quassel Project * + * devel@quassel-irc.org * + * * + * This program is free software; you can redistribute it and/or modify * + * it under the terms of the GNU General Public License as published by * + * the Free Software Foundation; either version 2 of the License, or * + * (at your option) version 3. * + * * + * This program is distributed in the hope that it will be useful, * + * but WITHOUT ANY WARRANTY; without even the implied warranty of * + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * + * GNU General Public License for more details. * + * * + * You should have received a copy of the GNU General Public License * + * along with this program; if not, write to the * + * Free Software Foundation, Inc., * + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. * + ***************************************************************************/ #include #include @@ -26,16 +26,17 @@ #include "client.h" #include "messagemodel.h" #include "quassel.h" +#include "util.h" ExecWrapper::ExecWrapper(QObject *parent) : QObject(parent) { - connect(&_process, SIGNAL(readyReadStandardOutput()), SLOT(processReadStdout())); - connect(&_process, SIGNAL(readyReadStandardError()), SLOT(processReadStderr())); - connect(&_process, SIGNAL(finished(int, QProcess::ExitStatus)), SLOT(processFinished(int, QProcess::ExitStatus))); - connect(&_process, SIGNAL(error(QProcess::ProcessError)), SLOT(processError(QProcess::ProcessError))); + connect(&_process, &QProcess::readyReadStandardOutput, this, &ExecWrapper::processReadStdout); + connect(&_process, &QProcess::readyReadStandardError, this, &ExecWrapper::processReadStderr); + connect(&_process, selectOverload(&QProcess::finished), this, &ExecWrapper::processFinished); + connect(&_process, selectOverload(&QProcess::error), this, &ExecWrapper::processError); - connect(this, SIGNAL(output(QString)), SLOT(postStdout(QString))); - connect(this, SIGNAL(error(QString)), SLOT(postStderr(QString))); + connect(this, &ExecWrapper::output, this, &ExecWrapper::postStdout); + connect(this, &ExecWrapper::error, this, &ExecWrapper::postStderr); } @@ -44,7 +45,7 @@ void ExecWrapper::start(const BufferInfo &info, const QString &command) _bufferInfo = info; QString params; - QRegExp rx("^\\s*(\\S+)(\\s+(.*))?$"); + QRegExp rx(R"(^\s*(\S+)(\s+(.*))?$)"); if (!rx.exactMatch(command)) { emit error(tr("Invalid command string for /exec: %1").arg(command)); } @@ -55,7 +56,7 @@ void ExecWrapper::start(const BufferInfo &info, const QString &command) // Make sure we don't execute something outside a script dir if (_scriptName.contains("../") || _scriptName.contains("..\\")) - emit error(tr("Name \"%1\" is invalid: ../ or ..\\ are not allowed!").arg(_scriptName)); + emit error(tr(R"(Name "%1" is invalid: ../ or ..\ are not allowed!)").arg(_scriptName)); else { foreach(QString scriptDir, Quassel::scriptDirPaths()) {