X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fclient%2Fclientbacklogmanager.cpp;h=8b6e2e47fe335736e9cada4a19b2bbfdfa24ba1a;hp=476fa103ab4cf99bd3abc2863cd27d80f68bef2e;hb=f9c4ee168a794add5261a7f1b6abb518f5987f8c;hpb=c230f7bd892b78b09710cf5746c2bf12a73d6b9b diff --git a/src/client/clientbacklogmanager.cpp b/src/client/clientbacklogmanager.cpp index 476fa103..8b6e2e47 100644 --- a/src/client/clientbacklogmanager.cpp +++ b/src/client/clientbacklogmanager.cpp @@ -29,9 +29,11 @@ #include +INIT_SYNCABLE_OBJECT(ClientBacklogManager) ClientBacklogManager::ClientBacklogManager(QObject *parent) : BacklogManager(parent), - _requester(0) + _requester(0), + _initBacklogRequested(false) { } @@ -56,7 +58,8 @@ void ClientBacklogManager::receiveBacklog(BufferId bufferId, MsgId first, MsgId bool lastPart = !_requester->buffer(bufferId, msglist); updateProgress(_requester->totalBuffers() - _requester->buffersWaiting(), _requester->totalBuffers()); if(lastPart) { - stopBuffering(); + dispatchMessages(_requester->bufferedMessages(), true); + _requester->flushBuffer(); } } else { dispatchMessages(msglist); @@ -77,7 +80,8 @@ void ClientBacklogManager::receiveBacklogAll(MsgId first, MsgId last, int limit, } void ClientBacklogManager::requestInitialBacklog() { - if(_requester && !_buffersRequested.isEmpty()) { + if(_initBacklogRequested) { + Q_ASSERT(_requester); qWarning() << "ClientBacklogManager::requestInitialBacklog() called twice in the same session! (Backlog has already been requested)"; return; } @@ -96,6 +100,7 @@ void ClientBacklogManager::requestInitialBacklog() { }; _requester->requestInitialBacklog(); + _initBacklogRequested = true; if(_requester->isBuffering()) { updateProgress(0, _requester->totalBuffers()); } @@ -113,9 +118,14 @@ BufferIdList ClientBacklogManager::filterNewBufferIds(const BufferIdList &buffer } void ClientBacklogManager::checkForBacklog(const QList &bufferIds) { + // we ingore all backlogrequests until we had our initial request + if(!_initBacklogRequested) { + return; + } + if(!_requester) { // during client start up this message is to be expected in some situations. - qDebug() << "ClientBacklogManager::checkForBacklog(): no active backlog requester (yet?)."; + qDebug() << "ClientBacklogManager::checkForBacklog(): no active backlog requester."; return; } switch(_requester->type()) { @@ -132,11 +142,6 @@ void ClientBacklogManager::checkForBacklog(const QList &bufferIds) { }; } -void ClientBacklogManager::stopBuffering() { - Q_ASSERT(_requester); - dispatchMessages(_requester->bufferedMessages(), true); -} - bool ClientBacklogManager::isBuffering() { return _requester && _requester->isBuffering(); } @@ -159,5 +164,6 @@ void ClientBacklogManager::dispatchMessages(const MessageList &messages, bool so void ClientBacklogManager::reset() { delete _requester; _requester = 0; + _initBacklogRequested = false; _buffersRequested.clear(); }