X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fclient%2Fclientbacklogmanager.cpp;h=0a02e4ee9d55b86ba67541dc85f73bc82908473b;hp=f88c606d74aace988d201a94a1e4f16c36d8f340;hb=526eccc444029c5a0d80694487c3aec6707cbeda;hpb=54afee59c56e1a75352b32200b9503150601bd90 diff --git a/src/client/clientbacklogmanager.cpp b/src/client/clientbacklogmanager.cpp index f88c606d..0a02e4ee 100644 --- a/src/client/clientbacklogmanager.cpp +++ b/src/client/clientbacklogmanager.cpp @@ -35,6 +35,11 @@ ClientBacklogManager::ClientBacklogManager(QObject *parent) { } +QVariantList ClientBacklogManager::requestBacklog(BufferId bufferId, MsgId first, MsgId last, int limit, int additional) { + _buffersRequested << bufferId; + return BacklogManager::requestBacklog(bufferId, first, last, limit, additional); +} + void ClientBacklogManager::receiveBacklog(BufferId bufferId, MsgId first, MsgId last, int limit, int additional, QVariantList msgs) { Q_UNUSED(first) Q_UNUSED(last) Q_UNUSED(limit) Q_UNUSED(additional) @@ -51,7 +56,8 @@ void ClientBacklogManager::receiveBacklog(BufferId bufferId, MsgId first, MsgId bool lastPart = !_requester->buffer(bufferId, msglist); updateProgress(_requester->totalBuffers() - _requester->buffersWaiting(), _requester->totalBuffers()); if(lastPart) { - stopBuffering(); + dispatchMessages(_requester->bufferedMessages(), true); + _requester->flushBuffer(); } } else { dispatchMessages(msglist); @@ -72,7 +78,7 @@ void ClientBacklogManager::receiveBacklogAll(MsgId first, MsgId last, int limit, } void ClientBacklogManager::requestInitialBacklog() { - if(_requester) { + if(_requester && !_buffersRequested.isEmpty()) { qWarning() << "ClientBacklogManager::requestInitialBacklog() called twice in the same session! (Backlog has already been requested)"; return; } @@ -90,7 +96,7 @@ void ClientBacklogManager::requestInitialBacklog() { _requester = new FixedBacklogRequester(this); }; - _requester->requestBacklog(); + _requester->requestInitialBacklog(); if(_requester->isBuffering()) { updateProgress(0, _requester->totalBuffers()); } @@ -98,16 +104,21 @@ void ClientBacklogManager::requestInitialBacklog() { BufferIdList ClientBacklogManager::filterNewBufferIds(const BufferIdList &bufferIds) { BufferIdList newBuffers; + QSet availableBuffers = Client::networkModel()->allBufferIds().toSet(); foreach(BufferId bufferId, bufferIds) { - if(!_buffersRequested.contains(bufferId)) - newBuffers << bufferId; + if(_buffersRequested.contains(bufferId) || !availableBuffers.contains(bufferId)) + continue; + newBuffers << bufferId; } - _buffersRequested += bufferIds.toSet(); return newBuffers; } void ClientBacklogManager::checkForBacklog(const QList &bufferIds) { - Q_ASSERT(_requester); + if(!_requester) { + // during client start up this message is to be expected in some situations. + qDebug() << "ClientBacklogManager::checkForBacklog(): no active backlog requester (yet?)."; + return; + } switch(_requester->type()) { case BacklogRequester::GlobalUnread: break; @@ -122,11 +133,6 @@ void ClientBacklogManager::checkForBacklog(const QList &bufferIds) { }; } -void ClientBacklogManager::stopBuffering() { - Q_ASSERT(_requester); - dispatchMessages(_requester->bufferedMessages(), true); -} - bool ClientBacklogManager::isBuffering() { return _requester && _requester->isBuffering(); }