X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fclient%2Fbufferviewoverlay.cpp;h=f4b298570094152a7200d120ad4e3e14e7d7d558;hp=cba8035a7389d7de9a12ef12d99d147e9c00f404;hb=1b8b7589f2fb30e1b3583a8914dabced8a190655;hpb=7fc418e5841a1633f651e08a34ccd2123ba6e0db

diff --git a/src/client/bufferviewoverlay.cpp b/src/client/bufferviewoverlay.cpp
index cba8035a..f4b29857 100644
--- a/src/client/bufferviewoverlay.cpp
+++ b/src/client/bufferviewoverlay.cpp
@@ -32,8 +32,7 @@ const int BufferViewOverlay::_updateEventId = QEvent::registerEventType();
 BufferViewOverlay::BufferViewOverlay(QObject *parent)
   : QObject(parent),
     _aboutToUpdate(false),
-    _addBuffersAutomatically(false),
-    _hideInactiveBuffers(false),
+    _uninitializedViewCount(0),
     _allowedBufferTypes(0),
     _minimumActivity(0)
 {
@@ -50,11 +49,14 @@ void BufferViewOverlay::addView(int viewId) {
   }
 
   _bufferViewIds << viewId;
+  _uninitializedViewCount++;
   if(config->isInitialized()) {
     viewInitialized(config);
   } else {
     disconnect(config, SIGNAL(initDone()), this, SLOT(viewInitialized()));
-    connect(config, SIGNAL(initDone()), this, SLOT(viewInitialized()));
+    // we use a queued connection here since manipulating the connection list of a sending object
+    // doesn't seem to be such a good idea while executing a connected slots.
+    connect(config, SIGNAL(initDone()), this, SLOT(viewInitialized()), Qt::QueuedConnection);
   }
 }
 
@@ -63,10 +65,28 @@ void BufferViewOverlay::removeView(int viewId) {
     return;
 
   _bufferViewIds.remove(viewId);
-  BufferViewConfig *config = qobject_cast<BufferViewConfig *>(sender());
+  BufferViewConfig *config = Client::bufferViewManager()->bufferViewConfig(viewId);
   if(config)
     disconnect(config, 0, this, 0);
+
+  // update initialized State:
+  bool wasInitialized = isInitialized();
+  _uninitializedViewCount = 0;
+  QSet<int>::iterator viewIter = _bufferViewIds.begin();
+  while(viewIter != _bufferViewIds.end()) {
+    config = Client::bufferViewManager()->bufferViewConfig(*viewIter);
+    if(!config) {
+      viewIter = _bufferViewIds.erase(viewIter);
+    } else {
+      if(!config->isInitialized())
+        _uninitializedViewCount++;
+      viewIter++;
+    }
+  }
+
   update();
+  if(!wasInitialized && isInitialized())
+    emit initDone();
 }
 
 void BufferViewOverlay::viewInitialized(BufferViewConfig *config) {
@@ -76,20 +96,23 @@ void BufferViewOverlay::viewInitialized(BufferViewConfig *config) {
   }
   disconnect(config, SIGNAL(initDone()), this, SLOT(viewInitialized()));
 
-  connect(config, SIGNAL(networkIdSet(const NetworkId &)), this, SLOT(update()));
-  connect(config, SIGNAL(addNewBuffersAutomaticallySet(bool)), this, SLOT(update()));
-  connect(config, SIGNAL(sortAlphabeticallySet(bool)), this, SLOT(update()));
-  connect(config, SIGNAL(hideInactiveBuffersSet(bool)), this, SLOT(update()));
-  connect(config, SIGNAL(allowedBufferTypesSet(int)), this, SLOT(update()));
-  connect(config, SIGNAL(minimumActivitySet(int)), this, SLOT(update()));
-  connect(config, SIGNAL(bufferListSet()), this, SLOT(update()));
-  connect(config, SIGNAL(bufferAdded(const BufferId &, int)), this, SLOT(update()));
-  connect(config, SIGNAL(bufferRemoved(const BufferId &)), this, SLOT(update()));
-  connect(config, SIGNAL(bufferPermanentlyRemoved(const BufferId &)), this, SLOT(update()));
+  connect(config, SIGNAL(configChanged()), this, SLOT(update()));
+//   connect(config, SIGNAL(networkIdSet(const NetworkId &)), this, SLOT(update()));
+//   connect(config, SIGNAL(sortAlphabeticallySet(bool)), this, SLOT(update()));
+//   connect(config, SIGNAL(allowedBufferTypesSet(int)), this, SLOT(update()));
+//   connect(config, SIGNAL(minimumActivitySet(int)), this, SLOT(update()));
+//   connect(config, SIGNAL(bufferListSet()), this, SLOT(update()));
+//   connect(config, SIGNAL(bufferAdded(const BufferId &, int)), this, SLOT(update()));
+//   connect(config, SIGNAL(bufferRemoved(const BufferId &)), this, SLOT(update()));
+//   connect(config, SIGNAL(bufferPermanentlyRemoved(const BufferId &)), this, SLOT(update()));
 
   // check if the view was removed in the meantime...
   if(_bufferViewIds.contains(config->bufferViewId()))
     update();
+
+  _uninitializedViewCount--;
+  if(isInitialized())
+    emit initDone();
 }
 
 void BufferViewOverlay::viewInitialized() {
@@ -113,8 +136,6 @@ void BufferViewOverlay::updateHelper() {
 
   bool changed = false;
 
-  bool addBuffersAutomatically = false;
-  bool hideInactiveBuffers = true;
   int allowedBufferTypes = 0;
   int minimumActivity = -1;
   QSet<NetworkId> networkIds;
@@ -130,48 +151,32 @@ void BufferViewOverlay::updateHelper() {
       if(!config)
         continue;
 
-      networkIds << config->networkId();
-      if(config->networkId().isValid()) {
-        NetworkId networkId = config->networkId();
-        // we have to filter out all the buffers that don't belong to this net... :/
-        QSet<BufferId> bufferIds;
-        foreach(BufferId bufferId, config->bufferList()) {
-          if(Client::networkModel()->networkId(bufferId) == networkId)
-            bufferIds << bufferId;
-        }
-        buffers += bufferIds;
-
-        bufferIds.clear();
-        foreach(BufferId bufferId, config->temporarilyRemovedBuffers()) {
-          if(Client::networkModel()->networkId(bufferId) == networkId)
-            bufferIds << bufferId;
-        }
-        tempRemovedBuffers += bufferIds;
-      } else {
-        buffers += config->bufferList().toSet();
-        tempRemovedBuffers += config->temporarilyRemovedBuffers();
-      }
-
-      // in the overlay a buffer is removed it is removed from all views
-      if(removedBuffers.isEmpty())
-        removedBuffers = config->removedBuffers();
-      else
-        removedBuffers.intersect(config->removedBuffers());
-
-
-      addBuffersAutomatically |= config->addNewBuffersAutomatically();
-      hideInactiveBuffers &= config->hideInactiveBuffers();
       allowedBufferTypes |= config->allowedBufferTypes();
       if(minimumActivity == -1 || config->minimumActivity() < minimumActivity)
         minimumActivity = config->minimumActivity();
+
+      networkIds << config->networkId();
+
+
+      // we have to apply several filters before we can add a buffer to a category (visible, removed, ...)
+      buffers += filterBuffersByConfig(config->bufferList(), config);
+      tempRemovedBuffers += filterBuffersByConfig(config->temporarilyRemovedBuffers().toList(), config);
+      removedBuffers += config->removedBuffers();
     }
+
+    // prune the sets from overlap
     QSet<BufferId> availableBuffers = Client::networkModel()->allBufferIds().toSet();
+
     buffers.intersect(availableBuffers);
+
     tempRemovedBuffers.intersect(availableBuffers);
+    tempRemovedBuffers.subtract(buffers);
+
+    removedBuffers.intersect(availableBuffers);
+    removedBuffers.subtract(tempRemovedBuffers);
+    removedBuffers.subtract(buffers);
   }
 
-  changed |= (addBuffersAutomatically != _addBuffersAutomatically);
-  changed |= (hideInactiveBuffers != _hideInactiveBuffers);
   changed |= (allowedBufferTypes != _allowedBufferTypes);
   changed |= (minimumActivity != _minimumActivity);
   changed |= (networkIds != _networkIds);
@@ -179,8 +184,6 @@ void BufferViewOverlay::updateHelper() {
   changed |= (removedBuffers != _removedBuffers);
   changed |= (tempRemovedBuffers != _tempRemovedBuffers);
 
-  _addBuffersAutomatically = addBuffersAutomatically;
-  _hideInactiveBuffers = hideInactiveBuffers;
   _allowedBufferTypes = allowedBufferTypes;
   _minimumActivity = minimumActivity;
   _networkIds = networkIds;
@@ -194,6 +197,24 @@ void BufferViewOverlay::updateHelper() {
     emit hasChanged();
 }
 
+QSet<BufferId> BufferViewOverlay::filterBuffersByConfig(const QList<BufferId> &buffers, const BufferViewConfig *config) {
+  Q_ASSERT(config);
+
+  QSet<BufferId> bufferIds;
+  BufferInfo bufferInfo;
+  foreach(BufferId bufferId, buffers) {
+    bufferInfo = Client::networkModel()->bufferInfo(bufferId);
+    if(!(bufferInfo.type() & config->allowedBufferTypes()))
+      continue;
+    if(config->networkId().isValid() && bufferInfo.networkId() != config->networkId())
+      continue;
+    bufferIds << bufferId;
+  }
+
+  return bufferIds;
+}
+
+
 void BufferViewOverlay::customEvent(QEvent *event) {
   if(event->type() == _updateEventId) {
     updateHelper();
@@ -225,16 +246,6 @@ const QSet<BufferId> &BufferViewOverlay::tempRemovedBufferIds() {
   return _tempRemovedBuffers;
 }
 
-bool BufferViewOverlay::addBuffersAutomatically() {
-  updateHelper();
-  return _addBuffersAutomatically;
-}
-
-bool BufferViewOverlay::hideInactiveBuffers() {
-  updateHelper();
-  return _hideInactiveBuffers;
-}
-
 int BufferViewOverlay::allowedBufferTypes() {
   updateHelper();
   return _allowedBufferTypes;