X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=src%2Fclient%2Fbuffer.cpp;h=c6737bc579e3524e86831310770983bc99859177;hp=54bd81a1c02b06def25a1a8033e0dad492c35c78;hb=d1a410b43b09e31472b860bc5f5bbf9c253c047e;hpb=8010224cf5bfe5685dc2cf535e8dc1ec19c4c364 diff --git a/src/client/buffer.cpp b/src/client/buffer.cpp index 54bd81a1..c6737bc5 100644 --- a/src/client/buffer.cpp +++ b/src/client/buffer.cpp @@ -54,6 +54,10 @@ void Buffer::appendMsg(const Message &msg) { } void Buffer::prependMsg(const Message &msg) { + // check for duplicate first + if(contents().count() > 0 && msg.msgId() >= contents().first()->msgId()) { + return; + } updateActivityLevel(msg); layoutQueue.append(msg); } @@ -71,29 +75,46 @@ void Buffer::setVisible(bool visible) { _isVisible = visible; setActivityLevel(NoActivity); if(!layoutedMsgs.count()) return; - setLastSeen(layoutedMsgs.last()->timestamp()); + setLastSeenMsg(layoutedMsgs.last()->msgId()); } -void Buffer::setLastSeen(const QDateTime &seen) { - if(seen.isValid() && seen > lastSeen()) { //qDebug() << "setting:" << bufferInfo().bufferName() << seen; - _lastSeen = seen; - Client::bufferSyncer()->requestSetLastSeen(bufferInfo().bufferId(), seen); +void Buffer::setLastSeenMsg(const MsgId &msgId) { + // qDebug() << "want to set lastSeen:" << bufferInfo() << seen << lastSeen(); + const MsgId oldLastSeen = lastSeenMsg(); + if(!oldLastSeen.isValid() || msgId.isValid() && msgId > oldLastSeen) { + //qDebug() << "setting:" << bufferInfo().bufferName() << seen; + _lastSeenMsg = msgId; + Client::setBufferLastSeenMsg(bufferInfo().bufferId(), msgId); + //qDebug() << "setting lastSeen:" << bufferInfo() << lastSeen(); setActivityLevel(NoActivity); } } void Buffer::setActivityLevel(ActivityLevel level) { _activityLevel = level; - if(bufferInfo().bufferId() > 0) Client::networkModel()->setBufferActivity(bufferInfo(), level); + if(bufferInfo().bufferId() > 0) { + Client::networkModel()->setBufferActivity(bufferInfo(), level); + //qDebug() << "setting level:" << bufferInfo() << lastSeen() << level; + } } void Buffer::updateActivityLevel(const Message &msg) { - if(isVisible()) return; - if(lastSeen().isValid() && lastSeen() >= msg.timestamp()) return; + if(isVisible()) + return; - ActivityLevel level = activityLevel() | OtherActivity; - if(msg.type() == Message::Plain || msg.type() == Message::Notice) level |= NewMessage; - if(msg.flags() & Message::Highlight) level |= Highlight; + if(msg.flags() & Message::Self) // don't update activity for our own messages + return; - if(level != activityLevel()) setActivityLevel(level); + if(lastSeenMsg().isValid() && lastSeenMsg() >= msg.msgId()) + return; + + ActivityLevel level = activityLevel() | OtherActivity; + if(msg.type() & (Message::Plain | Message::Notice | Message::Action)) + level |= NewMessage; + + if(msg.flags() & Message::Highlight) + level |= Highlight; + + if(level != activityLevel()) + setActivityLevel(level); }