X-Git-Url: https://git.quassel-irc.org/?p=quassel.git;a=blobdiff_plain;f=cmake%2FQuasselCompileSettings.cmake;h=4493d4d2ddce32f5791f6b9ef13f9157e3459ce4;hp=ec3e17a4b8354789ea25b0d4a84eb3f3cadb3326;hb=c9d498c1d165c23cb854a8fbe9482a9289029071;hpb=d9e586707522241d628a90466e13722e342cc28a diff --git a/cmake/QuasselCompileSettings.cmake b/cmake/QuasselCompileSettings.cmake index ec3e17a4..4493d4d2 100644 --- a/cmake/QuasselCompileSettings.cmake +++ b/cmake/QuasselCompileSettings.cmake @@ -1,10 +1,12 @@ # This file contains compile flags and general build configuration for Quassel # -# (C) 2014-2018 by the Quassel Project +# (C) 2014-2020 by the Quassel Project # # Redistribution and use is allowed according to the terms of the BSD license. # For details see the accompanying COPYING-CMAKE-SCRIPTS file. +include(QuasselMacros) + # Helper function to check for linker flag support include(CheckCXXCompilerFlag) function(check_and_set_linker_flag flag name outvar) @@ -21,43 +23,107 @@ endfunction() set(CMAKE_CXX_STANDARD 14) set(CMAKE_CXX_STANDARD_REQUIRED OFF) # Rely on compile features if standard is not supported set(CMAKE_CXX_EXTENSIONS OFF) # We like to be standard conform + +set(CMAKE_CXX_VISIBILITY_PRESET hidden) +set(CMAKE_VISIBILITY_INLINES_HIDDEN ON) set(CMAKE_POSITION_INDEPENDENT_CODE ON) # For GCC and Clang, enable a whole bunch of warnings if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang") add_compile_options( + -fdiagnostics-color=always + -fexceptions + -fno-common -Wall - -Wcast-align -Wextra + -Wcast-align -Wformat-security - -Wno-unknown-pragmas -Wnon-virtual-dtor + -Woverloaded-virtual -Wpedantic -Wundef - -fno-common - -fstack-protector-strong - -fvisibility=default - -fvisibility-inlines-hidden + -Wvla + -Werror=return-type + "$<$:-Werror>" + -Wno-error=deprecated # Don't break on Qt upgrades + -Wno-unknown-pragmas "$<$>:-U_FORTIFY_SOURCE;-D_FORTIFY_SOURCE=2>" ) + # ssp is currently very broken on MinGW + if(NOT MINGW) + add_compile_options(-fstack-protector-strong) + endif() + # Check for and set linker flags - check_and_set_linker_flag("-Wl,-z,relro" RELRO LINKER_FLAGS) - check_and_set_linker_flag("-Wl,-z,now" NOW LINKER_FLAGS) - check_and_set_linker_flag("-Wl,--as-needed" AS_NEEDED LINKER_FLAGS) + check_and_set_linker_flag("-Wl,-z,relro" RELRO LINKER_FLAGS) + check_and_set_linker_flag("-Wl,-z,now" NOW LINKER_FLAGS) + check_and_set_linker_flag("-Wl,--as-needed" AS_NEEDED LINKER_FLAGS) + check_and_set_linker_flag("-Wl,--enable-new-dtags" ENABLE_NEW_DTAGS LINKER_FLAGS) + check_and_set_linker_flag("-Wl,--no-undefined" NO_UNDEFINED LINKER_FLAGS) + + set(CMAKE_EXE_LINKER_FLAGS "${LINKER_FLAGS} ${CMAKE_EXE_LINKER_FLAGS}") + set(CMAKE_MODULE_LINKER_FLAGS "${LINKER_FLAGS} ${CMAKE_MODULE_LINKER_FLAGS}") + set(CMAKE_SHARED_LINKER_FLAGS "${LINKER_FLAGS} ${CMAKE_SHARED_LINKER_FLAGS}") + +elseif(MSVC) + # Target Windows Vista + add_definitions(-D_WIN32_WINNT=0x0600 -DWINVER=0x0600 -D_WIN32_IE=0x0600) + + # Various settings for the Windows API + add_definitions(-DWIN32_LEAN_AND_MEAN -DUNICODE -D_UNICODE -D_USE_MATH_DEFINES -DNOMINMAX) + + # Compile options + add_compile_options( + /EHsc + "$<$:/WX>" + ) + + # Increase warning level on MSVC + # CMake puts /W3 in CMAKE_CXX_FLAGS which will be appended later, so we need to replace + string(REPLACE "/W3" "/W4" CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}") + + # Silence annoying/useless warnings + # C4127: conditional expression is constant + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4127") + # C4244: 'identifier': conversion from 't1' to 't2', possible loss of data + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4244") + # C4456: declaration of 'identifier' hides previous local declaration + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4456") + # C4458: declaration of 'identifier' hides class member + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4458") + # C4996: deprecation warnings + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd4996") + + # Link against the correct version of the C runtime + set(CMAKE_EXE_LINKER_FLAGS_RELEASE "/NODEFAULTLIB:libcmt /DEFAULTLIB:msvcrt ${CMAKE_EXE_LINKER_FLAGS_RELEASE}") + set(CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO "/NODEFAULTLIB:libcmt /DEFAULTLIB:msvcrt ${CMAKE_EXE_LINKER_FLAGS_RELWITHDEBINFO}") + set(CMAKE_EXE_LINKER_FLAGS_MINSIZEREL "/NODEFAULTLIB:libcmt /DEFAULTLIB:msvcrt ${CMAKE_EXE_LINKER_FLAGS_MINSIZEREL}") + set(CMAKE_EXE_LINKER_FLAGS_DEBUG "/NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd ${CMAKE_EXE_LINKER_FLAGS_DEBUG}") - set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${LINKER_FLAGS}") - set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${LINKER_FLAGS}") - set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${LINKER_FLAGS}") else() # For other compilers, we rely on default settings (unless someone provides a good set of options; patches welcome!) + message(WARNING "${CMAKE_CXX_COMPILER_ID} is not a supported C++ compiler.") endif() # Mac build stuff -if (APPLE AND DEPLOY) +if (APPLE) set(CMAKE_OSX_ARCHITECTURES "x86_64") add_compile_options( -mmacosx-version-min=10.9 -stdlib=libc++ ) + add_definitions(-DQT_MAC_USE_COCOA -D_DARWIN_C_SOURCE) +endif() + +# Optionally, produce clazy warnings +if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") + option(ENABLE_CLAZY "Enable Clazy warnings" OFF) + + if(ENABLE_CLAZY) + set(CMAKE_CXX_COMPILE_OBJECT "${CMAKE_CXX_COMPILE_OBJECT} -Xclang -load -Xclang ClangLazy${CMAKE_SHARED_LIBRARY_SUFFIX} -Xclang -add-plugin -Xclang clang-lazy") + endif() endif() + +# Append CMAKE_CXX_FLAGS, so our flags can be overwritten externally. +process_cmake_cxx_flags()