modernize: Migrate action-related things to PMF connects

[quassel.git] / src / uisupport / action.cpp

diff --git a/src/uisupport/action.cpp b/src/uisupport/action.cpp
index 1807631..2d54af3 100644 (file)
--- a/src/uisupport/action.cpp
+++ b/src/uisupport/action.cpp
@@ -25,55 +25,25 @@
 #include <QApplication>
 
 Action::Action(QObject *parent)
-#ifdef HAVE_KDE4
-    : KAction(parent)
-#else
     : QWidgetAction(parent)
-#endif
 {
-    init();
+    setProperty("isShortcutConfigurable", true);
+    connect(this, &QAction::triggered, this, &Action::slotTriggered);
 }
 
 
-Action::Action(const QString &text, QObject *parent, const QObject *receiver, const char *slot, const QKeySequence &shortcut)
-#ifdef HAVE_KDE4
-    : KAction(parent)
-#else
-    : QWidgetAction(parent)
-#endif
+Action::Action(const QString &text, QObject *parent, const QKeySequence &shortcut)
+    : Action(parent)
 {
-    init();
     setText(text);
     setShortcut(shortcut);
-    if (receiver && slot)
-        connect(this, SIGNAL(triggered()), receiver, slot);
 }
 
 
-Action::Action(const QIcon &icon, const QString &text, QObject *parent, const QObject *receiver, const char *slot, const QKeySequence &shortcut)
-#ifdef HAVE_KDE4
-    : KAction(parent)
-#else
-    : QWidgetAction(parent)
-#endif
+Action::Action(const QIcon &icon, const QString &text, QObject *parent, const QKeySequence &shortcut)
+    : Action(text, parent, shortcut)
 {
-    init();
     setIcon(icon);
-    setText(text);
-    setShortcut(shortcut);
-    if (receiver && slot)
-        connect(this, SIGNAL(triggered()), receiver, slot);
-}
-
-
-#ifdef HAVE_KDE4
-void Action::init() {}
-#else
-void Action::init()
-{
-    connect(this, SIGNAL(triggered(bool)), this, SLOT(slotTriggered()));
-
-    setProperty("isShortcutConfigurable", true);
 }
 
 
@@ -99,12 +69,8 @@ QKeySequence Action::shortcut(ShortcutTypes type) const
 {
     Q_ASSERT(type);
     if (type == DefaultShortcut) {
-#if QT_VERSION < 0x050000
-        return property("defaultShortcut").value<QKeySequence>();
-#else
         auto sequence = property("defaultShortcuts").value<QList<QKeySequence>>();
         return sequence.isEmpty() ? QKeySequence() : sequence.first();
-#endif
     }
 
     return shortcuts().isEmpty() ? QKeySequence() : shortcuts().first();
@@ -122,15 +88,8 @@ void Action::setShortcut(const QKeySequence &key, ShortcutTypes type)
     Q_ASSERT(type);
 
     if (type & DefaultShortcut) {
-#if QT_VERSION < 0x050000
-        setProperty("defaultShortcut", key);
-#else
         setProperty("defaultShortcuts", QVariant::fromValue(QList<QKeySequence>() << key));
-#endif
     }
     if (type & ActiveShortcut)
         QAction::setShortcut(key);
 }
-
-
-#endif /* HAVE_KDE4 */