core: Don't store a reference in CoreCertManager

[quassel.git] / src / core / coreidentity.cpp

diff --git a/src/core/coreidentity.cpp b/src/core/coreidentity.cpp
index 6fe0e97..5671ae8 100644 (file)
--- a/src/core/coreidentity.cpp
+++ b/src/core/coreidentity.cpp
@@ -1,5 +1,5 @@
 /***************************************************************************
- *   Copyright (C) 2005-08 by the Quassel Project                          *
+ *   Copyright (C) 2005-2019 by the Quassel Project                        *
  *   devel@quassel-irc.org                                                 *
  *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *
@@ -15,79 +15,104 @@
  *   You should have received a copy of the GNU General Public License     *
  *   along with this program; if not, write to the                         *
  *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.         *
  ***************************************************************************/
 
 #include "coreidentity.h"
 
 #include "signalproxy.h"
 
-CoreIdentity::CoreIdentity(IdentityId id, QObject *parent)
-  : Identity(id, parent),
-    _certManager(*this)
+CoreIdentity::CoreIdentity(IdentityId id, QObject* parent)
+    : Identity(id, parent)
+#ifdef HAVE_SSL
+    , _certManager(this)
+#endif
 {
-  connect(this, SIGNAL(idSet(IdentityId)), &_certManager, SLOT(setId(IdentityId)));
+#ifdef HAVE_SSL
+    connect(this, &Identity::idSet, &_certManager, &CoreCertManager::setId);
+    connect(&_certManager, &SyncableObject::updated, this, &SyncableObject::updated);
+#endif
 }
 
-CoreIdentity::CoreIdentity(const Identity &other, QObject *parent)
-  : Identity(other, parent),
-    _certManager(*this)
+CoreIdentity::CoreIdentity(const Identity& other, QObject* parent)
+    : Identity(other, parent)
+#ifdef HAVE_SSL
+    , _certManager(this)
+#endif
 {
-  connect(this, SIGNAL(idSet(IdentityId)), &_certManager, SLOT(setId(IdentityId)));
+#ifdef HAVE_SSL
+    connect(this, &Identity::idSet, &_certManager, &CoreCertManager::setId);
+    connect(&_certManager, &SyncableObject::updated, this, &SyncableObject::updated);
+#endif
 }
 
-CoreIdentity::CoreIdentity(const CoreIdentity &other, QObject *parent)
-  : Identity(other, parent),
-    _sslKey(other._sslKey),
-    _sslCert(other._sslCert),
-    _certManager(*this)
+CoreIdentity::CoreIdentity(const CoreIdentity& other, QObject* parent)
+    : Identity(other, parent)
+#ifdef HAVE_SSL
+    , _sslKey(other._sslKey)
+    , _sslCert(other._sslCert)
+    , _certManager(this)
+#endif
 {
-  connect(this, SIGNAL(idSet(IdentityId)), &_certManager, SLOT(setId(IdentityId)));
+#ifdef HAVE_SSL
+    connect(this, &Identity::idSet, &_certManager, &CoreCertManager::setId);
+    connect(&_certManager, &SyncableObject::updated, this, &SyncableObject::updated);
+#endif
 }
 
-void CoreIdentity::synchronize(SignalProxy *proxy) {
-  proxy->synchronize(this);
-  proxy->synchronize(&_certManager);
+void CoreIdentity::synchronize(SignalProxy* proxy)
+{
+    proxy->synchronize(this);
+#ifdef HAVE_SSL
+    proxy->synchronize(&_certManager);
+#endif
 }
 
-void CoreIdentity::setSslKey(const QByteArray &encoded) {
-  QSslKey key(encoded, QSsl::Rsa);
-  if(key.isNull())
-    key = QSslKey(encoded, QSsl::Dsa);
-  setSslKey(key);
+#ifdef HAVE_SSL
+void CoreIdentity::setSslKey(const QByteArray& encoded)
+{
+    QSslKey key(encoded, QSsl::Rsa);
+    if (key.isNull())
+        key = QSslKey(encoded, QSsl::Ec);
+    if (key.isNull())
+        key = QSslKey(encoded, QSsl::Dsa);
+    setSslKey(key);
 }
 
-void CoreIdentity::setSslCert(const QByteArray &encoded) {
-  setSslCert(QSslCertificate(encoded));
+void CoreIdentity::setSslCert(const QByteArray& encoded)
+{
+    setSslCert(QSslCertificate(encoded));
 }
 
-CoreIdentity &CoreIdentity::operator=(const CoreIdentity &identity) {
-  Identity::operator=(identity);
-  _sslKey = identity._sslKey;
-  _sslCert = identity._sslCert;
-  return *this;
-}
+#endif
 
+#ifdef HAVE_SSL
 // ========================================
 //  CoreCertManager
 // ========================================
-CoreCertManager::CoreCertManager(CoreIdentity &identity)
-  : CertManager(identity.id()),
-    identity(identity)
+
+CoreCertManager::CoreCertManager(CoreIdentity* identity)
+    : CertManager(identity->id())
+    , _identity(identity)
 {
-  setAllowClientUpdates(true);
+    setAllowClientUpdates(true);
 }
 
-void CoreCertManager::setSslKey(const QByteArray &encoded) {
-  identity.setSslKey(encoded);
-  CertManager::setSslKey(encoded);
+void CoreCertManager::setId(IdentityId id)
+{
+    setObjectName(QString::number(id.toInt()));
 }
 
-void CoreCertManager::setSslCert(const QByteArray &encoded) {
-  identity.setSslCert(encoded);
-  CertManager::setSslCert(encoded);
+void CoreCertManager::setSslKey(const QByteArray& encoded)
+{
+    _identity->setSslKey(encoded);
+    CertManager::setSslKey(encoded);
 }
 
-void CoreCertManager::setId(IdentityId id) {
-  renameObject(QString::number(id.toInt()));
+void CoreCertManager::setSslCert(const QByteArray& encoded)
+{
+    _identity->setSslCert(encoded);
+    CertManager::setSslCert(encoded);
 }
+
+#endif  // HAVE_SSL