Implement changes requested in review

[quassel.git] / src / core / corebuffersyncer.h

diff --git a/src/core/corebuffersyncer.h b/src/core/corebuffersyncer.h
index af009d0..93e2cf9 100644 (file)
--- a/src/core/corebuffersyncer.h
+++ b/src/core/corebuffersyncer.h
@@ -31,33 +31,33 @@ class CoreBufferSyncer : public BufferSyncer
         Q_OBJECT
 
 public:
-    CoreBufferSyncer(CoreSession *parent);
+    explicit CoreBufferSyncer(CoreSession *parent);
 
 public slots:
-    virtual void requestSetLastSeenMsg(BufferId buffer, const MsgId &msgId);
-    virtual void requestSetMarkerLine(BufferId buffer, const MsgId &msgId);
+    void requestSetLastSeenMsg(BufferId buffer, const MsgId &msgId) override;
+    void requestSetMarkerLine(BufferId buffer, const MsgId &msgId) override;
 
-    virtual inline void requestRemoveBuffer(BufferId buffer) { removeBuffer(buffer); }
-    virtual void removeBuffer(BufferId bufferId);
+    inline void requestRemoveBuffer(BufferId buffer) override { removeBuffer(buffer); }
+    void removeBuffer(BufferId bufferId) override;
 
-    void addBufferActivity(Message message) {
+    void addBufferActivity(const Message &message) {
         auto oldActivity = activity(message.bufferId());
         if (!oldActivity.testFlag(message.type())) {
             setBufferActivity(message.bufferId(), (int) (oldActivity | message.type()));
         }
     }
 
-    void setBufferActivity(BufferId buffer, const int &activity) override;
+    void setBufferActivity(BufferId buffer, int activity) override;
 
-    virtual inline void requestRenameBuffer(BufferId buffer, QString newName) { renameBuffer(buffer, newName); }
-    virtual void renameBuffer(BufferId buffer, QString newName);
+    inline void requestRenameBuffer(BufferId buffer, QString newName) override { renameBuffer(buffer, newName); }
+    void renameBuffer(BufferId buffer, QString newName) override;
 
-    virtual inline void requestMergeBuffersPermanently(BufferId buffer1, BufferId buffer2) { mergeBuffersPermanently(buffer1, buffer2); }
-    virtual void mergeBuffersPermanently(BufferId buffer1, BufferId buffer2);
+    inline void requestMergeBuffersPermanently(BufferId buffer1, BufferId buffer2) override { mergeBuffersPermanently(buffer1, buffer2); }
+    void mergeBuffersPermanently(BufferId buffer1, BufferId buffer2) override;
 
-    virtual void requestPurgeBufferIds();
+    void requestPurgeBufferIds() override;
 
-    virtual inline void requestMarkBufferAsRead(BufferId buffer) {
+    inline void requestMarkBufferAsRead(BufferId buffer) override {
         setBufferActivity(buffer, (int) Message::Types());
         markBufferAsRead(buffer);
     }
@@ -65,7 +65,7 @@ public slots:
     void storeDirtyIds();
 
 protected:
-    virtual void customEvent(QEvent *event);
+    void customEvent(QEvent *event) override;
 
 private:
     CoreSession *_coreSession;