Simplify session thread handling in Core
[quassel.git] / src / core / core.cpp
index 50e4ae0..e7b5639 100644 (file)
@@ -1,5 +1,5 @@
 /***************************************************************************
- *   Copyright (C) 2005-09 by the Quassel Project                          *
+ *   Copyright (C) 2005-2015 by the Quassel Project                        *
  *   devel@quassel-irc.org                                                 *
  *                                                                         *
  *   This program is free software; you can redistribute it and/or modify  *
  *   You should have received a copy of the GNU General Public License     *
  *   along with this program; if not, write to the                         *
  *   Free Software Foundation, Inc.,                                       *
- *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
+ *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.         *
  ***************************************************************************/
 
 #include <QCoreApplication>
 
 #include "core.h"
+#include "coreauthhandler.h"
 #include "coresession.h"
 #include "coresettings.h"
+#include "logger.h"
+#include "internalpeer.h"
+#include "network.h"
 #include "postgresqlstorage.h"
 #include "quassel.h"
-#include "signalproxy.h"
 #include "sqlitestorage.h"
-#include "network.h"
-#include "logger.h"
-
 #include "util.h"
 
 // migration related
 #include <QFile>
-#ifdef Q_OS_WIN32
+#ifdef Q_OS_WIN
 #  include <windows.h>
 #else
 #  include <unistd.h>
 #  include <termios.h>
-#endif /* Q_OS_WIN32 */
+#endif /* Q_OS_WIN */
 
 #ifdef HAVE_UMASK
 #  include <sys/types.h>
@@ -54,8 +54,8 @@ const int Core::AddClientEventId = QEvent::registerEventType();
 class AddClientEvent : public QEvent
 {
 public:
-    AddClientEvent(QTcpSocket *socket, UserId uid) : QEvent(QEvent::Type(Core::AddClientEventId)), socket(socket), userId(uid) {}
-    QTcpSocket *socket;
+    AddClientEvent(RemotePeer *p, UserId uid) : QEvent(QEvent::Type(Core::AddClientEventId)), peer(p), userId(uid) {}
+    RemotePeer *peer;
     UserId userId;
 };
 
@@ -82,7 +82,8 @@ void Core::destroy()
 
 
 Core::Core()
-    : _storage(0)
+    : QObject(),
+      _storage(0)
 {
 #ifdef HAVE_UMASK
     umask(S_IRWXG | S_IRWXO);
@@ -93,11 +94,11 @@ Core::Core()
 
     // FIXME: MIGRATION 0.3 -> 0.4: Move database and core config to new location
     // Move settings, note this does not delete the old files
-#ifdef Q_WS_MAC
+#ifdef Q_OS_MAC
     QSettings newSettings("quassel-irc.org", "quasselcore");
 #else
 
-# ifdef Q_WS_WIN
+# ifdef Q_OS_WIN
     QSettings::Format format = QSettings::IniFormat;
 # else
     QSettings::Format format = QSettings::NativeFormat;
@@ -105,10 +106,10 @@ Core::Core()
     QString newFilePath = Quassel::configDirPath() + "quasselcore"
                           + ((format == QSettings::NativeFormat) ? QLatin1String(".conf") : QLatin1String(".ini"));
     QSettings newSettings(newFilePath, format);
-#endif /* Q_WS_MAC */
+#endif /* Q_OS_MAC */
 
     if (newSettings.value("Config/Version").toUInt() == 0) {
-#   ifdef Q_WS_MAC
+#   ifdef Q_OS_MAC
         QString org = "quassel-irc.org";
 #   else
         QString org = "Quassel Project";
@@ -121,10 +122,10 @@ Core::Core()
             newSettings.setValue("Config/Version", 1);
             qWarning() << "*   Your core settings have been migrated to" << newSettings.fileName();
 
-#ifndef Q_WS_MAC /* we don't need to move the db and cert for mac */
-#ifdef Q_OS_WIN32
+#ifndef Q_OS_MAC /* we don't need to move the db and cert for mac */
+#ifdef Q_OS_WIN
             QString quasselDir = qgetenv("APPDATA") + "/quassel/";
-#elif defined Q_WS_MAC
+#elif defined Q_OS_MAC
             QString quasselDir = QDir::homePath() + "/Library/Application Support/Quassel/";
 #else
             QString quasselDir = QDir::homePath() + "/.quassel/";
@@ -152,7 +153,7 @@ Core::Core()
                 else
                     qWarning() << "!!! Moving your certificate has failed. Please move it manually into" << Quassel::configDirPath();
             }
-#endif /* !Q_WS_MAC */
+#endif /* !Q_OS_MAC */
             qWarning() << "*** Migration completed.\n\n";
         }
     }
@@ -176,7 +177,9 @@ Core::Core()
 void Core::init()
 {
     CoreSettings cs;
-    _configured = initStorage(cs.storageSettings().toMap());
+    // legacy
+    QVariantMap dbsettings = cs.storageSettings().toMap();
+    _configured = initStorage(dbsettings.value("Backend").toString(), dbsettings.value("ConnectionProperties").toMap());
 
     if (Quassel::isOptionSet("select-backend")) {
         selectBackend(Quassel::optionValue("select-backend"));
@@ -215,10 +218,11 @@ void Core::init()
 
 Core::~Core()
 {
-    foreach(QTcpSocket *socket, blocksizes.keys()) {
-        socket->disconnectFromHost(); // disconnect non authed clients
+    // FIXME do we need more cleanup for handlers?
+    foreach(CoreAuthHandler *handler, _connectingClients) {
+        handler->deleteLater(); // disconnect non authed clients
     }
-    qDeleteAll(sessions);
+    qDeleteAll(_sessions);
     qDeleteAll(_storageBackends);
 }
 
@@ -230,7 +234,8 @@ void Core::saveState()
     CoreSettings s;
     QVariantMap state;
     QVariantList activeSessions;
-    foreach(UserId user, instance()->sessions.keys()) activeSessions << QVariant::fromValue<UserId>(user);
+    foreach(UserId user, instance()->_sessions.keys())
+        activeSessions << QVariant::fromValue<UserId>(user);
     state["CoreStateVersion"] = 1;
     state["ActiveSessions"] = activeSessions;
     s.setCoreState(state);
@@ -243,7 +248,7 @@ void Core::restoreState()
         // qWarning() << qPrintable(tr("Cannot restore a state for an unconfigured core!"));
         return;
     }
-    if (instance()->sessions.count()) {
+    if (instance()->_sessions.count()) {
         qWarning() << qPrintable(tr("Calling restoreState() even though active sessions exist!"));
         return;
     }
@@ -261,49 +266,57 @@ void Core::restoreState()
         quInfo() << "Restoring previous core state...";
         foreach(QVariant v, activeSessions) {
             UserId user = v.value<UserId>();
-            instance()->createSession(user, true);
+            instance()->sessionForUser(user, true);
         }
     }
 }
 
 
 /*** Core Setup ***/
-QString Core::setupCoreForInternalUsage()
+
+QString Core::setup(const QString &adminUser, const QString &adminPassword, const QString &backend, const QVariantMap &setupData)
 {
-    Q_ASSERT(!_storageBackends.isEmpty());
-    QVariantMap setupData;
-    qsrand(QDateTime::currentDateTime().toTime_t());
-    int pass = 0;
-    for (int i = 0; i < 10; i++) {
-        pass *= 10;
-        pass += qrand() % 10;
-    }
-    setupData["AdminUser"] = "AdminUser";
-    setupData["AdminPasswd"] = QString::number(pass);
-    setupData["Backend"] = QString("SQLite"); // mono client currently needs sqlite
-    return setupCore(setupData);
+    return instance()->setupCore(adminUser, adminPassword, backend, setupData);
 }
 
 
-QString Core::setupCore(QVariantMap setupData)
+QString Core::setupCore(const QString &adminUser, const QString &adminPassword, const QString &backend, const QVariantMap &setupData)
 {
-    QString user = setupData.take("AdminUser").toString();
-    QString password = setupData.take("AdminPasswd").toString();
-    if (user.isEmpty() || password.isEmpty()) {
+    if (_configured)
+        return tr("Core is already configured! Not configuring again...");
+
+    if (adminUser.isEmpty() || adminPassword.isEmpty()) {
         return tr("Admin user or password not set.");
     }
-    if (_configured || !(_configured = initStorage(setupData, true))) {
+    if (!(_configured = initStorage(backend, setupData, true))) {
         return tr("Could not setup storage!");
     }
-    CoreSettings s;
-    s.setStorageSettings(setupData);
+
+    saveBackendSettings(backend, setupData);
+
     quInfo() << qPrintable(tr("Creating admin user..."));
-    _storage->addUser(user, password);
+    _storage->addUser(adminUser, adminPassword);
     startListening(); // TODO check when we need this
     return QString();
 }
 
 
+QString Core::setupCoreForInternalUsage()
+{
+    Q_ASSERT(!_storageBackends.isEmpty());
+
+    qsrand(QDateTime::currentDateTime().toTime_t());
+    int pass = 0;
+    for (int i = 0; i < 10; i++) {
+        pass *= 10;
+        pass += qrand() % 10;
+    }
+
+    // mono client currently needs sqlite
+    return setupCore("AdminUser", QString::number(pass), "SQLite", QVariantMap());
+}
+
+
 /*** Storage Handling ***/
 void Core::registerStorageBackends()
 {
@@ -344,7 +357,7 @@ void Core::unregisterStorageBackend(Storage *backend)
 
 // old db settings:
 // "Type" => "sqlite"
-bool Core::initStorage(const QString &backend, QVariantMap settings, bool setup)
+bool Core::initStorage(const QString &backend, const QVariantMap &settings, bool setup)
 {
     _storage = 0;
 
@@ -368,13 +381,10 @@ bool Core::initStorage(const QString &backend, QVariantMap settings, bool setup)
             return false;  // trigger setup process
         if (storage->setup(settings))
             return initStorage(backend, settings, false);
-    // if setup wasn't successfull we mark the backend as unavailable
+    // if initialization wasn't successful, we quit to keep from coming up unconfigured
     case Storage::NotAvailable:
-        qCritical() << "Selected storage backend is not available:" << backend;
-        storage->deleteLater();
-        _storageBackends.remove(backend);
-        storage = 0;
-        return false;
+        qCritical() << "FATAL: Selected storage backend is not available:" << backend;
+        exit(EXIT_FAILURE);
     case Storage::IsReady:
         // delete all other backends
         _storageBackends.remove(backend);
@@ -386,12 +396,6 @@ bool Core::initStorage(const QString &backend, QVariantMap settings, bool setup)
 }
 
 
-bool Core::initStorage(QVariantMap dbSettings, bool setup)
-{
-    return initStorage(dbSettings["Backend"].toString(), dbSettings["ConnectionProperties"].toMap(), setup);
-}
-
-
 void Core::syncStorage()
 {
     if (_storage)
@@ -413,6 +417,17 @@ bool Core::createNetwork(UserId user, NetworkInfo &info)
 
 /*** Network Management ***/
 
+bool Core::sslSupported()
+{
+#ifdef HAVE_SSL
+    SslServer *sslServer = qobject_cast<SslServer *>(&instance()->_server);
+    return sslServer && sslServer->isCertValid();
+#else
+    return false;
+#endif
+}
+
+
 bool Core::startListening()
 {
     // in mono mode we only start a local port if a port is specified in the cli call
@@ -515,173 +530,18 @@ void Core::incomingConnection()
     Q_ASSERT(server);
     while (server->hasPendingConnections()) {
         QTcpSocket *socket = server->nextPendingConnection();
-        connect(socket, SIGNAL(disconnected()), this, SLOT(clientDisconnected()));
-        connect(socket, SIGNAL(readyRead()), this, SLOT(clientHasData()));
-        connect(socket, SIGNAL(error(QAbstractSocket::SocketError)), this, SLOT(socketError(QAbstractSocket::SocketError)));
-
-        QVariantMap clientInfo;
-        blocksizes.insert(socket, (quint32)0);
-        quInfo() << qPrintable(tr("Client connected from"))  << qPrintable(socket->peerAddress().toString());
-
-        if (!_configured) {
-            stopListening(tr("Closing server for basic setup."));
-        }
-    }
-}
 
+        CoreAuthHandler *handler = new CoreAuthHandler(socket, this);
+        _connectingClients.insert(handler);
 
-void Core::clientHasData()
-{
-    QTcpSocket *socket = dynamic_cast<QTcpSocket *>(sender());
-    Q_ASSERT(socket && blocksizes.contains(socket));
-    QVariant item;
-    while (SignalProxy::readDataFromDevice(socket, blocksizes[socket], item)) {
-        QVariantMap msg = item.toMap();
-        processClientMessage(socket, msg);
-        if (!blocksizes.contains(socket)) break;  // this socket is no longer ours to handle!
-    }
-}
-
+        connect(handler, SIGNAL(disconnected()), SLOT(clientDisconnected()));
+        connect(handler, SIGNAL(socketError(QAbstractSocket::SocketError,QString)), SLOT(socketError(QAbstractSocket::SocketError,QString)));
+        connect(handler, SIGNAL(handshakeComplete(RemotePeer*,UserId)), SLOT(setupClientSession(RemotePeer*,UserId)));
 
-void Core::processClientMessage(QTcpSocket *socket, const QVariantMap &msg)
-{
-    if (!msg.contains("MsgType")) {
-        // Client is way too old, does not even use the current init format
-        qWarning() << qPrintable(tr("Antique client trying to connect... refusing."));
-        socket->close();
-        return;
-    }
-    // OK, so we have at least an init message format we can understand
-    if (msg["MsgType"] == "ClientInit") {
-        QVariantMap reply;
-
-        // Just version information -- check it!
-        uint ver = msg["ProtocolVersion"].toUInt();
-        if (ver < Quassel::buildInfo().coreNeedsProtocol) {
-            reply["MsgType"] = "ClientInitReject";
-            reply["Error"] = tr("<b>Your Quassel Client is too old!</b><br>"
-                                "This core needs at least client/core protocol version %1.<br>"
-                                "Please consider upgrading your client.").arg(Quassel::buildInfo().coreNeedsProtocol);
-            SignalProxy::writeDataToDevice(socket, reply);
-            qWarning() << qPrintable(tr("Client")) << qPrintable(socket->peerAddress().toString()) << qPrintable(tr("too old, rejecting."));
-            socket->close(); return;
-        }
-
-        reply["ProtocolVersion"] = Quassel::buildInfo().protocolVersion;
-        reply["CoreVersion"] = Quassel::buildInfo().fancyVersionString;
-        reply["CoreDate"] = Quassel::buildInfo().buildDate;
-        reply["CoreStartTime"] = startTime(); // v10 clients don't necessarily parse this, see below
-
-        // FIXME: newer clients no longer use the hardcoded CoreInfo (for now), since it gets the
-        //        time zone wrong. With the next protocol bump (10 -> 11), we should remove this
-        //        or make it properly configurable.
-
-        int uptime = startTime().secsTo(QDateTime::currentDateTime().toUTC());
-        int updays = uptime / 86400; uptime %= 86400;
-        int uphours = uptime / 3600; uptime %= 3600;
-        int upmins = uptime / 60;
-        reply["CoreInfo"] = tr("<b>Quassel Core Version %1</b><br>"
-                               "Built: %2<br>"
-                               "Up %3d%4h%5m (since %6)").arg(Quassel::buildInfo().fancyVersionString)
-                            .arg(Quassel::buildInfo().buildDate)
-                            .arg(updays).arg(uphours, 2, 10, QChar('0')).arg(upmins, 2, 10, QChar('0')).arg(startTime().toString(Qt::TextDate));
-
-        reply["CoreFeatures"] = (int)Quassel::features();
-
-#ifdef HAVE_SSL
-        SslServer *sslServer = qobject_cast<SslServer *>(&_server);
-        QSslSocket *sslSocket = qobject_cast<QSslSocket *>(socket);
-        bool supportSsl = (bool)sslServer && (bool)sslSocket && sslServer->isCertValid();
-#else
-        bool supportSsl = false;
-#endif
-
-#ifndef QT_NO_COMPRESS
-        bool supportsCompression = true;
-#else
-        bool supportsCompression = false;
-#endif
-
-        reply["SupportSsl"] = supportSsl;
-        reply["SupportsCompression"] = supportsCompression;
-        // switch to ssl/compression after client has been informed about our capabilities (see below)
-
-        reply["LoginEnabled"] = true;
+        quInfo() << qPrintable(tr("Client connected from"))  << qPrintable(socket->peerAddress().toString());
 
-        // check if we are configured, start wizard otherwise
         if (!_configured) {
-            reply["Configured"] = false;
-            QList<QVariant> backends;
-            foreach(Storage *backend, _storageBackends.values()) {
-                QVariantMap v;
-                v["DisplayName"] = backend->displayName();
-                v["Description"] = backend->description();
-                v["SetupKeys"] = backend->setupKeys();
-                v["SetupDefaults"] = backend->setupDefaults();
-                backends.append(v);
-            }
-            reply["StorageBackends"] = backends;
-            reply["LoginEnabled"] = false;
-        }
-        else {
-            reply["Configured"] = true;
-        }
-        clientInfo[socket] = msg; // store for future reference
-        reply["MsgType"] = "ClientInitAck";
-        SignalProxy::writeDataToDevice(socket, reply);
-        socket->flush(); // ensure that the write cache is flushed before we switch to ssl
-
-#ifdef HAVE_SSL
-        // after we told the client that we are ssl capable we switch to ssl mode
-        if (supportSsl && msg["UseSsl"].toBool()) {
-            qDebug() << qPrintable(tr("Starting TLS for Client:"))  << qPrintable(socket->peerAddress().toString());
-            connect(sslSocket, SIGNAL(sslErrors(const QList<QSslError> &)), this, SLOT(sslErrors(const QList<QSslError> &)));
-            sslSocket->startServerEncryption();
-        }
-#endif
-
-#ifndef QT_NO_COMPRESS
-        if (supportsCompression && msg["UseCompression"].toBool()) {
-            socket->setProperty("UseCompression", true);
-            qDebug() << "Using compression for Client:" << qPrintable(socket->peerAddress().toString());
-        }
-#endif
-    }
-    else {
-        // for the rest, we need an initialized connection
-        if (!clientInfo.contains(socket)) {
-            QVariantMap reply;
-            reply["MsgType"] = "ClientLoginReject";
-            reply["Error"] = tr("<b>Client not initialized!</b><br>You need to send an init message before trying to login.");
-            SignalProxy::writeDataToDevice(socket, reply);
-            qWarning() << qPrintable(tr("Client")) << qPrintable(socket->peerAddress().toString()) << qPrintable(tr("did not send an init message before trying to login, rejecting."));
-            socket->close(); return;
-        }
-        if (msg["MsgType"] == "CoreSetupData") {
-            QVariantMap reply;
-            QString result = setupCore(msg["SetupData"].toMap());
-            if (!result.isEmpty()) {
-                reply["MsgType"] = "CoreSetupReject";
-                reply["Error"] = result;
-            }
-            else {
-                reply["MsgType"] = "CoreSetupAck";
-            }
-            SignalProxy::writeDataToDevice(socket, reply);
-        }
-        else if (msg["MsgType"] == "ClientLogin") {
-            QVariantMap reply;
-            UserId uid = _storage->validateUser(msg["User"].toString(), msg["Password"].toString());
-            if (uid == 0) {
-                reply["MsgType"] = "ClientLoginReject";
-                reply["Error"] = tr("<b>Invalid username or password!</b><br>The username/password combination you supplied could not be found in the database.");
-                SignalProxy::writeDataToDevice(socket, reply);
-                return;
-            }
-            reply["MsgType"] = "ClientLoginAck";
-            SignalProxy::writeDataToDevice(socket, reply);
-            quInfo() << qPrintable(tr("Client")) << qPrintable(socket->peerAddress().toString()) << qPrintable(tr("initialized and authenticated successfully as \"%1\" (UserId: %2).").arg(msg["User"].toString()).arg(uid.toInt()));
-            setupClientSession(socket, uid);
+            stopListening(tr("Closing server for basic setup."));
         }
     }
 }
@@ -690,41 +550,12 @@ void Core::processClientMessage(QTcpSocket *socket, const QVariantMap &msg)
 // Potentially called during the initialization phase (before handing the connection off to the session)
 void Core::clientDisconnected()
 {
-    QTcpSocket *socket = qobject_cast<QTcpSocket *>(sender());
-    if (socket) {
-        // here it's safe to call methods on socket!
-        quInfo() << qPrintable(tr("Non-authed client disconnected.")) << qPrintable(socket->peerAddress().toString());
-        blocksizes.remove(socket);
-        clientInfo.remove(socket);
-        socket->deleteLater();
-    }
-    else {
-        // we have to crawl through the hashes and see if we find a victim to remove
-        qDebug() << qPrintable(tr("Non-authed client disconnected. (socket allready destroyed)"));
-
-        // DO NOT CALL ANY METHODS ON socket!!
-        socket = static_cast<QTcpSocket *>(sender());
-
-        QHash<QTcpSocket *, quint32>::iterator blockSizeIter = blocksizes.begin();
-        while (blockSizeIter != blocksizes.end()) {
-            if (blockSizeIter.key() == socket) {
-                blockSizeIter = blocksizes.erase(blockSizeIter);
-            }
-            else {
-                blockSizeIter++;
-            }
-        }
+    CoreAuthHandler *handler = qobject_cast<CoreAuthHandler *>(sender());
+    Q_ASSERT(handler);
 
-        QHash<QTcpSocket *, QVariantMap>::iterator clientInfoIter = clientInfo.begin();
-        while (clientInfoIter != clientInfo.end()) {
-            if (clientInfoIter.key() == socket) {
-                clientInfoIter = clientInfo.erase(clientInfoIter);
-            }
-            else {
-                clientInfoIter++;
-            }
-        }
-    }
+    quInfo() << qPrintable(tr("Non-authed client disconnected:")) << qPrintable(handler->socket()->peerAddress().toString());
+    _connectingClients.remove(handler);
+    handler->deleteLater();
 
     // make server listen again if still not configured
     if (!_configured) {
@@ -736,31 +567,22 @@ void Core::clientDisconnected()
 }
 
 
-void Core::setupClientSession(QTcpSocket *socket, UserId uid)
+void Core::setupClientSession(RemotePeer *peer, UserId uid)
 {
+    CoreAuthHandler *handler = qobject_cast<CoreAuthHandler *>(sender());
+    Q_ASSERT(handler);
+
     // From now on everything is handled by the client session
-    disconnect(socket, 0, this, 0);
-    socket->flush();
-    blocksizes.remove(socket);
-    clientInfo.remove(socket);
+    disconnect(handler, 0, this, 0);
+    _connectingClients.remove(handler);
+    handler->deleteLater();
 
     // Find or create session for validated user
-    SessionThread *session;
-    if (sessions.contains(uid)) {
-        session = sessions[uid];
-    }
-    else {
-        session = createSession(uid);
-        if (!session) {
-            qWarning() << qPrintable(tr("Could not initialize session for client:")) << qPrintable(socket->peerAddress().toString());
-            socket->close();
-            return;
-        }
-    }
+    sessionForUser(uid);
 
     // as we are currently handling an event triggered by incoming data on this socket
     // it is unsafe to directly move the socket to the client thread.
-    QCoreApplication::postEvent(this, new AddClientEvent(socket, uid));
+    QCoreApplication::postEvent(this, new AddClientEvent(peer, uid));
 }
 
 
@@ -768,27 +590,21 @@ void Core::customEvent(QEvent *event)
 {
     if (event->type() == AddClientEventId) {
         AddClientEvent *addClientEvent = static_cast<AddClientEvent *>(event);
-        addClientHelper(addClientEvent->socket, addClientEvent->userId);
+        addClientHelper(addClientEvent->peer, addClientEvent->userId);
         return;
     }
 }
 
 
-void Core::addClientHelper(QTcpSocket *socket, UserId uid)
+void Core::addClientHelper(RemotePeer *peer, UserId uid)
 {
     // Find or create session for validated user
-    if (!sessions.contains(uid)) {
-        qWarning() << qPrintable(tr("Could not find a session for client:")) << qPrintable(socket->peerAddress().toString());
-        socket->close();
-        return;
-    }
-
-    SessionThread *session = sessions[uid];
-    session->addClient(socket);
+    SessionThread *session = sessionForUser(uid);
+    session->addClient(peer);
 }
 
 
-void Core::setupInternalClientSession(SignalProxy *proxy)
+void Core::setupInternalClientSession(InternalPeer *clientPeer)
 {
     if (!_configured) {
         stopListening();
@@ -804,46 +620,46 @@ void Core::setupInternalClientSession(SignalProxy *proxy)
         return;
     }
 
+    InternalPeer *corePeer = new InternalPeer(this);
+    corePeer->setPeer(clientPeer);
+    clientPeer->setPeer(corePeer);
+
     // Find or create session for validated user
-    SessionThread *sess;
-    if (sessions.contains(uid))
-        sess = sessions[uid];
-    else
-        sess = createSession(uid);
-    sess->addClient(proxy);
+    SessionThread *sessionThread = sessionForUser(uid);
+    sessionThread->addClient(corePeer);
 }
 
 
-SessionThread *Core::createSession(UserId uid, bool restore)
+SessionThread *Core::sessionForUser(UserId uid, bool restore)
 {
-    if (sessions.contains(uid)) {
-        qWarning() << "Calling createSession() when a session for the user already exists!";
-        return 0;
-    }
-    SessionThread *sess = new SessionThread(uid, restore, this);
-    sessions[uid] = sess;
-    sess->start();
-    return sess;
+    if (_sessions.contains(uid))
+        return _sessions[uid];
+
+    SessionThread *session = new SessionThread(uid, restore, this);
+    _sessions[uid] = session;
+    session->start();
+    return session;
 }
 
 
-#ifdef HAVE_SSL
-void Core::sslErrors(const QList<QSslError> &errors)
+void Core::socketError(QAbstractSocket::SocketError err, const QString &errorString)
 {
-    Q_UNUSED(errors);
-    QSslSocket *socket = qobject_cast<QSslSocket *>(sender());
-    if (socket)
-        socket->ignoreSslErrors();
+    qWarning() << QString("Socket error %1: %2").arg(err).arg(errorString);
 }
 
 
-#endif
-
-void Core::socketError(QAbstractSocket::SocketError err)
+QVariantList Core::backendInfo()
 {
-    QAbstractSocket *socket = qobject_cast<QAbstractSocket *>(sender());
-    if (socket && err != QAbstractSocket::RemoteHostClosedError)
-        qWarning() << "Core::socketError()" << socket << err << socket->errorString();
+    QVariantList backends;
+    foreach(const Storage *backend, instance()->_storageBackends.values()) {
+        QVariantMap v;
+        v["DisplayName"] = backend->displayName();
+        v["Description"] = backend->description();
+        v["SetupKeys"] = backend->setupKeys();
+        v["SetupDefaults"] = backend->setupDefaults();
+        backends.append(v);
+    }
+    return backends;
 }
 
 
@@ -1092,7 +908,7 @@ QVariantMap Core::promptForSettings(const Storage *storage)
 }
 
 
-#ifdef Q_OS_WIN32
+#ifdef Q_OS_WIN
 void Core::stdInEcho(bool on)
 {
     HANDLE hStdin = GetStdHandle(STD_INPUT_HANDLE);
@@ -1119,4 +935,4 @@ void Core::stdInEcho(bool on)
 }
 
 
-#endif /* Q_OS_WIN32 */
+#endif /* Q_OS_WIN */