modernize: Prefer default member init over ctor init

[quassel.git] / src / common / signalproxy.h

diff --git a/src/common/signalproxy.h b/src/common/signalproxy.h
index f24882c..a948617 100644 (file)
--- a/src/common/signalproxy.h
+++ b/src/common/signalproxy.h
@@ -20,6 +20,8 @@
 
 #pragma once
 
+#include "common-export.h"
+
 #include <QEvent>
 #include <QSet>
 
@@ -34,7 +36,7 @@ class QIODevice;
 class Peer;
 class SyncableObject;
 
-class SignalProxy : public QObject
+class COMMON_EXPORT SignalProxy : public QObject
 {
     Q_OBJECT
 
@@ -52,7 +54,7 @@ public:
 
     SignalProxy(QObject *parent);
     SignalProxy(ProxyMode mode, QObject *parent);
-    virtual ~SignalProxy();
+    ~SignalProxy() override;
 
     void setProxyMode(ProxyMode mode);
     inline ProxyMode proxyMode() const { return _proxyMode; }
@@ -80,9 +82,7 @@ public:
     void dumpProxyStats();
     void dumpSyncMap(SyncableObject *object);
 
-    static SignalProxy *current() {
-        return _current;
-    }
+    static SignalProxy *current();
 
     /**@{*/
     /**
@@ -98,12 +98,10 @@ public:
     }
 
     //A better version, but only implemented on Qt5 if Initializer Lists exist
-#if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
 #ifdef Q_COMPILER_INITIALIZER_LISTS
     void restrictTargetPeers(std::initializer_list<Peer*> peers, std::function<void()> closure) {
         restrictTargetPeers(QSet<Peer*>(peers), std::move(closure));
     }
-#endif
 #endif
     /**}@*/
 
@@ -130,7 +128,7 @@ public slots:
     void detachSlots(QObject *receiver);
 
 protected:
-    void customEvent(QEvent *event);
+    void customEvent(QEvent *event) override;
     void sync_call__(const SyncableObject *obj, ProxyMode modeType, const char *funcname, va_list ap);
     void renameObject(const SyncableObject *obj, const QString &newname, const QString &oldname);
 
@@ -179,8 +177,8 @@ private:
     template<class T>
     void handle(Peer *, T) { Q_ASSERT(0); }
 
-    bool invokeSlot(QObject *receiver, int methodId, const QVariantList &params, QVariant &returnValue, Peer *peer = 0);
-    bool invokeSlot(QObject *receiver, int methodId, const QVariantList &params = QVariantList(), Peer *peer = 0);
+    bool invokeSlot(QObject *receiver, int methodId, const QVariantList &params, QVariant &returnValue, Peer *peer = nullptr);
+    bool invokeSlot(QObject *receiver, int methodId, const QVariantList &params = QVariantList(), Peer *peer = nullptr);
 
     void requestInit(SyncableObject *obj);
     QVariantMap initData(SyncableObject *obj) const;
@@ -197,12 +195,12 @@ private:
     SignalRelay *_signalRelay;
 
     // RPC function -> (object, slot ID)
-    typedef QPair<QObject *, int> MethodId;
-    typedef QMultiHash<QByteArray, MethodId> SlotHash;
+    using MethodId = QPair<QObject *, int>;
+    using SlotHash = QMultiHash<QByteArray, MethodId>;
     SlotHash _attachedSlots;
 
     // slaves for sync
-    typedef QHash<QString, SyncableObject *> ObjectId;
+    using ObjectId = QHash<QString, SyncableObject *>;
     QHash<QByteArray, ObjectId> _syncSlave;
 
     ProxyMode _proxyMode;
@@ -219,8 +217,6 @@ private:
     Peer *_sourcePeer = nullptr;
     Peer *_targetPeer = nullptr;
 
-    thread_local static SignalProxy *_current;
-
     friend class SignalRelay;
     friend class SyncableObject;
     friend class Peer;
@@ -236,7 +232,7 @@ class SignalProxy::ExtendedMetaObject
     {
     public:
         MethodDescriptor(const QMetaMethod &method);
-        MethodDescriptor() : _returnType(-1), _minArgCount(-1), _receiverMode(SignalProxy::Client) {}
+        MethodDescriptor()  {}
 
         inline const QByteArray &methodName() const { return _methodName; }
         inline const QList<int> &argTypes() const { return _argTypes; }
@@ -247,9 +243,9 @@ class SignalProxy::ExtendedMetaObject
     private:
         QByteArray _methodName;
         QList<int> _argTypes;
-        int _returnType;
-        int _minArgCount;
-        SignalProxy::ProxyMode _receiverMode; // Only acceptable as a Sync Call if the receiving SignalProxy is in this mode.
+        int _returnType{-1};
+        int _minArgCount{-1};
+        SignalProxy::ProxyMode _receiverMode{SignalProxy::Client}; // Only acceptable as a Sync Call if the receiving SignalProxy is in this mode.
     };