modernize: Pass arguments by value and move in constructors

[quassel.git] / src / common / message.h

diff --git a/src/common/message.h b/src/common/message.h
index 45a8286..8b16aa0 100644 (file)
--- a/src/common/message.h
+++ b/src/common/message.h
@@ -18,8 +18,9 @@
  *   51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.         *
  ***************************************************************************/
 
-#ifndef MESSAGE_H_
-#define MESSAGE_H_
+#pragma once
+
+#include "common-export.h"
 
 #include <QCoreApplication>
 #include <QDateTime>
@@ -27,7 +28,7 @@
 #include "bufferinfo.h"
 #include "types.h"
 
-class Message
+class COMMON_EXPORT Message
 {
     Q_DECLARE_TR_FUNCTIONS(Message)
 
@@ -67,12 +68,12 @@ public:
     };
     Q_DECLARE_FLAGS(Flags, Flag)
 
-    Message(const BufferInfo &bufferInfo = BufferInfo(), Type type = Plain, const QString &contents = {},
-            const QString &sender = {}, const QString &senderPrefixes = {}, const QString &realName = {},
-            const QString &avatarUrl = {}, Flags flags = None);
-    Message(const QDateTime &ts, const BufferInfo &buffer = BufferInfo(), Type type = Plain,
-            const QString &contents = {}, const QString &sender = {}, const QString &senderPrefixes = {},
-            const QString &realName = {}, const QString &avatarUrl = {}, Flags flags = None);
+    Message(BufferInfo bufferInfo = BufferInfo(), Type type = Plain, QString contents = {},
+            QString sender = {}, QString senderPrefixes = {}, QString realName = {},
+            QString avatarUrl = {}, Flags flags = None);
+    Message(QDateTime ts, BufferInfo buffer = BufferInfo(), Type type = Plain,
+            QString contents = {}, QString sender = {}, QString senderPrefixes = {},
+            QString realName = {}, QString avatarUrl = {}, Flags flags = None);
 
     inline static Message ChangeOfDay(const QDateTime &day) { return Message(day, BufferInfo(), DayChange); }
     inline const MsgId &msgId() const { return _msgId; }
@@ -111,7 +112,7 @@ private:
 };
 
 
-typedef QList<Message> MessageList;
+using MessageList = QList<Message>;
 
 QDataStream &operator<<(QDataStream &out, const Message &msg);
 QDataStream &operator>>(QDataStream &in, Message &msg);
@@ -120,5 +121,3 @@ QDebug operator<<(QDebug dbg, const Message &msg);
 Q_DECLARE_METATYPE(Message)
 Q_DECLARE_OPERATORS_FOR_FLAGS(Message::Types)
 Q_DECLARE_OPERATORS_FOR_FLAGS(Message::Flags)
-
-#endif