Fix regexp that purges illegal chars from nicknames

[quassel.git] / src / common / identity.cpp

diff --git a/src/common/identity.cpp b/src/common/identity.cpp
index aafb1fa..c1858e8 100644 (file)
--- a/src/common/identity.cpp
+++ b/src/common/identity.cpp
@@ -28,6 +28,12 @@
 #  include "mac_utils.h"
 #endif
 
+#ifdef Q_OS_UNIX
+#  include <sys/types.h>
+#  include <pwd.h>
+#  include <unistd.h>
+#endif
+
 #ifdef Q_OS_WIN32
 #  include <windows.h>
 #  include <Winbase.h>
@@ -74,34 +80,55 @@ void Identity::init() {
 }
 
 QString Identity::defaultNick() {
-  QString generalDefault = QString("quassel%1").arg(qrand() & 0xff); // FIXME provide more sensible default nicks
+  QString nick = QString("quassel%1").arg(qrand() & 0xff); // FIXME provide more sensible default nicks
+
 #ifdef Q_OS_MAC
-  return CFStringToQString(CSCopyUserName(true));
+  QString shortUserName = CFStringToQString(CSCopyUserName(true));
+  if(!shortUserName.isEmpty())
+    nick = shortUserName;
+
+#elif defined(Q_OS_UNIX)
+  QString userName = getlogin();
+  if(!userName.isEmpty())
+    nick = userName;
+
 #elif defined(Q_OS_WIN32)
   TCHAR  infoBuf[128];
   DWORD  bufCharCount = 128;
   //if(GetUserNameEx(/* NameSamCompatible */ 1, infoBuf, &bufCharCount))
-  if(!GetUserNameEx(NameSamCompatible, infoBuf, &bufCharCount))
-    return generalDefault;
-
-  QString nickName(infoBuf);
-  int lastBs = nickName.lastIndexOf('\\');
-  if(lastBs != -1) {
-    nickName = nickName.mid(lastBs + 1);
+  if(GetUserNameEx(NameSamCompatible, infoBuf, &bufCharCount)) {
+    QString nickName(infoBuf);
+    int lastBs = nickName.lastIndexOf('\\');
+    if(lastBs != -1) {
+      nickName = nickName.mid(lastBs + 1);
+    }
+    if(!nickName.isEmpty())
+      nick = nickName;
   }
-  if(nickName.isEmpty())
-    return generalDefault;
-  else
-    return nickName;
-#else
-  return generalDefault;
 #endif
+
+  // cleaning forbidden characters from nick
+  QRegExp rx(QString("(^[\\d-]+|[^A-Za-z0-9\x5b-\x60\x7b-\x7d])"));
+  nick.remove(rx);
+  return nick;
 }
 
 QString Identity::defaultRealName() {
   QString generalDefault = tr("Quassel IRC User");
+
 #ifdef Q_OS_MAC
   return CFStringToQString(CSCopyUserName(false));
+
+#elif defined(Q_OS_UNIX)
+  QString realName;
+  struct passwd *pwd = getpwuid(getuid());
+  if(pwd)
+    realName = pwd->pw_gecos;
+  if(!realName.isEmpty())
+    return realName;
+  else
+    return generalDefault;
+
 #elif defined(Q_OS_WIN32)
   TCHAR  infoBuf[128];
   DWORD  bufCharCount = 128;
@@ -118,7 +145,7 @@ void Identity::setToDefaults() {
   setIdentityName(tr("<empty>"));
   setRealName(defaultRealName());
   QStringList n;
-  n << defaultNick();
+  n << defaultNick() << defaultNick() + "_" << defaultNick() + "__";
   setNicks(n);
   setAwayNick("");
   setAwayNickEnabled(false);