src: Yearly copyright bump This time on time!
src: Yearly copyright bump Let's welcome 2020.
common: Always let QVariant::fromValue() deduce the type In some places, we would explicitly give the type to QVariant::fromValue(), forgoing automatic type deduction. This is almost always redundant, and in the cases where it is not, the input type should be explicitly cast. Additionally, the implementation of QVariant::fromValue() subtly changed in Qt 5.14, leading to compile errors when giving a non-decayed type (as we did in SignalProxy::attachSignal()).
Replace deprecated additionalFormats with formats
src: Yearly copyright bump ... and it's still January!
modernize: Reformat ALL the source... again! It's been more than six years since we last used an autoformatter on the codebase. Tooling has progressed, so has the language and of course our personal preferences. Use clang-format this time to reformat the whole codebase, following the rules laid out in .clang-format (which one can use for configuring an IDE, too, if it supports autoformatting). Overall, the new style is not too different from what we used before, with one significant change: We now attach pointer/reference indicators (*&) to the type rather than the name, i.e. we left-align. While this is a major deviation from the Qt style which we use for almost everything else, it aligns more closely with many other projects, as well as the C++ documentation and STL. It also makes more sense semantically, because */& are really part of the type. Other changes include (but are not limited to): - Use only one blank line between function definitions - Categorize includes from generic/system to local, sorting each category alphabetically. The generic-to-local sort order seems to be more common than the other way round, so we use that. - In .cpp files, the corresponding header is always included first. This is a general recommendation, because it makes it harder to accidentally introduce a reliance on transitive includes in headers. - Consistently break initializers in ctors before the comma, so the commas are left-aligned together with the colon. - Use two spaces between code and trailing comments. Note that sometimes even clang-format gets things wrong. In a few places, formatting was manually fixed; however, reviewing a diff of almost 80k lines is a rather boring task, so we didn't thoroughly go through all the changes. Wrong formatting can always be fixed in follow-up commits, anyway. Note also that we don't intend to re-run clang-format on a regular basis, nor do we want to religiously follow a hardcoded set of rules for new code in the future. Where it makes sense, the rules may be bent in favor of better readability or more pleasing code.
modernize: Use auto where the type is clear from context Apply clang-tidy's modernize-use-auto fix, which uses auto where the type would otherwise be duplicated in the line (e.g. when casting a type, or creating an instance with 'new').
modernize: Use 'using' instead of 'typedef'
Change Message::Flags/Type cast to Int, not UInt Use toInt() for casting `Message::Flags` and `Message::Type`, instead of toUint(). MSVC has trouble with uint-based enums, so Quassel switched to int enums. However, not all of the enum casts were converted, resulting in needless unsigned-to-signed casting. Thanks to @justJanne for reporting this.
Semi-yearly copyright bump It's no longer 2016.
uistyle: Support extended mIRC colors Support mIRC color values between 16 and 98, as specified in [1]. Extended color values are not styleable. [1] https://modern.ircdocs.horse/formatting.html
uistyle: Add more type-safety to UiStyle, and clean up a bit Migrate all UiStyle enums to be enum classes. Enforce explicit types instead of quint32 in most places using them, and handle MessageLabel in a more obvious fashion. A bunch of bit-wise operators had to be added to avoid lots of boilerplate when dealing with the enums. FormatList now holds the formats in a struct rather than as plain enum (or quint32) values. This will be needed for extended color support; as the format type cannot hold the hard-coded extended color values, the colors will be stored explicitly in the list and applied as appropriate. Also, in the quest to modernize the codebase, FormatList is now a std::vector rather than a QList.
Detect and label changes from ourself On the core, detect when changes apply to our own nick and flag the message as Self. On the client, work around old nick change messages lacking the Self flag. Working around the other messages would be more difficult. This fixes nick change styling not correctly applying for "sender=self" in themes.
Bring copyright headers into 2016 That took some time...
Happy New Year!
Happy New Year!
Yearly bump It's 2013, baby!
Fix ALL the license headers! Many of our license headers had the wrong date, some of them inconsistent formatting, all of them the wrong address for the FSF (which apparently moved since 2005), and also neither the GNU Blank Public License nor the GNU Highlight Public License actually exist.
Reformat ALL the source! Yes, yes. After stubborningly refusing to switch to a more readable coding style for years, I finally give in. Our old, quite compact, 2-indent style was born from my time with homecomputers, where every whitespace was a waste. Later (and mostly thanks to EgS), I did see the light, e.g. changed from one-letter variable names to useful ones, but still shied away from reformatting the whole source, touching every line, destroying the historical context as shown by svn and git blame. However, since I'm now doing Qt-related programming as my day job, and use a proper (Qt-like) coding style there, it has become increasingly annoying for myself to switch to another style in those long hacking nights working on Quassel, and so I decided to Just Do It™. Helps that Git nowadays can ignore whitespace changes when blaming, or diffing, or patching, so this shouldn't be too much of an annoyance for existing patches. Feedback from the community was also positive... So now we use a style that should be pretty close to the Qt Coding Style [1], which not only covers the indentation, but also things like newline-after-function-head. Reformatting was done automagically using uncrustify [2], a script and config file is in scripts/manage/. Please don't run it over the whole codebase again, as there are some false positives and weird formattings that will have to be manually fixed over time. You can use it for reformatting existing patches or MRs, though. [1] http://qt-project.org/wiki/Qt_Coding_Style [2] http://uncrustify.sourceforge.net/
bump © years