From: Shane Synan <digitalcircuit36939@gmail.com>
Date: Wed, 29 Jun 2016 21:26:56 +0000 (-0400)
Subject: Sort IRCv3 capabilities before negotiation
X-Git-Tag: travis-deploy-test~420
X-Git-Url: https://git.quassel-irc.org/?a=commitdiff_plain;h=156f88b0a12dd2fb65a78c3ce088ce6ba57feafe;p=quassel.git

Sort IRCv3 capabilities before negotiation

Sort capabilities before requesting for consistency among networks.
This may avoid unexpected cases when some networks offer capabilities
in a different order than others.  It also looks nicer in logs.
---

diff --git a/src/core/coresessioneventprocessor.cpp b/src/core/coresessioneventprocessor.cpp
index fa5fc361..ee66717e 100644
--- a/src/core/coresessioneventprocessor.cpp
+++ b/src/core/coresessioneventprocessor.cpp
@@ -174,6 +174,10 @@ void CoreSessionEventProcessor::processIrcEventCap(IrcEvent *e)
                 capListFinished = true;
                 availableCaps = e->params().at(2).split(' ');
             }
+            // Sort capabilities before requesting for consistency among networks.  This may avoid
+            // unexpected cases when some networks offer capabilities in a different order than
+            // others.  It also looks nicer in logs.  Not required.
+            availableCaps.sort();
             // Store what capabilities are available
             QString availableCapName, availableCapValue;
             for (int i = 0; i < availableCaps.count(); ++i) {