From: Petr Bena <benapetr@gmail.com>
Date: Wed, 23 Sep 2015 14:07:16 +0000 (+0200)
Subject: Performance tweak: rem. pointless recursive calls
X-Git-Tag: 0.12.3~28
X-Git-Url: https://git.quassel-irc.org/?a=commitdiff_plain;ds=sidebyside;h=e56629542168c203cac8504085fc96c7f7b73d90;hp=e56629542168c203cac8504085fc96c7f7b73d90;p=quassel.git

Performance tweak: rem. pointless recursive calls

For some reason there was an extra call to IrcChannel::joinIrcUser
from IrcUser::joinIrcChannel. That means that in past we did:

* Call to                         IrcChannel::joinIrcUsers(...)
* From there we call              IrcUser::joinIrcChannel(this)
* And from there we called        IrcChannel::joinIrcUser(this)
* Which again called              IrcChannel::joinIrcUsers(list that contained only this 1 user)
* Which figured out this user is already in this channel and exits

That is a pointless overhead, so now we call the second function with
extra parameter that tells it not to call joinIrcUser because we know
this user doesn't need to be added there, thus saves few thousands of
pointless function calls and user list contructions, especially while
joining large channels.
---