projects / quassel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 8a0b44b) | patch
Properly handle QGenericReturnArgument
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 27 Mar 2012 20:04:03 +0000 (22:04 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 1 Apr 2012 21:07:53 +0000 (23:07 +0200)
commit565743a41c93de874cb79fd145b22e2422bb754e
treedbbec69b45c3cf8854ac1af0f86a71b01abf0e1btree | snapshot
parent8a0b44b52a6a0a855a832fa7b46f3631a8684a3fcommit | diff
Properly handle QGenericReturnArgument

Using the memory address of the QVariant that acts as buffer is bad. While we got
lucky with Qt4, and this worked by accident, it leads to subtle and not-so-subtle segfaults
when used with Qt5.

Instead, using QVariant::data() makes sure that implicitly shared data is properly detached.
src/common/syncableobject.cpp diff | blob | history
Quassel IRC