X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fuisupport%2Fbufferview.cpp;h=c11c6adf07ecc0d69fdb15e3e376a1cc439f6416;hb=281fa0205429c4b2731a4a76561386f2cc6448de;hp=e3206018ec90574c9d90462025dd036342e1950a;hpb=4fdf00a414eba03fb95cade3aca3ba53705c7b97;p=quassel.git

diff --git a/src/uisupport/bufferview.cpp b/src/uisupport/bufferview.cpp
index e3206018..c11c6adf 100644
--- a/src/uisupport/bufferview.cpp
+++ b/src/uisupport/bufferview.cpp
@@ -54,7 +54,8 @@ BufferView::BufferView(QWidget *parent)
 
     _joinBufferAction(tr("Join"), this),
     _partBufferAction(tr("Part"), this),
-    _hideBufferAction(tr("Hide selected buffers"), this),
+    _hideBufferTemporarilyAction(tr("Hide buffers"), this),
+    _hideBufferPermanentlyAction(tr("Hide buffers permanently"), this),
     _removeBufferAction(tr("Delete buffer"), this),
     _ignoreListAction(tr("Ignore list"), this),
 
@@ -158,8 +159,6 @@ void BufferView::setFilteredModel(QAbstractItemModel *model_, BufferViewConfig *
   } else {
     BufferViewFilter *filter = new BufferViewFilter(model_, config);
     setModel(filter);
-    connect(this, SIGNAL(removeBuffer(const QModelIndex &)),
-	    filter, SLOT(removeBuffer(const QModelIndex &)));
   }
   setConfig(config);
 }
@@ -227,13 +226,26 @@ void BufferView::keyPressEvent(QKeyEvent *event) {
   QTreeView::keyPressEvent(event);
 }
 
-void BufferView::removeSelectedBuffers() {
-  QSet<int> removedRows;
+void BufferView::removeSelectedBuffers(bool permanently) {
+  if(!config())
+    return;
+
+  BufferId bufferId;
+  QSet<BufferId> removedRows;
   foreach(QModelIndex index, selectionModel()->selectedIndexes()) {
-    if(index.data(NetworkModel::ItemTypeRole) == NetworkModel::BufferItemType && !removedRows.contains(index.row())) {
-      removedRows << index.row();
-      emit removeBuffer(index);
-    }
+    if(index.data(NetworkModel::ItemTypeRole) != NetworkModel::BufferItemType)
+      continue;
+
+    bufferId = index.data(NetworkModel::BufferIdRole).value<BufferId>();
+    if(removedRows.contains(bufferId))
+      continue;
+
+    removedRows << bufferId;
+    
+    if(permanently)
+      config()->requestRemoveBufferPermanently(bufferId);
+    else
+      config()->requestRemoveBuffer(bufferId);
   }
 }
 
@@ -303,7 +315,7 @@ void BufferView::toggleHeader(bool checked) {
   header()->setSectionHidden((action->property("column")).toInt(), !checked);
 }
 
-bool BufferView::checkRequirements(const QModelIndex &index, itemActiveStates requiredActiveState) {
+bool BufferView::checkRequirements(const QModelIndex &index, ItemActiveStates requiredActiveState) {
   if(!index.isValid())
     return false;
 
@@ -311,9 +323,9 @@ bool BufferView::checkRequirements(const QModelIndex &index, itemActiveStates re
 //   if(!(itemType & validItemTypes))
 //     return false;
 
-  itemActiveStates isActive = index.data(NetworkModel::ItemActiveRole).toBool()
-    ? activeState
-    : inactiveState;
+  ItemActiveStates isActive = index.data(NetworkModel::ItemActiveRole).toBool()
+    ? ActiveState
+    : InactiveState;
 
   if(!(isActive & requiredActiveState))
     return false;
@@ -321,7 +333,7 @@ bool BufferView::checkRequirements(const QModelIndex &index, itemActiveStates re
   return true;
 }
 
-void BufferView::addItemToMenu(QAction &action, QMenu &menu, const QModelIndex &index, itemActiveStates requiredActiveState) {
+void BufferView::addItemToMenu(QAction &action, QMenu &menu, const QModelIndex &index, ItemActiveStates requiredActiveState) {
   if(checkRequirements(index, requiredActiveState)) {
     menu.addAction(&action);
     action.setVisible(true);
@@ -340,7 +352,7 @@ void BufferView::addItemToMenu(QAction &action, QMenu &menu, bool condition) {
 }
 
 
-void BufferView::addItemToMenu(QMenu &subMenu, QMenu &menu, const QModelIndex &index, itemActiveStates requiredActiveState) {
+void BufferView::addItemToMenu(QMenu &subMenu, QMenu &menu, const QModelIndex &index, ItemActiveStates requiredActiveState) {
   if(checkRequirements(index, requiredActiveState)) {
     menu.addMenu(&subMenu);
     subMenu.setVisible(true);
@@ -349,7 +361,7 @@ void BufferView::addItemToMenu(QMenu &subMenu, QMenu &menu, const QModelIndex &i
   }
 }
 
-void BufferView::addSeparatorToMenu(QMenu &menu, const QModelIndex &index, itemActiveStates requiredActiveState) {
+void BufferView::addSeparatorToMenu(QMenu &menu, const QModelIndex &index, ItemActiveStates requiredActiveState) {
   if(checkRequirements(index, requiredActiveState)) {
     menu.addSeparator();
   }
@@ -393,30 +405,33 @@ void BufferView::contextMenuEvent(QContextMenuEvent *event) {
   case NetworkModel::NetworkItemType:
     _disconnectNetAction.setIcon(connectionStateIcon);
     _connectNetAction.setIcon(connectionStateIcon);
-    addItemToMenu(_disconnectNetAction, contextMenu, index, activeState);
-    addItemToMenu(_connectNetAction, contextMenu, index, inactiveState);
-    addSeparatorToMenu(contextMenu, index, activeState);
-    addItemToMenu(_joinChannelAction, contextMenu, index, activeState);
+    addItemToMenu(_disconnectNetAction, contextMenu, index, ActiveState);
+    addItemToMenu(_connectNetAction, contextMenu, index, InactiveState);
+    addSeparatorToMenu(contextMenu, index, ActiveState);
+    addItemToMenu(_joinChannelAction, contextMenu, index, ActiveState);
     break;
   case NetworkModel::BufferItemType:
     {
       BufferInfo bufferInfo = index.data(NetworkModel::BufferInfoRole).value<BufferInfo>();
       switch(bufferInfo.type()) {
       case BufferInfo::ChannelBuffer:
-	addItemToMenu(_joinBufferAction, contextMenu, index, inactiveState);
-	addItemToMenu(_partBufferAction, contextMenu, index, activeState);
-	addItemToMenu(_hideBufferAction, contextMenu, (bool)config());
-	addItemToMenu(_removeBufferAction, contextMenu, index, inactiveState);
+	addItemToMenu(_joinBufferAction, contextMenu, index, InactiveState);
+	addItemToMenu(_partBufferAction, contextMenu, index, ActiveState);
+	addItemToMenu(_hideBufferTemporarilyAction, contextMenu, (bool)config());
+	addItemToMenu(_hideBufferPermanentlyAction, contextMenu, (bool)config());
+	addItemToMenu(_removeBufferAction, contextMenu, index, InactiveState);
 	createHideEventsSubMenu(contextMenu);
 	addItemToMenu(_ignoreListAction, contextMenu);
 	break;
       case BufferInfo::QueryBuffer:
-	addItemToMenu(_hideBufferAction, contextMenu, (bool)config());
+	addItemToMenu(_hideBufferTemporarilyAction, contextMenu, (bool)config());
+	addItemToMenu(_hideBufferPermanentlyAction, contextMenu, (bool)config());
 	addItemToMenu(_removeBufferAction, contextMenu);
 	createHideEventsSubMenu(contextMenu);
 	break;
       default:
-	addItemToMenu(_hideBufferAction, contextMenu, (bool)config());
+	addItemToMenu(_hideBufferTemporarilyAction, contextMenu, (bool)config());
+	addItemToMenu(_hideBufferPermanentlyAction, contextMenu, (bool)config());
 	break;
       }
     }
@@ -463,15 +478,20 @@ void BufferView::contextMenuEvent(QContextMenuEvent *event) {
 
   if(result == &_partBufferAction) {
     BufferInfo bufferInfo = index.data(NetworkModel::BufferInfoRole).value<BufferInfo>();
-    Client::instance()->userInput(bufferInfo, QString("/PART %1").arg(bufferInfo.bufferName()));
+    Client::instance()->userInput(bufferInfo, QString("/PART"));
     return;
   }
   
-  if(result == &_hideBufferAction) {
+  if(result == &_hideBufferTemporarilyAction) {
     removeSelectedBuffers();
     return;
   }
 
+  if(result == &_hideBufferPermanentlyAction) {
+    removeSelectedBuffers(true);
+    return;
+  }
+
   if(result == &_removeBufferAction) {
     BufferInfo bufferInfo = index.data(NetworkModel::BufferInfoRole).value<BufferInfo>();
     int res = QMessageBox::question(this, tr("Remove buffer permanently?"),