X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fqtui%2Finputwidget.cpp;h=f93c7d963a3f66e8db2350e61c4d1547e2982e0b;hb=42ab7cc22c4702716db2b8bfa1d4545169f772e6;hp=8d84233d471c83d37e8477aaf621a5e159647ada;hpb=b7447afe8e836376776dac26704e227a678d2913;p=quassel.git

diff --git a/src/qtui/inputwidget.cpp b/src/qtui/inputwidget.cpp
index 8d84233d..f93c7d96 100644
--- a/src/qtui/inputwidget.cpp
+++ b/src/qtui/inputwidget.cpp
@@ -91,22 +91,22 @@ InputWidget::InputWidget(QWidget *parent)
     ui.textcolorButton->setMenu(_colorMenu);
     // Set the default action to clear color (last added action)
     ui.textcolorButton->setDefaultAction(_colorMenu->actions().last());
-    connect(_colorMenu, SIGNAL(triggered(QAction *)), this, SLOT(colorChosen(QAction *)));
+    connect(_colorMenu, &QMenu::triggered, this, &InputWidget::colorChosen);
 
     ui.highlightcolorButton->setMenu(_colorFillMenu);
     // Set the default action to clear fill color (last added action)
     ui.highlightcolorButton->setDefaultAction(_colorFillMenu->actions().last());
-    connect(_colorFillMenu, SIGNAL(triggered(QAction *)), this, SLOT(colorHighlightChosen(QAction *)));
+    connect(_colorFillMenu, &QMenu::triggered, this, &InputWidget::colorHighlightChosen);
 
     // Needs to be done after adding the menu, otherwise the icon mysteriously vanishes until clicked
     ui.textcolorButton->setIcon(icon::get("format-text-color"));
     ui.highlightcolorButton->setIcon(icon::get("format-fill-color"));
 
     // Show/hide style button
-    connect(ui.showStyleButton, SIGNAL(toggled(bool)), this, SLOT(setStyleOptionsExpanded(bool)));
+    connect(ui.showStyleButton, &QAbstractButton::toggled, this, &InputWidget::setStyleOptionsExpanded);
 
     // Clear formatting button
-    connect(ui.clearButton, SIGNAL(clicked()), this, SLOT(clearFormat()));
+    connect(ui.clearButton, &QAbstractButton::clicked, this, &InputWidget::clearFormat);
 
     new TabCompleter(ui.inputEdit);
 
@@ -118,11 +118,6 @@ InputWidget::InputWidget(QWidget *parent)
 
     UiSettings s("InputWidget");
 
-#ifdef HAVE_KDE4
-    s.notify("EnableSpellCheck", this, SLOT(setEnableSpellCheck(QVariant)));
-    setEnableSpellCheck(s.value("EnableSpellCheck", false));
-#endif
-
     s.notify("EnableEmacsMode", this, SLOT(setEnableEmacsMode(QVariant)));
     setEnableEmacsMode(s.value("EnableEmacsMode", false));
 
@@ -149,18 +144,13 @@ InputWidget::InputWidget(QWidget *parent)
 
     ActionCollection *coll = QtUi::actionCollection();
 
-    Action *activateInputline = coll->add<Action>("FocusInputLine");
+    auto *activateInputline = coll->add<Action>("FocusInputLine");
     connect(activateInputline, SIGNAL(triggered()), SLOT(setFocus()));
     activateInputline->setText(tr("Focus Input Line"));
     activateInputline->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_L));
 
-    connect(inputLine(), SIGNAL(textEntered(QString)), SLOT(onTextEntered(QString)), Qt::QueuedConnection); // make sure the line is already reset, bug #984
-    connect(inputLine(), SIGNAL(currentCharFormatChanged(QTextCharFormat)), this, SLOT(currentCharFormatChanged(QTextCharFormat)));
-}
-
-
-InputWidget::~InputWidget()
-{
+    connect(inputLine(), &MultiLineEdit::textEntered, this, &InputWidget::onTextEntered, Qt::QueuedConnection); // make sure the line is already reset, bug #984
+    connect(inputLine(), &QTextEdit::currentCharFormatChanged, this, &InputWidget::currentCharFormatChanged);
 }
 
 
@@ -189,12 +179,6 @@ void InputWidget::setCustomFont(const QVariant &v)
 }
 
 
-void InputWidget::setEnableSpellCheck(const QVariant &v)
-{
-    ui.inputEdit->setSpellCheckEnabled(v.toBool());
-}
-
-
 void InputWidget::setEnableEmacsMode(const QVariant &v)
 {
     ui.inputEdit->setEmacsMode(v.toBool());
@@ -248,10 +232,10 @@ bool InputWidget::eventFilter(QObject *watched, QEvent *event)
     if (event->type() != QEvent::KeyPress)
         return false;
 
-    QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);
+    auto *keyEvent = static_cast<QKeyEvent *>(event);
 
     // keys from BufferView should be sent to (and focus) the input line
-    BufferView *view = qobject_cast<BufferView *>(watched);
+    auto *view = qobject_cast<BufferView *>(watched);
     if (view) {
         if (keyEvent->text().length() == 1 && !(keyEvent->modifiers() & (Qt::ControlModifier ^ Qt::AltModifier))) { // normal key press
             QChar c = keyEvent->text().at(0);
@@ -320,11 +304,11 @@ void InputWidget::dataChanged(const QModelIndex &topLeft, const QModelIndex &bot
 
         bool encrypted = false;
 
-        IrcChannel *chan = qobject_cast<IrcChannel *>(Client::bufferModel()->data(selectionModel()->currentIndex(), NetworkModel::IrcChannelRole).value<QObject *>());
+        auto *chan = qobject_cast<IrcChannel *>(Client::bufferModel()->data(selectionModel()->currentIndex(), NetworkModel::IrcChannelRole).value<QObject *>());
         if (chan)
             encrypted = chan->encrypted();
 
-        IrcUser *user = qobject_cast<IrcUser *>(Client::bufferModel()->data(selectionModel()->currentIndex(), NetworkModel::IrcUserRole).value<QObject *>());
+        auto *user = qobject_cast<IrcUser *>(Client::bufferModel()->data(selectionModel()->currentIndex(), NetworkModel::IrcUserRole).value<QObject *>());
         if (user)
             encrypted = user->encrypted();
 
@@ -385,7 +369,7 @@ const Network *InputWidget::currentNetwork() const
 BufferInfo InputWidget::currentBufferInfo() const
 {
     return selectionModel()->currentIndex().data(NetworkModel::BufferInfoRole).value<BufferInfo>();
-};
+}
 
 
 void InputWidget::applyFormatActiveColor()
@@ -438,16 +422,16 @@ void InputWidget::setNetwork(NetworkId networkId)
 
     const Network *previousNet = Client::network(_networkId);
     if (previousNet) {
-        disconnect(previousNet, 0, this, 0);
+        disconnect(previousNet, nullptr, this, nullptr);
         if (previousNet->me())
-            disconnect(previousNet->me(), 0, this, 0);
+            disconnect(previousNet->me(), nullptr, this, nullptr);
     }
 
     _networkId = networkId;
 
     const Network *network = Client::network(networkId);
     if (network) {
-        connect(network, SIGNAL(identitySet(IdentityId)), this, SLOT(setIdentity(IdentityId)));
+        connect(network, &Network::identitySet, this, &InputWidget::setIdentity);
         connectMyIrcUser();
         setIdentity(network->identity());
     }
@@ -462,16 +446,16 @@ void InputWidget::connectMyIrcUser()
 {
     const Network *network = currentNetwork();
     if (network->me()) {
-        connect(network->me(), SIGNAL(nickSet(const QString &)), this, SLOT(updateNickSelector()));
-        connect(network->me(), SIGNAL(userModesSet(QString)), this, SLOT(updateNickSelector()));
-        connect(network->me(), SIGNAL(userModesAdded(QString)), this, SLOT(updateNickSelector()));
-        connect(network->me(), SIGNAL(userModesRemoved(QString)), this, SLOT(updateNickSelector()));
-        connect(network->me(), SIGNAL(awaySet(bool)), this, SLOT(updateNickSelector()));
-        disconnect(network, SIGNAL(myNickSet(const QString &)), this, SLOT(connectMyIrcUser()));
+        connect(network->me(), &IrcUser::nickSet, this, &InputWidget::updateNickSelector);
+        connect(network->me(), &IrcUser::userModesSet, this, &InputWidget::updateNickSelector);
+        connect(network->me(), &IrcUser::userModesAdded, this, &InputWidget::updateNickSelector);
+        connect(network->me(), &IrcUser::userModesRemoved, this, &InputWidget::updateNickSelector);
+        connect(network->me(), &IrcUser::awaySet, this, &InputWidget::updateNickSelector);
+        disconnect(network, &Network::myNickSet, this, &InputWidget::connectMyIrcUser);
         updateNickSelector();
     }
     else {
-        connect(network, SIGNAL(myNickSet(const QString &)), this, SLOT(connectMyIrcUser()));
+        connect(network, &Network::myNickSet, this, &InputWidget::connectMyIrcUser);
     }
 }
 
@@ -483,13 +467,13 @@ void InputWidget::setIdentity(IdentityId identityId)
 
     const Identity *previousIdentity = Client::identity(_identityId);
     if (previousIdentity)
-        disconnect(previousIdentity, 0, this, 0);
+        disconnect(previousIdentity, nullptr, this, nullptr);
 
     _identityId = identityId;
 
     const Identity *identity = Client::identity(identityId);
     if (identity) {
-        connect(identity, SIGNAL(nicksSet(QStringList)), this, SLOT(updateNickSelector()));
+        connect(identity, &Identity::nicksSet, this, &InputWidget::updateNickSelector);
     }
     else {
         _identityId = 0;
@@ -554,16 +538,16 @@ void InputWidget::changeNick(const QString &newNick) const
 void InputWidget::onTextEntered(const QString &text)
 {
     Client::userInput(currentBufferInfo(), text);
-    ui.boldButton->setChecked(false);
-    ui.underlineButton->setChecked(false);
-    ui.italicButton->setChecked(false);
 
+    // Remove formatting from entered text
+    // TODO: Offer a way to convert pasted text to mIRC formatting codes
     setFormatClear(true);
 }
 
 
 void InputWidget::setFormatClear(const bool global)
 {
+    // Apply formatting
     QTextCharFormat fmt;
     fmt.setFontWeight(QFont::Normal);
     fmt.setFontUnderline(false);
@@ -575,30 +559,44 @@ void InputWidget::setFormatClear(const bool global)
     } else {
         setFormatOnSelection(fmt);
     }
+
+    // Make sure UI state follows
+    ui.boldButton->setChecked(false);
+    ui.italicButton->setChecked(false);
+    ui.underlineButton->setChecked(false);
 }
 
 
 void InputWidget::setFormatBold(const bool bold)
 {
+    // Apply formatting
     QTextCharFormat fmt;
     fmt.setFontWeight(bold ? QFont::Bold : QFont::Normal);
     mergeFormatOnSelection(fmt);
+    // Make sure UI state follows
+    ui.boldButton->setChecked(bold);
 }
 
 
 void InputWidget::setFormatItalic(const bool italic)
 {
+    // Apply formatting
     QTextCharFormat fmt;
     fmt.setFontItalic(italic);
     mergeFormatOnSelection(fmt);
+    // Make sure UI state follows
+    ui.italicButton->setChecked(italic);
 }
 
 
 void InputWidget::setFormatUnderline(const bool underline)
 {
+    // Apply formatting
     QTextCharFormat fmt;
     fmt.setFontUnderline(underline);
     mergeFormatOnSelection(fmt);
+    // Make sure UI state follows
+    ui.underlineButton->setChecked(underline);
 }