X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fcore%2Fcoresession.cpp;h=603d291ff7096c7366fc87076379fbe4d74cc00e;hb=da885f3c8e152e9bdf573290adcf53bed58d95d1;hp=52cab60b78f0b16c7da9e2e2c81dc5c94258cdec;hpb=0afd913a5fa29fa44f6119df86aa7574b3274e51;p=quassel.git diff --git a/src/core/coresession.cpp b/src/core/coresession.cpp index 52cab60b..603d291f 100644 --- a/src/core/coresession.cpp +++ b/src/core/coresession.cpp @@ -34,7 +34,9 @@ #include "corenetworkconfig.h" #include "coresessioneventprocessor.h" #include "coreusersettings.h" +#include "ctcpparser.h" #include "eventmanager.h" +#include "eventstringifier.h" #include "ircchannel.h" #include "ircparser.h" #include "ircuser.h" @@ -61,7 +63,9 @@ CoreSession::CoreSession(UserId uid, bool restoreState, QObject *parent) _networkConfig(new CoreNetworkConfig("GlobalNetworkConfig", this)), _coreInfo(this), _eventManager(new EventManager(this)), - _eventProcessor(new CoreSessionEventProcessor(this)), + _eventStringifier(new EventStringifier(this)), + _sessionEventProcessor(new CoreSessionEventProcessor(this)), + _ctcpParser(new CtcpParser(this)), _ircParser(new IrcParser(this)), scriptEngine(new QScriptEngine(this)), _processMessages(false), @@ -93,9 +97,14 @@ CoreSession::CoreSession(UserId uid, bool restoreState, QObject *parent) loadSettings(); initScriptEngine(); - eventManager()->registerObject(ircParser(), EventManager::NormalPriority, "process"); - eventManager()->registerObject(eventProcessor(), EventManager::HighPriority, "process"); - eventManager()->registerObject(this, EventManager::LowPriority, "process"); // for sending MessageEvents to the client + eventManager()->registerObject(ircParser(), EventManager::NormalPriority); + eventManager()->registerObject(sessionEventProcessor(), EventManager::HighPriority); // needs to process events *before* the stringifier! + eventManager()->registerObject(ctcpParser(), EventManager::NormalPriority); + eventManager()->registerObject(eventStringifier(), EventManager::NormalPriority); + eventManager()->registerObject(this, EventManager::LowPriority); // for sending MessageEvents to the client + // some events need to be handled after msg generation + eventManager()->registerObject(sessionEventProcessor(), EventManager::LowPriority, "lateProcess"); + eventManager()->registerObject(ctcpParser(), EventManager::LowPriority, "send"); // periodically save our session state connect(&(Core::instance()->syncTimer()), SIGNAL(timeout()), this, SLOT(saveSessionState())); @@ -251,8 +260,11 @@ void CoreSession::recvStatusMsgFromServer(QString msg) { } void CoreSession::processMessageEvent(MessageEvent *event) { - recvMessageFromServer(event->networkId(), event->msgType(), event->bufferType(), event->target(), - event->text(), event->sender(), event->msgFlags()); + recvMessageFromServer(event->networkId(), event->msgType(), event->bufferType(), + event->target().isNull()? "" : event->target(), + event->text().isNull()? "" : event->text(), + event->sender().isNull()? "" : event->sender(), + event->msgFlags()); } QList CoreSession::buffers() const { @@ -393,7 +405,7 @@ void CoreSession::createIdentity(const Identity &identity, const QVariantMap &ad void CoreSession::createIdentity(const CoreIdentity &identity) { CoreIdentity *coreIdentity = new CoreIdentity(identity, this); _identities[identity.id()] = coreIdentity; - // CoreIdentity has it's own synchronize method since it's "private" sslManager needs to be synced aswell + // CoreIdentity has its own synchronize method since its "private" sslManager needs to be synced as well coreIdentity->synchronize(signalProxy()); connect(coreIdentity, SIGNAL(updated()), this, SLOT(updateIdentityBySender())); emit identityCreated(*coreIdentity); @@ -449,6 +461,7 @@ void CoreSession::createNetwork(const NetworkInfo &info_, const QStringList &per connect(net, SIGNAL(displayMsg(NetworkId, Message::Type, BufferInfo::Type, const QString &, const QString &, const QString &, Message::Flags)), SLOT(recvMessageFromServer(NetworkId, Message::Type, BufferInfo::Type, const QString &, const QString &, const QString &, Message::Flags))); connect(net, SIGNAL(displayStatusMsg(QString)), SLOT(recvStatusMsgFromServer(QString))); + connect(net, SIGNAL(disconnected(NetworkId)), SIGNAL(networkDisconnected(NetworkId))); net->setNetworkInfo(info); net->setProxy(signalProxy()); @@ -468,6 +481,9 @@ void CoreSession::removeNetwork(NetworkId id) { return; if(net->connectionState() != Network::Disconnected) { + // make sure we no longer receive data from the tcp buffer + disconnect(net, SIGNAL(displayMsg(NetworkId, Message::Type, BufferInfo::Type, const QString &, const QString &, const QString &, Message::Flags)), this, 0); + disconnect(net, SIGNAL(displayStatusMsg(QString)), this, 0); connect(net, SIGNAL(disconnected(NetworkId)), this, SLOT(destroyNetwork(NetworkId))); net->disconnectFromIrc(); } else { @@ -479,6 +495,16 @@ void CoreSession::destroyNetwork(NetworkId id) { QList removedBuffers = Core::requestBufferIdsForNetwork(user(), id); Network *net = _networks.take(id); if(net && Core::removeNetwork(user(), id)) { + // make sure that all unprocessed RawMessages from this network are removed + QList::iterator messageIter = _messageQueue.begin(); + while(messageIter != _messageQueue.end()) { + if(messageIter->networkId == id) { + messageIter = _messageQueue.erase(messageIter); + } else { + messageIter++; + } + } + // remove buffers from syncer foreach(BufferId bufferId, removedBuffers) { _bufferSyncer->removeBuffer(bufferId); }