X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fcore%2Fcoreauthhandler.cpp;h=a05fa95b4f63f78530f61afba3ee9b63ad5f54f9;hb=a83608156c3a561a0ba6d9625303040c02329550;hp=a2367c37c299357cc69f052151959261ac7a8d0c;hpb=28cee4568aeb1ce3014d11234e40f19e7aeae5bd;p=quassel.git diff --git a/src/core/coreauthhandler.cpp b/src/core/coreauthhandler.cpp index a2367c37..a05fa95b 100644 --- a/src/core/coreauthhandler.cpp +++ b/src/core/coreauthhandler.cpp @@ -171,21 +171,23 @@ void CoreAuthHandler::handle(const RegisterClient &msg) return; } + _peer->setFeatures(std::move(msg.features)); + _peer->setBuildDate(msg.buildDate); + _peer->setClientVersion(msg.clientVersion); + QVariantList backends; QVariantList authenticators; bool configured = Core::isConfigured(); if (!configured) { backends = Core::backendInfo(); - authenticators = Core::authenticatorInfo(); + if (_peer->hasFeature(Quassel::Feature::Authenticators)) { + authenticators = Core::authenticatorInfo(); + } } - // useSsl is only used for the legacy protocol - // XXX: FIXME: use client features here: we cannot pass authenticators if the client is too old! - _peer->dispatch(ClientRegistered(Quassel::features(), configured, backends, useSsl, authenticators)); - - _peer->setBuildDate(msg.buildDate); - _peer->setClientVersion(msg.clientVersion); + _peer->dispatch(ClientRegistered(Quassel::Features{}, configured, backends, authenticators, useSsl)); + // useSsl is only used for the legacy protocol if (_legacy && useSsl) startSsl(); @@ -235,6 +237,15 @@ void CoreAuthHandler::handle(const Login &msg) quInfo() << qPrintable(tr("Client %1 initialized and authenticated successfully as \"%2\" (UserId: %3).").arg(socket()->peerAddress().toString(), msg.user, QString::number(uid.toInt()))); + const auto &clientFeatures = _peer->features(); + auto unsupported = clientFeatures.toStringList(false); + if (!unsupported.isEmpty()) { + quInfo() << qPrintable(tr("Client does not support the following features: %1").arg(unsupported.join(", "))); + } + if (!clientFeatures.unknownFeatures().isEmpty()) { + quInfo() << qPrintable(tr("Client supports unknown features: %1").arg(clientFeatures.unknownFeatures().join(", "))); + } + disconnect(socket(), 0, this, 0); disconnect(_peer, 0, this, 0); _peer->setParent(0); // Core needs to take care of this one now!