X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fcore%2Fcoreauthhandler.cpp;h=369a13484459cf6fd8714b247351311a5662a5e2;hb=20745bd0cbae035b84913127dfec9e8433d1282d;hp=913968bca1e7eba75bd465c45f30012a48aca2e5;hpb=e17fca767d60c06ca02bc5898ced04f06d3670bd;p=quassel.git diff --git a/src/core/coreauthhandler.cpp b/src/core/coreauthhandler.cpp index 913968bc..369a1348 100644 --- a/src/core/coreauthhandler.cpp +++ b/src/core/coreauthhandler.cpp @@ -25,13 +25,13 @@ #endif #include "core.h" -#include "logger.h" +#include "logmessage.h" using namespace Protocol; CoreAuthHandler::CoreAuthHandler(QTcpSocket *socket, QObject *parent) : AuthHandler(parent), - _peer(0), + _peer(nullptr), _magicReceived(false), _legacy(false), _clientRegistered(false), @@ -86,8 +86,8 @@ void CoreAuthHandler::onReadyRead() socket()->read((char*)&data, 4); data = qFromBigEndian(data); - Protocol::Type type = static_cast(data & 0xff); - quint16 protoFeatures = static_cast(data>>8 & 0xffff); + auto type = static_cast(data & 0xff); + auto protoFeatures = static_cast(data>>8 & 0xffff); _supportedProtos.append(PeerFactory::ProtoDescriptor(type, protoFeatures)); if (data >= 0x80000000) { // last protocol @@ -246,15 +246,19 @@ void CoreAuthHandler::handle(const Login &msg) const auto &clientFeatures = _peer->features(); auto unsupported = clientFeatures.toStringList(false); if (!unsupported.isEmpty()) { - quInfo() << qPrintable(tr("Client does not support the following features: %1").arg(unsupported.join(", "))); + if (unsupported.contains("NoFeatures")) + quInfo() << qPrintable(tr("Client does not support extended features.")); + else + quInfo() << qPrintable(tr("Client does not support the following features: %1").arg(unsupported.join(", "))); } + if (!clientFeatures.unknownFeatures().isEmpty()) { quInfo() << qPrintable(tr("Client supports unknown features: %1").arg(clientFeatures.unknownFeatures().join(", "))); } - disconnect(socket(), 0, this, 0); - disconnect(_peer, 0, this, 0); - _peer->setParent(0); // Core needs to take care of this one now! + disconnect(socket(), nullptr, this, nullptr); + disconnect(_peer, nullptr, this, nullptr); + _peer->setParent(nullptr); // Core needs to take care of this one now! socket()->flush(); // Make sure all data is sent before handing over the peer (and socket) to the session thread (bug 682) emit handshakeComplete(_peer, uid); @@ -266,7 +270,7 @@ void CoreAuthHandler::handle(const Login &msg) void CoreAuthHandler::startSsl() { #ifdef HAVE_SSL - QSslSocket *sslSocket = qobject_cast(socket()); + auto *sslSocket = qobject_cast(socket()); Q_ASSERT(sslSocket); qDebug() << qPrintable(tr("Starting encryption for Client:")) << _peer->description(); @@ -280,7 +284,7 @@ void CoreAuthHandler::startSsl() #ifdef HAVE_SSL void CoreAuthHandler::onSslErrors() { - QSslSocket *sslSocket = qobject_cast(socket()); + auto *sslSocket = qobject_cast(socket()); Q_ASSERT(sslSocket); sslSocket->ignoreSslErrors(); }