X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fcommon%2Fsignalproxy.cpp;h=8935538370348d5dbe1661cbfd7de05288cb2721;hb=98144aaad0cd747f186edcd0e36a1d67326ac766;hp=721f32a45032359e04c6e8fd55e8608ce76cce87;hpb=fb80dab2044d302eb8ccacd0b34d4cbaf5fe904c;p=quassel.git diff --git a/src/common/signalproxy.cpp b/src/common/signalproxy.cpp index 721f32a4..89355383 100644 --- a/src/common/signalproxy.cpp +++ b/src/common/signalproxy.cpp @@ -18,6 +18,8 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. * ***************************************************************************/ +#include + #include #include #include @@ -59,18 +61,18 @@ public: SignalRelay(SignalProxy *parent) : QObject(parent), _proxy(parent) {} inline SignalProxy *proxy() const { return _proxy; } - int qt_metacall(QMetaObject::Call _c, int _id, void **_a); + int qt_metacall(QMetaObject::Call _c, int _id, void **_a) override; void attachSignal(QObject *sender, int signalId, const QByteArray &funcName); void detachSignal(QObject *sender, int signalId = -1); private: struct Signal { - QObject *sender; - int signalId; + QObject *sender{nullptr}; + int signalId{-1}; QByteArray signature; - Signal(QObject *sender, int sigId, const QByteArray &signature) : sender(sender), signalId(sigId), signature(signature) {} - Signal() : sender(0), signalId(-1) {} + Signal(QObject *sender, int sigId, QByteArray signature) : sender(sender), signalId(sigId), signature(std::move(signature)) {} + Signal() = default; }; SignalProxy *_proxy; @@ -340,8 +342,8 @@ void SignalProxy::removePeer(Peer *peer) return; } - disconnect(peer, 0, this, 0); - peer->setSignalProxy(0); + disconnect(peer, nullptr, this, nullptr); + peer->setSignalProxy(nullptr); _peerMap.remove(peer->id()); emit peerRemoved(peer); @@ -386,7 +388,7 @@ void SignalProxy::objectRenamed(const QByteArray &classname, const QString &newn const QMetaObject *SignalProxy::metaObject(const QObject *obj) { - if (const SyncableObject *syncObject = qobject_cast(obj)) + if (const auto *syncObject = qobject_cast(obj)) return syncObject->syncMetaObject(); else return obj->metaObject(); @@ -398,7 +400,7 @@ SignalProxy::ExtendedMetaObject *SignalProxy::extendedMetaObject(const QMetaObje if (_extendedMetaObjects.contains(meta)) return _extendedMetaObjects[meta]; else - return 0; + return nullptr; } @@ -662,9 +664,9 @@ bool SignalProxy::invokeSlot(QObject *receiver, int methodId, const QVariantList return false; } - void *_a[] = { 0, // return type... - 0, 0, 0, 0, 0, // and 10 args - that's the max size qt can handle with signals and slots - 0, 0, 0, 0, 0 }; + void *_a[] = { nullptr, // return type... + nullptr, nullptr, nullptr, nullptr, nullptr, // and 10 args - that's the max size qt can handle with signals and slots + nullptr, nullptr, nullptr, nullptr, nullptr }; // check for argument compatibility and build params array for (int i = 0; i < numArgs; i++) { @@ -738,7 +740,7 @@ void SignalProxy::customEvent(QEvent *event) { switch ((int)event->type()) { case RemovePeerEvent: { - ::RemovePeerEvent *e = static_cast< ::RemovePeerEvent *>(event); + auto *e = static_cast< ::RemovePeerEvent *>(event); removePeer(e->peer); event->accept(); break; @@ -786,7 +788,7 @@ void SignalProxy::disconnectDevice(QIODevice *dev, const QString &reason) { if (!reason.isEmpty()) qWarning() << qPrintable(reason); - QAbstractSocket *sock = qobject_cast(dev); + auto *sock = qobject_cast(dev); if (sock) qWarning() << qPrintable(tr("Disconnecting")) << qPrintable(sock->peerAddress().toString()); dev->close();