X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fcommon%2Fsettings.cpp;h=e8ad9d0bf81ead6cf784c03db0d69b9a3505ea08;hb=8ff5e8deb3662e1b540574e8f7a07d39edcf737e;hp=f35bdd7905479cf91cd6afbd25aacea60810f3bc;hpb=8699dd758516d0ded076811e8ea656adc95e69d0;p=quassel.git

diff --git a/src/common/settings.cpp b/src/common/settings.cpp
index f35bdd79..e8ad9d0b 100644
--- a/src/common/settings.cpp
+++ b/src/common/settings.cpp
@@ -18,7 +18,6 @@
  *   59 Temple Place - Suite 330, Boston, MA  02111-1307, USA.             *
  ***************************************************************************/
 
-#include <QCoreApplication>
 #include <QSettings>
 #include <QStringList>
 #include <QDebug>
@@ -29,79 +28,105 @@
 
 #include "settings.h"
 
-Settings::Settings(QString g, QString applicationName) : QSettings(QCoreApplication::organizationName(), applicationName), group(g) {
-
-/* we need to call the constructor immediately in order to set the path...
-#ifndef Q_WS_QWS
-  QSettings(QCoreApplication::organizationName(), applicationName);
-#else
-  // FIXME sandboxDir() is not currently working correctly...
-  //if(Qtopia::sandboxDir().isEmpty()) QSettings();
-  //else QSettings(Qtopia::sandboxDir() + "/etc/QuasselIRC.conf", QSettings::NativeFormat);
-  // ...so we have to use a workaround:
-  QString appPath = QCoreApplication::applicationFilePath();
-  if(appPath.startsWith(Qtopia::packagePath())) {
-    QString sandboxPath = appPath.left(Qtopia::packagePath().length() + 32);
-    QSettings(sandboxPath + "/etc/QuasselIRC.conf", QSettings::IniFormat);
-    qDebug() << sandboxPath + "/etc/QuasselIRC.conf";
-  } else {
-    QSettings(QCoreApplication::organizationName(), applicationName);
-  }
-#endif
-*/
-}
-
-Settings::~Settings() {
+QHash<QString, QHash<QString, QVariant> > Settings::settingsCache;
 
-}
-
-void Settings::setGroup(QString g) {
-  group = g;
+// Settings::Settings(QString group_, QString appName_)
+//   : group(group_),
+//     appName(appName_)
+// {
 
-}
+// /* we need to call the constructor immediately in order to set the path...
+// #ifndef Q_WS_QWS
+//   QSettings(QCoreApplication::organizationName(), applicationName);
+// #else
+//   // FIXME sandboxDir() is not currently working correctly...
+//   //if(Qtopia::sandboxDir().isEmpty()) QSettings();
+//   //else QSettings(Qtopia::sandboxDir() + "/etc/QuasselIRC.conf", QSettings::NativeFormat);
+//   // ...so we have to use a workaround:
+//   QString appPath = QCoreApplication::applicationFilePath();
+//   if(appPath.startsWith(Qtopia::packagePath())) {
+//     QString sandboxPath = appPath.left(Qtopia::packagePath().length() + 32);
+//     QSettings(sandboxPath + "/etc/QuasselIRC.conf", QSettings::IniFormat);
+//     qDebug() << sandboxPath + "/etc/QuasselIRC.conf";
+//   } else {
+//     QSettings(QCoreApplication::organizationName(), applicationName);
+//   }
+// #endif
+// */
+// }
 
 QStringList Settings::allLocalKeys() {
-  beginGroup(group);
-  QStringList res = allKeys();
-  endGroup();
+  QSettings s(org(), appName);
+  s.beginGroup(group);
+  QStringList res = s.allKeys();
+  s.endGroup();
   return res;
 }
 
 QStringList Settings::localChildKeys(const QString &rootkey) {
   QString g;
-  if(rootkey.isEmpty()) g = group;
-  else g = QString("%1/%2").arg(group, rootkey);
-  beginGroup(g);
-  QStringList res = childKeys();
-  endGroup();
+  if(rootkey.isEmpty())
+    g = group;
+  else
+    g = QString("%1/%2").arg(group, rootkey);
+
+  QSettings s(org(), appName);
+  s.beginGroup(g);
+  QStringList res = s.childKeys();
+  s.endGroup();
   return res;
 }
 
 QStringList Settings::localChildGroups(const QString &rootkey) {
   QString g;
-  if(rootkey.isEmpty()) g = group;
-  else g = QString("%1/%2").arg(group, rootkey);
-  beginGroup(g);
-  QStringList res = childGroups();
-  endGroup();
+  if(rootkey.isEmpty())
+    g = group;
+  else
+    g = QString("%1/%2").arg(group, rootkey);
+
+  QSettings s(org(), appName);
+  s.beginGroup(g);
+  QStringList res = s.childGroups();
+  s.endGroup();
   return res;
 }
 
 void Settings::setLocalValue(const QString &key, const QVariant &data) {
-  beginGroup(group);
-  setValue(key, data);
-  endGroup();
+  QSettings s(org(), appName);
+  s.beginGroup(group);
+  s.setValue(key, data);
+  s.endGroup();
+  setCacheValue(group, key, data);
 }
 
-QVariant Settings::localValue(const QString &key, const QVariant &def) {
-  beginGroup(group);
-  QVariant res = value(key, def);
-  endGroup();
-  return res;
+const QVariant &Settings::localValue(const QString &key, const QVariant &def) {
+  if(!isCached(group, key)) {
+    QSettings s(org(), appName);
+    s.beginGroup(group);
+    setCacheValue(group, key, s.value(key, def));
+    s.endGroup();
+  }
+  return cacheValue(group, key);
 }
 
 void Settings::removeLocalKey(const QString &key) {
-  beginGroup(group);
-  remove(key);
-  endGroup();
+  QSettings s(org(), appName);
+  s.beginGroup(group);
+  s.remove(key);
+  s.endGroup();
+  if(isCached(group, key))
+    settingsCache[group].remove(key);
 }
+
+
+// void Settings::setCacheValue(const QString &group, const QString &key, const QVariant &data) {
+//   settingsCache[group][key] = data;
+// }
+
+// const QVariant &Settings::cacheValue(const QString &group, const QString &key) {
+//   return settingsCache[group][key];
+// }
+
+// bool Settings::isCached(const QString &group, const QString &key) {
+//   return settingsCache.contains(group) && settingsCache[group].contains(key);
+// }