X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;f=src%2Fclient%2Fnetworkmodel.cpp;h=4b6ce3c64a740c6c52d4f4be6de029aa836bfcc1;hb=9fcd3d063228a779afae82f015a9067186c3b742;hp=962c9f8fcd058f199cadc77ea67b6ff7f0353619;hpb=3c2914faeb01f3bc32e29f40179ae88040fbcf59;p=quassel.git diff --git a/src/client/networkmodel.cpp b/src/client/networkmodel.cpp index 962c9f8f..4b6ce3c6 100644 --- a/src/client/networkmodel.cpp +++ b/src/client/networkmodel.cpp @@ -39,7 +39,11 @@ NetworkItem::NetworkItem(const NetworkId &netid, AbstractTreeItem *parent) : PropertyMapItem(QList() << "networkName" << "currentServer" << "nickCount", parent), _networkId(netid) { + // DO NOT EMIT dataChanged() DIRECTLY IN NetworkItem + // use networkDataChanged() instead. Otherwise you will end up in a infinite loop + // as we "sync" the dataChanged() signals of NetworkItem and StatusBufferItem setFlags(Qt::ItemIsEnabled | Qt::ItemIsSelectable); + connect(this, SIGNAL(networkDataChanged(int)), this, SIGNAL(dataChanged(int))); } QVariant NetworkItem::data(int column, int role) const { @@ -47,6 +51,7 @@ QVariant NetworkItem::data(int column, int role) const { case NetworkModel::BufferIdRole: case NetworkModel::BufferInfoRole: case NetworkModel::BufferTypeRole: + case NetworkModel::BufferActivityRole: if(childCount()) return child(0)->data(column, role); else @@ -84,6 +89,9 @@ BufferItem *NetworkItem::bufferItem(const BufferInfo &bufferInfo) { switch(bufferInfo.type()) { case BufferInfo::StatusBuffer: bufferItem = new StatusBufferItem(bufferInfo, this); + disconnect(this, SIGNAL(networkDataChanged(int)), this, SIGNAL(dataChanged(int))); + connect(this, SIGNAL(networkDataChanged(int)), bufferItem, SIGNAL(dataChanged(int))); + connect(bufferItem, SIGNAL(dataChanged(int)), this, SIGNAL(dataChanged(int))); break; case BufferInfo::ChannelBuffer: bufferItem = new ChannelBufferItem(bufferInfo, this); @@ -114,11 +122,11 @@ void NetworkItem::attachNetwork(Network *network) { connect(network, SIGNAL(ircUserAdded(IrcUser *)), this, SLOT(attachIrcUser(IrcUser *))); connect(network, SIGNAL(connectedSet(bool)), - this, SIGNAL(dataChanged())); + this, SIGNAL(networkDataChanged())); connect(network, SIGNAL(destroyed()), - this, SIGNAL(dataChanged())); + this, SIGNAL(networkDataChanged())); - emit dataChanged(); + emit networkDataChanged(); } void NetworkItem::attachIrcChannel(IrcChannel *ircChannel) { @@ -143,7 +151,7 @@ void NetworkItem::attachIrcUser(IrcUser *ircUser) { continue; if(queryItem->bufferName().toLower() == ircUser->nick().toLower()) { - queryItem->attachIrcUser(ircUser); + queryItem->setIrcUser(ircUser); break; } } @@ -151,12 +159,12 @@ void NetworkItem::attachIrcUser(IrcUser *ircUser) { void NetworkItem::setNetworkName(const QString &networkName) { Q_UNUSED(networkName); - emit dataChanged(0); + emit networkDataChanged(0); } void NetworkItem::setCurrentServer(const QString &serverName) { Q_UNUSED(serverName); - emit dataChanged(1); + emit networkDataChanged(1); } @@ -282,8 +290,6 @@ QString BufferItem::toolTip(int column) const { StatusBufferItem::StatusBufferItem(const BufferInfo &bufferInfo, NetworkItem *parent) : BufferItem(bufferInfo, parent) { - Q_ASSERT(parent); - connect(parent, SIGNAL(dataChanged()), this, SIGNAL(dataChanged())); } QString StatusBufferItem::toolTip(int column) const { @@ -310,8 +316,7 @@ QueryBufferItem::QueryBufferItem(const BufferInfo &bufferInfo, NetworkItem *pare return; IrcUser *ircUser = net->ircUser(bufferInfo.bufferName()); - if(ircUser) - attachIrcUser(ircUser); + setIrcUser(ircUser); } QVariant QueryBufferItem::data(int column, int role) const { @@ -346,6 +351,14 @@ bool QueryBufferItem::setData(int column, const QVariant &value, int role) { } } +void QueryBufferItem::setBufferName(const QString &name) { + BufferItem::setBufferName(name); + NetworkId netId = data(0, NetworkModel::NetworkIdRole).value(); + const Network *net = Client::network(netId); + if(net) + setIrcUser(net->ircUser(name)); +} + QString QueryBufferItem::toolTip(int column) const { // pretty much code duplication of IrcUserItem::toolTip() but inheritance won't solve this... Q_UNUSED(column); @@ -381,14 +394,24 @@ QString QueryBufferItem::toolTip(int column) const { return QString("

%1

").arg(toolTip.join("
")); } -void QueryBufferItem::attachIrcUser(IrcUser *ircUser) { +void QueryBufferItem::setIrcUser(IrcUser *ircUser) { + if(_ircUser == ircUser) + return; + + if(_ircUser) { + disconnect(_ircUser, 0, this, 0); + } + + if(ircUser) { + connect(ircUser, SIGNAL(quited()), this, SLOT(removeIrcUser())); + connect(ircUser, SIGNAL(awaySet(bool)), this, SIGNAL(dataChanged())); + } + _ircUser = ircUser; - connect(_ircUser, SIGNAL(quited()), this, SLOT(ircUserQuited())); - connect(_ircUser, SIGNAL(awaySet(bool)), this, SIGNAL(dataChanged())); emit dataChanged(); } -void QueryBufferItem::ircUserQuited() { +void QueryBufferItem::removeIrcUser() { _ircUser = 0; emit dataChanged(); } @@ -608,6 +631,7 @@ UserCategoryItem::UserCategoryItem(int category, AbstractTreeItem *parent) : PropertyMapItem(QStringList() << "categoryName", parent), _category(category) { + setFlags(Qt::ItemIsEnabled); setTreeItemFlags(AbstractTreeItem::DeleteOnLastChildRemoved); setObjectName(parent->data(0, Qt::DisplayRole).toString() + "/" + QString::number(category)); } @@ -1041,3 +1065,35 @@ BufferId NetworkModel::bufferId(NetworkId networkId, const QString &bufferName, } return BufferId(); } + +void NetworkModel::sortBufferIds(QList &bufferIds) const { + QList bufferItems; + foreach(BufferId bufferId, bufferIds) { + if(_bufferItemCache.contains(bufferId)) + bufferItems << _bufferItemCache[bufferId]; + } + + qSort(bufferItems.begin(), bufferItems.end(), bufferItemLessThan); + + bufferIds.clear(); + foreach(BufferItem *bufferItem, bufferItems) { + bufferIds << bufferItem->bufferId(); + } +} + +QList NetworkModel::allBufferIdsSorted() const { + QList bufferIds = allBufferIds(); + sortBufferIds(bufferIds); + return bufferIds; +} + +bool NetworkModel::bufferItemLessThan(const BufferItem *left, const BufferItem *right) { + int leftType = left->bufferType(); + int rightType = right->bufferType(); + + if(leftType != rightType) + return leftType < rightType; + else + return QString::compare(left->bufferName(), right->bufferName(), Qt::CaseInsensitive) < 0; +} +