X-Git-Url: https://git.quassel-irc.org/?a=blobdiff_plain;ds=sidebyside;f=src%2Fclient%2Fexecwrapper.cpp;h=67292df2d865601ec1a0e5d0a96148d34a45b8a9;hb=6eefdfc697067d184a589fc8a231b16316c09106;hp=24bd22be6eadcc688ff0071f374e7f94ab90ee7d;hpb=1cb02004ee5973b89368bd84f234d4652794690d;p=quassel.git diff --git a/src/client/execwrapper.cpp b/src/client/execwrapper.cpp index 24bd22be..67292df2 100644 --- a/src/client/execwrapper.cpp +++ b/src/client/execwrapper.cpp @@ -1,5 +1,5 @@ /*************************************************************************** - * Copyright (C) 2005-2015 by the Quassel Project * + * Copyright (C) 2005-2018 by the Quassel Project * * devel@quassel-irc.org * * * * This program is free software; you can redistribute it and/or modify * @@ -26,16 +26,17 @@ #include "client.h" #include "messagemodel.h" #include "quassel.h" +#include "util.h" ExecWrapper::ExecWrapper(QObject *parent) : QObject(parent) { - connect(&_process, SIGNAL(readyReadStandardOutput()), SLOT(processReadStdout())); - connect(&_process, SIGNAL(readyReadStandardError()), SLOT(processReadStderr())); - connect(&_process, SIGNAL(finished(int, QProcess::ExitStatus)), SLOT(processFinished(int, QProcess::ExitStatus))); - connect(&_process, SIGNAL(error(QProcess::ProcessError)), SLOT(processError(QProcess::ProcessError))); + connect(&_process, &QProcess::readyReadStandardOutput, this, &ExecWrapper::processReadStdout); + connect(&_process, &QProcess::readyReadStandardError, this, &ExecWrapper::processReadStderr); + connect(&_process, selectOverload(&QProcess::finished), this, &ExecWrapper::processFinished); + connect(&_process, selectOverload(&QProcess::error), this, &ExecWrapper::processError); - connect(this, SIGNAL(output(QString)), SLOT(postStdout(QString))); - connect(this, SIGNAL(error(QString)), SLOT(postStderr(QString))); + connect(this, &ExecWrapper::output, this, &ExecWrapper::postStdout); + connect(this, &ExecWrapper::error, this, &ExecWrapper::postStderr); } @@ -44,7 +45,7 @@ void ExecWrapper::start(const BufferInfo &info, const QString &command) _bufferInfo = info; QString params; - QRegExp rx("^\\s*(\\S+)(\\s+(.*))?$"); + QRegExp rx(R"(^\s*(\S+)(\s+(.*))?$)"); if (!rx.exactMatch(command)) { emit error(tr("Invalid command string for /exec: %1").arg(command)); } @@ -55,7 +56,7 @@ void ExecWrapper::start(const BufferInfo &info, const QString &command) // Make sure we don't execute something outside a script dir if (_scriptName.contains("../") || _scriptName.contains("..\\")) - emit error(tr("Name \"%1\" is invalid: ../ or ..\\ are not allowed!").arg(_scriptName)); + emit error(tr(R"(Name "%1" is invalid: ../ or ..\ are not allowed!)").arg(_scriptName)); else { foreach(QString scriptDir, Quassel::scriptDirPaths()) {