/***************************************************************************
- * Copyright (C) 2005-2016 by the Quassel Project *
+ * Copyright (C) 2005-2018 by the Quassel Project *
* devel@quassel-irc.org *
* *
* This program is free software; you can redistribute it and/or modify *
void EventStringifier::processIrcEventPong(IrcEvent *e)
{
- QString timestamp = e->params().at(1);
- QTime sendTime = QTime::fromString(timestamp, "hh:mm:ss.zzz");
- if (!sendTime.isValid())
- displayMsg(e, Message::Server, "PONG " + e->params().join(" "), e->prefix());
+ // CoreSessionEventProcessor will flag automated PONG replies as EventManager::Silent. There's
+ // no need to handle that specially here.
+
+ // Format the PONG reply for display
+ displayMsg(e, Message::Server, "PONG " + e->params().join(" "), e->prefix());
}
target = nick;
IrcUser *ircuser = e->network()->ircUser(nick);
if (ircuser) {
- int now = QDateTime::currentDateTime().toTime_t();
- const int silenceTime = 60;
- if (ircuser->lastAwayMessage() + silenceTime >= now)
+ QDateTime now = QDateTime::currentDateTime();
+ now.setTimeSpec(Qt::UTC);
+ // Don't print "user is away" messages more often than this
+ // 1 hour = 60 min * 60 sec
+ const int silenceTime = 60 * 60;
+ // Check if away state has NOT changed and silence time hasn't yet elapsed
+ if (!ircuser->hasAwayChanged()
+ && ircuser->lastAwayMessageTime().addSecs(silenceTime) >= now) {
+ // Away message hasn't changed and we're still within the period of silence; don't
+ // repeat the message
send = false;
- ircuser->setLastAwayMessage(now);
+ }
+ ircuser->setLastAwayMessageTime(now);
+ // Mark any changes in away as acknowledged
+ ircuser->acknowledgeAwayChanged();
}
}
if (send)
int idleSecs = e->params()[1].toInt();
if (e->params().count() > 3) { // if we have more then 3 params we have the above mentioned "real life" situation
- QDateTime loginTime = QDateTime::fromTime_t(e->params()[2].toInt()).toUTC();
+ // Time in IRC protocol is defined as seconds. Convert from seconds instead.
+ // See https://doc.qt.io/qt-5/qdatetime.html#fromSecsSinceEpoch
+#if QT_VERSION >= 0x050800
+ QDateTime loginTime = QDateTime::fromSecsSinceEpoch(e->params()[2].toLongLong()).toUTC();
+#else
+ // fromSecsSinceEpoch() was added in Qt 5.8. Manually downconvert to seconds for now.
+ // See https://doc.qt.io/qt-5/qdatetime.html#fromMSecsSinceEpoch
+ QDateTime loginTime = QDateTime::fromMSecsSinceEpoch(
+ (qint64)(e->params()[2].toLongLong() * 1000)).toUTC();
+#endif
displayMsg(e, Message::Server, tr("[Whois] %1 is logged in since %2")
.arg(e->params()[0], loginTime.toString("yyyy-MM-dd hh:mm:ss UTC")));
}
switch (e->params().count()) {
case 3:
topic = e->params()[2];
- [[clang::fallthrough]];
+ // fallthrough
case 2:
userCount = e->params()[1].toUInt();
- [[clang::fallthrough]];
+ /* fallthrough */
case 1:
channelName = e->params()[0];
- [[clang::fallthrough]];
+ // blubb
default:
break;
}
return;
QString channel = e->params()[0];
- uint unixtime = e->params()[1].toUInt();
+ // Allow for 64-bit time
+ qint64 unixtime = e->params()[1].toLongLong();
if (!unixtime) {
qWarning() << Q_FUNC_INFO << "received invalid timestamp:" << e->params()[1];
return;
}
- QDateTime time = QDateTime::fromTime_t(unixtime).toUTC();
+ // Time in IRC protocol is defined as seconds. Convert from seconds instead.
+ // See https://doc.qt.io/qt-5/qdatetime.html#fromSecsSinceEpoch
+#if QT_VERSION >= 0x050800
+ QDateTime time = QDateTime::fromSecsSinceEpoch(unixtime).toUTC();
+#else
+ // fromSecsSinceEpoch() was added in Qt 5.8. Manually downconvert to seconds for now.
+ // See https://doc.qt.io/qt-5/qdatetime.html#fromMSecsSinceEpoch
+ QDateTime time = QDateTime::fromMSecsSinceEpoch((qint64)(unixtime * 1000)).toUTC();
+#endif
displayMsg(e, Message::Topic, tr("Channel %1 created on %2")
.arg(channel, time.toString("yyyy-MM-dd hh:mm:ss UTC")),
QString(), channel);
return;
QString channel = e->params().first();
- QDateTime topicSetTime = QDateTime::fromTime_t(e->params()[2].toInt()).toUTC();
+ // Time in IRC protocol is defined as seconds. Convert from seconds instead.
+ // See https://doc.qt.io/qt-5/qdatetime.html#fromSecsSinceEpoch
+#if QT_VERSION >= 0x050800
+ QDateTime topicSetTime = QDateTime::fromSecsSinceEpoch(e->params()[2].toLongLong()).toUTC();
+#else
+ // fromSecsSinceEpoch() was added in Qt 5.8. Manually downconvert to seconds for now.
+ // See https://doc.qt.io/qt-5/qdatetime.html#fromMSecsSinceEpoch
+ QDateTime topicSetTime = QDateTime::fromMSecsSinceEpoch(
+ (qint64)(e->params()[2].toLongLong() * 1000)).toUTC();
+#endif
displayMsg(e, Message::Topic, tr("Topic set by %1 on %2")
.arg(e->params()[1],
topicSetTime.toString("yyyy-MM-dd hh:mm:ss UTC")), QString(), channel);