QByteArray encMsg = userEncode(target, msg.section(' ', 1));
#ifdef HAVE_QCA2
- encMsg = encrypt(target, encMsg);
+ putPrivmsg(serverEncode(target), encMsg, network()->cipher(target));
+#else
+ putPrivmsg(serverEncode(target), encMsg);
#endif
-
- putPrivmsg(serverEncode(target), encMsg, false);
}
void CoreUserInputHandler::handleNick(const BufferInfo &bufferInfo, const QString &msg) {
QString target = msg.section(' ', 0, 0);
QString message = msg.section(' ', 1);
if(message.isEmpty())
- emit displayMsg(Message::Server, BufferInfo::QueryBuffer, target, "Starting query with " + target, network()->myNick(), Message::Self);
+ emit displayMsg(Message::Server, BufferInfo::QueryBuffer, target, tr("Starting query with ") + target, network()->myNick(), Message::Self);
else
emit displayMsg(Message::Plain, BufferInfo::QueryBuffer, target, message, network()->myNick(), Message::Self);
handleMsg(bufferInfo, msg);
QByteArray encMsg = channelEncode(bufferInfo.bufferName(), msg);
#ifdef HAVE_QCA2
- encMsg = encrypt(bufferInfo.bufferName(), encMsg);
+ putPrivmsg(serverEncode(bufferInfo.bufferName()), encMsg, network()->cipher(bufferInfo.bufferName()));
+#else
+ putPrivmsg(serverEncode(bufferInfo.bufferName()), encMsg);
#endif
-
- putPrivmsg(serverEncode(bufferInfo.bufferName()), encMsg, false);
emit displayMsg(Message::Plain, bufferInfo.type(), bufferInfo.bufferName(), msg, network()->myNick(), Message::Self);
}
emit putCmd(serverEncode(cmd.toUpper()), serverEncode(msg.split(" ")));
}
-// TODO: handle cutoff of encrypted messages
-void CoreUserInputHandler::putPrivmsg(const QByteArray &target, const QByteArray &message, bool encrypted) {
-
- QByteArray temp = message;
+void CoreUserInputHandler::putPrivmsg(const QByteArray &target, const QByteArray &message, Cipher *cipher) {
+ // Encrypted messages need special care. There's no clear relation between cleartext and encrypted message length,
+ // so we can't just compute the maxSplitPos. Instead, we need to loop through the splitpoints until the crypted
+ // version is short enough...
+ // TODO: check out how the various possible encryption methods behave length-wise and make
+ // this clean by predicting the length of the crypted msg.
+ // For example, blowfish-ebc seems to create 8-char chunks.
static const char *cmd = "PRIVMSG";
- int overrun = lastParamOverrun(cmd, QList<QByteArray>() << target << temp);
- if(overrun) {
- static const char *splitter = " .,-";
- int maxSplitPos = temp.count() - overrun;
- int splitPos = -1;
- for(const char *splitChar = splitter; *splitChar != 0; splitChar++) {
- splitPos = qMax(splitPos, temp.lastIndexOf(*splitChar, maxSplitPos));
+ static const char *splitter = " .,-";
+
+ int maxSplitPos = message.count();
+ int splitPos = maxSplitPos;
+ forever {
+ QByteArray crypted = message.left(splitPos);
+ bool isEncrypted = false;
+#ifdef HAVE_QCA2
+ if(cipher && !message.isEmpty()) {
+ isEncrypted = cipher->encrypt(crypted);
}
- if(splitPos <= 0) {
- splitPos = maxSplitPos;
+#endif
+ int overrun = lastParamOverrun(cmd, QList<QByteArray>() << target << crypted);
+ if(overrun) {
+ // In case this is not an encrypted msg, we can just cut off at the end
+ if(!isEncrypted)
+ maxSplitPos = message.count() - overrun;
+
+ splitPos = -1;
+ for(const char *splitChar = splitter; *splitChar != 0; splitChar++) {
+ splitPos = qMax(splitPos, message.lastIndexOf(*splitChar, maxSplitPos) + 1); // keep split char on old line
+ }
+ if(splitPos <= 0 || splitPos > maxSplitPos)
+ splitPos = maxSplitPos;
+
+ maxSplitPos = splitPos - 1;
+ if(maxSplitPos <= 0) { // this should never happen, but who knows...
+ qWarning() << tr("[Error] Could not encrypt your message: %1").arg(message.data());
+ return;
+ }
+ continue; // we never come back here for !encrypted!
}
- putCmd(cmd, QList<QByteArray>() << target << temp.left(splitPos));
- putPrivmsg(target, temp.mid(splitPos), encrypted);
+
+ // now we have found a valid splitpos (or didn't need to split to begin with)
+ putCmd(cmd, QList<QByteArray>() << target << crypted);
+ if(splitPos < message.count())
+ putPrivmsg(target, message.mid(splitPos), cipher);
+
return;
- } else {
- putCmd(cmd, QList<QByteArray>() << target << temp);
}
}
}
#ifdef HAVE_QCA2
-QByteArray CoreUserInputHandler::encrypt(const QString &target, const QByteArray &message_) const {
- if(target.isEmpty() || message_.isEmpty())
+QByteArray CoreUserInputHandler::encrypt(const QString &target, const QByteArray &message_, bool *didEncrypt) const {
+ if(didEncrypt)
+ *didEncrypt = false;
+
+ if(message_.isEmpty())
return message_;
- QByteArray key = network()->cipherKey(target);
- if(key.isEmpty())
+ Cipher *cipher = network()->cipher(target);
+ if(!cipher)
return message_;
QByteArray message = message_;
-
- CoreIrcChannel *channel = qobject_cast<CoreIrcChannel *>(network()->ircChannel(target));
- if(channel) {
- if(channel->cipher()->setKey(key))
- channel->cipher()->encrypt(message);
- } else {
- CoreIrcUser *user = qobject_cast<CoreIrcUser *>(network()->ircUser(target));
- if(user && user->cipher()->setKey(key))
- user->cipher()->encrypt(message);
- }
+ bool result = cipher->encrypt(message);
+ if(didEncrypt)
+ *didEncrypt = result;
return message;
}