/***************************************************************************
- * Copyright (C) 2005-2018 by the Quassel Project *
+ * Copyright (C) 2005-2020 by the Quassel Project *
* devel@quassel-irc.org *
* *
* This program is free software; you can redistribute it and/or modify *
#include "common-export.h"
+#include <memory>
+#include <type_traits>
+#include <utility>
+
#include <QCoreApplication>
#include <QHash>
#include <QSettings>
#include <QString>
#include <QVariant>
-#include <utility>
#include "quassel.h"
Q_OBJECT
signals:
- void valueChanged(const QVariant &newValue);
+ void valueChanged(const QVariant& newValue);
private:
friend class Settings;
};
-
class COMMON_EXPORT Settings
{
public:
- enum Mode { Default, Custom };
+ enum Mode
+ {
+ Default,
+ Custom
+ };
public:
- //! Call the given slot on change of the given key
- virtual void notify(const QString &key, QObject *receiver, const char *slot);
+ //! Calls the given slot on change of the given key
+ template<typename Receiver, typename Slot>
+ void notify(const QString& key, const Receiver* receiver, Slot slot) const
+ {
+ static_assert(!std::is_same<Slot, const char*>::value, "Old-style slots not supported");
+ QObject::connect(notifier(normalizedKey(_group, keyForNotify(key))), &SettingsChangeNotifier::valueChanged, receiver, slot);
+ }
//! Sets up notification and calls the given slot to set the initial value
- void initAndNotify(const QString &key, QObject *receiver, const char *slot, const QVariant &defaultValue = QVariant());
+ template<typename Receiver, typename Slot>
+ void initAndNotify(const QString& key, const Receiver* receiver, Slot slot, const QVariant& defaultValue = {}) const
+ {
+ notify(key, receiver, std::move(slot));
+ auto notifyKey = keyForNotify(key);
+ emit notifier(normalizedKey(_group, notifyKey))->valueChanged(localValue(notifyKey, defaultValue));
+ }
/**
* Get the major configuration version
*
* @return Major configuration version (the X in XX.YY)
*/
- virtual uint version();
+ virtual uint version() const;
/**
* Get the minor configuration version
* @see Settings::setVersionMinor()
* @return Minor configuration version (the Y in XX.YY)
*/
- virtual uint versionMinor();
+ virtual uint versionMinor() const;
/**
* Set the minor configuration version
*
* @return true if writable, false otherwise
*/
- bool isWritable();
+ bool isWritable() const;
protected:
- inline Settings(QString group_, QString appName_) : group(std::move(group_)), appName(std::move(appName_)) {}
- inline virtual ~Settings() {}
+ Settings(QString group, QString appName);
+ virtual ~Settings() = default;
- inline void setGroup(const QString &group_) { group = group_; }
+ void setGroup(QString group);
+
+ /**
+ * Allows subclasses to transform the key given to notify().
+ *
+ * Default implementation just returns the given key.
+ *
+ * @param key Key given to notify()
+ * @returns Key that should be used for notfication
+ */
+ virtual QString keyForNotify(const QString& key) const;
- virtual QStringList allLocalKeys();
- virtual QStringList localChildKeys(const QString &rootkey = QString());
- virtual QStringList localChildGroups(const QString &rootkey = QString());
+ virtual QStringList allLocalKeys() const;
+ virtual QStringList localChildKeys(const QString& rootkey = QString()) const;
+ virtual QStringList localChildGroups(const QString& rootkey = QString()) const;
- virtual void setLocalValue(const QString &key, const QVariant &data);
- virtual QVariant localValue(const QString &key, const QVariant &def = QVariant());
+ virtual void setLocalValue(const QString& key, const QVariant& data);
+ virtual QVariant localValue(const QString& key, const QVariant& def = QVariant()) const;
/**
* Gets if a key exists in settings
* @param[in] key ID of local settings key
* @returns True if key exists in settings, otherwise false
*/
- virtual bool localKeyExists(const QString &key);
+ virtual bool localKeyExists(const QString& key) const;
- virtual void removeLocalKey(const QString &key);
+ virtual void removeLocalKey(const QString& key);
- QString group;
- QString appName;
+ QString _group;
+ QString _appName;
private:
- inline QSettings::Format format()
- {
-#ifdef Q_OS_WIN
- return QSettings::IniFormat;
-#else
- return QSettings::NativeFormat;
-#endif
- }
-
-
- inline QString fileName()
- {
- return Quassel::configDirPath() + appName
- + ((format() == QSettings::NativeFormat) ? QLatin1String(".conf") : QLatin1String(".ini"));
- }
-
+ QSettings::Format format() const;
- static QHash<QString, QVariant> settingsCache; ///< Cached settings values
- static QHash<QString, bool> settingsKeyPersistedCache; ///< Cached settings key exists on disk
- static QHash<QString, SettingsChangeNotifier *> settingsChangeNotifier;
-
- inline QString normalizedKey(const QString &group, const QString &key)
- {
- if (group.isEmpty())
- return key;
- return group + '/' + key;
- }
+ QString fileName() const;
+ QString normalizedKey(const QString& group, const QString& key) const;
/**
* Update the cache of whether or not a given settings key persists on disk
* @param normKey Normalized settings key ID
* @param exists True if key exists, otherwise false
*/
- inline void setCacheKeyPersisted(const QString &normKey, bool exists)
- {
- settingsKeyPersistedCache[normKey] = exists;
- }
-
+ void setCacheKeyPersisted(const QString& normKey, bool exists) const;
/**
* Check if the given settings key ID persists on disk (rather than being a default value)
* @param normKey Normalized settings key ID
* @return True if key exists and persistence has been cached, otherwise false
*/
- inline const bool &cacheKeyPersisted(const QString &normKey)
- {
- return settingsKeyPersistedCache[normKey];
- }
-
+ bool cacheKeyPersisted(const QString& normKey) const;
/**
* Check if the persistence of the given settings key ID has been cached
* @param normKey Normalized settings key ID
* @return True if key persistence has been cached, otherwise false
*/
- inline bool isKeyPersistedCached(const QString &normKey)
- {
- return settingsKeyPersistedCache.contains(normKey);
- }
+ bool isKeyPersistedCached(const QString& normKey) const;
+ void setCacheValue(const QString& normKey, const QVariant& data) const;
- inline void setCacheValue(const QString &normKey, const QVariant &data)
- {
- settingsCache[normKey] = data;
- }
+ QVariant cacheValue(const QString& normKey) const;
+ bool isCached(const QString& normKey) const;
- inline const QVariant &cacheValue(const QString &normKey)
- {
- return settingsCache[normKey];
- }
+ SettingsChangeNotifier* notifier(const QString& normKey) const;
+ bool hasNotifier(const QString& normKey) const;
- inline bool isCached(const QString &normKey)
- {
- return settingsCache.contains(normKey);
- }
-
-
- inline SettingsChangeNotifier *notifier(const QString &normKey)
- {
- if (!hasNotifier(normKey))
- settingsChangeNotifier[normKey] = new SettingsChangeNotifier();
- return settingsChangeNotifier[normKey];
- }
-
-
- inline bool hasNotifier(const QString &normKey)
- {
- return settingsChangeNotifier.contains(normKey);
- }
+private:
+ static QHash<QString, QVariant> _settingsCache; ///< Cached settings values
+ static QHash<QString, bool> _settingsKeyPersistedCache; ///< Cached settings key exists on disk
+ static QHash<QString, std::shared_ptr<SettingsChangeNotifier>> _settingsChangeNotifier;
};