ci: Adapt warning configuration to new release of MSVC 19
authorManuel Nickschas <sputnick@quassel-irc.org>
Sun, 30 May 2021 13:24:24 +0000 (15:24 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Sun, 30 May 2021 15:26:36 +0000 (17:26 +0200)
commitabb5adb878ad28d401014f235ecb6dbddb89412b
tree96a4a6549593b578c8f6a6906e92a237a640b7e9
parent533c5a8767adeb7de0a554eb6aa0335148a1403f
ci: Adapt warning configuration to new release of MSVC 19

Recently, MSVC introduced a new warning C5240 that apparently refers
to standard-compliant ordering of attributes and decl-specifies.
Unfortunately, this warning is triggered by Qt headers, in particular:

C:\CraftMaster\windows-msvc2019_64-cl\include\qt5\QtGui/qcolor.h(233):
    warning C5240: 'nodiscard': attribute is ignored in this syntactic position

Since we cannot fix this ourselves, make the warning non-fatal for now.
This fixes our CI failing with the new MSVC version.

Reenable C4244, which is no longer triggered by Quassel code, and add
some reasoning for the remaining warnings.
cmake/QuasselCompileSettings.cmake