projects / quassel.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 13f93f7) | patch
Properly handle QGenericReturnArgument
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 27 Mar 2012 20:04:03 +0000 (22:04 +0200)
committerManuel Nickschas <sputnick@quassel-irc.org>
Tue, 22 May 2012 19:55:00 +0000 (21:55 +0200)
commitd643d4ac5b34d50ad69808c3b2e9819ea39ac999
tree78bc8f3186b010e248832e0246882e121be9ea91tree | snapshot
parent13f93f79769b3d789e263088675abf7f1276a0dbcommit | diff
Properly handle QGenericReturnArgument

Using the memory address of the QVariant that acts as buffer is bad. While we got
lucky with Qt4, and this worked by accident, it leads to subtle and not-so-subtle segfaults
when used with Qt5.

Instead, using QVariant::data() makes sure that implicitly shared data is properly detached.
src/common/syncableobject.cpp diff | blob | history
Quassel IRC